qt: Get rid of cursor in out-of-focus labels #19210

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:200608-cursor changing 3 files +39 −0

hebasto commented at 1:58 PM on June 8, 2020: member
After clicking on QLabel with selectable text the cursor remains forever:

This PR fixes this visual bug.

Earlier attempts to fix this issue:
- #14577
- #14810 (combined with other UX feature)
fanquake added the label GUI on Jun 8, 2020
laanwj commented at 12:31 PM on June 9, 2020: member

Concept ACK, multiple cursors visible is wtf-level confusing.

Should this be reported as an upstream issue too?

in src/qt/guiutil.cpp:463 in 4b7c95324f outdated

 458 | +bool LabelOutOfFocusEventFilter::eventFilter(QObject* watched, QEvent* event)
 459 | +{
 460 | +    if (event->type() == QEvent::FocusOut) {
 461 | +        QLabel* label = qobject_cast<QLabel*>(watched);
 462 | +        if (label) {
 463 | +            const QString content = label->text();

promag commented at 10:01 PM on June 10, 2020:

This also works

          auto flags = label->textInteractionFlags();
          label->setTextInteractionFlags(Qt::NoTextInteraction);
          label->setTextInteractionFlags(flags);

hebasto commented at 3:00 PM on July 3, 2020:

It looks more effective. Thanks!

Updated.

promag commented at 10:02 PM on June 10, 2020: member

Concept ACK. Tested this approach and the one I'm suggesting. Does it make sense to have a dedicated label subclass?
luke-jr commented at 4:24 AM on June 11, 2020: member

This seems ugly. Ideally, if the focus returns to the label, the cursor position shouldn't be lost.
hebasto commented at 2:07 PM on July 3, 2020: member

@laanwj

Should this be reported as an upstream issue too?

https://bugreports.qt.io/browse/QTBUG-59514
hebasto force-pushed on Jul 3, 2020
hebasto commented at 2:58 PM on July 3, 2020: member
Updated 4b7c95324f40738185f52da161d144f6e9f0c484 -> 5dbe2d60a83c06d550f104d79e1b9c82e49c7008 (pr19210.01 -> pr19210.02, diff):
- addressed @promag's comment
This also works
- fixed context menu event handling
hebasto commented at 3:03 PM on July 3, 2020: member

@promag

Does it make sense to have a dedicated label subclass?

I think, it does not required. @luke-jr

This seems ugly. Ideally, if the focus returns to the label, the cursor position shouldn't be lost.

Unfortunately, the QLabel class has no property that holds the cursor position.

in src/qt/bitcoin.cpp:560 in 5dbe2d60a8 outdated

 555 | @@ -556,6 +556,9 @@ int GuiMain(int argc, char* argv[])
 556 |      /// 9. Main GUI initialization
 557 |      // Install global event filter that makes sure that long tooltips can be word-wrapped
 558 |      app.installEventFilter(new GUIUtil::ToolTipToRichTextFilter(TOOLTIP_WRAP_THRESHOLD, &app));
 559 | +    // Install global event filter that makes sure that out-of-focus labels do not contain text cursor.
 560 | +    // This is a temporary fix of QTBUG-59514.

promag commented at 3:22 PM on July 3, 2020:

nit, move/copy this comment to class doc.

hebasto commented at 3:32 PM on July 3, 2020:

Updated.

promag commented at 3:26 PM on July 3, 2020: member

Code review ACK 5dbe2d60a83c06d550f104d79e1b9c82e49c7008.
qt: Get rid of cursor in out-of-focus labels
This change is a temporary fix of QTBUG-59514.
bd315eb5e2
hebasto force-pushed on Jul 3, 2020
hebasto commented at 3:31 PM on July 3, 2020: member
Updated 5dbe2d60a83c06d550f104d79e1b9c82e49c7008 -> bd315eb5e27d49d47759ae9417328427426cb269 (pr19210.02 -> pr19210.03, diff):
- addressed @promag's comment
nit, move/copy this comment to class doc
promag commented at 8:37 AM on July 6, 2020: member

Code review ACK bd315eb5e27d49d47759ae9417328427426cb269.
fanquake commented at 2:41 PM on July 9, 2020: member

@laanwj can you take another look here? If you're happy with this change as-is, we can probably merge is here rather than punting to the GUI repo. We've now also got an upstream issue to refer too.
laanwj commented at 2:47 PM on July 15, 2020: member

Tested ACK bd315eb5e27d49d47759ae9417328427426cb269
laanwj merged this on Jul 15, 2020
laanwj closed this on Jul 15, 2020
hebasto deleted the branch on Jul 15, 2020
sidhujag referenced this in commit 6db274eaa0 on Jul 16, 2020
deadalnix referenced this in commit 1c0fc5229d on Sep 1, 2021
PastaPastaPasta referenced this in commit 3b0144beeb on Sep 21, 2021
kittywhiskers referenced this in commit f8470b479a on Oct 12, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#14577 qt: Cleanup `textInteractionFlags` for `QLabel`#14810 qt: Enable tabbing through labels