util: use HAVE_FDATASYNC to determine fdatasync() use

fanquake commented at 2:44 pm on July 28, 2020: member

Rather than just using on Linux and NetBSD, use fdatasync() based on whether it’s available. i.e fdatasync is available in newer versions of FreeBSD.

This also aligns more closely with what is being done in leveldb.

Was pointed out by Luke in #19430.

Rather than just using it on Linux and NetBSD, use `fdatasync()` based
on whether it's available. i.e it is available in newer versions
of FreeBSD (11.1 and later).

This also aligns our code more closely with what is being done in leveldb.

Was pointed out by Luke in #19430.

1d8338d6b7

fanquake added the label Utils/log/libs on Jul 28, 2020

fanquake added the label Needs gitian build on Jul 28, 2020

fanquake added the label Needs Guix build on Jul 28, 2020

DrahtBot commented at 4:59 pm on July 28, 2020: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#14501 (Fix possible data race when committing block files by luke-jr)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

hebasto approved

hebasto commented at 11:01 am on July 29, 2020: member

ACK 1d8338d6b71447a5bf18750ca44724345aae5b60

HAVE_FDATASYNC is defined here: https://github.com/bitcoin/bitcoin/blob/2f71a1ea35667b3873197201531e7ae198ec5bf4/configure.ac#L1014-L1020

and dnl LevelDB platform checks comment seems outdated now.

DrahtBot commented at 11:13 am on July 29, 2020: member

Gitian builds

File	commit a41ae68053387567414021228995a485e29ad611(master)	commit 23a899deeda5cd72bcbef09ac48b160d0dc54318(master and this pull)
*-aarch64-linux-gnu-debug.tar.gz	`2c5d1671feadd5e0...`	`88e896065793e457...`
*-aarch64-linux-gnu.tar.gz	`c7062ea145dcbd3b...`	`79eadb5a7b818f12...`
*-arm-linux-gnueabihf-debug.tar.gz	`7e77e81bd5ec6f8a...`	`9ac2355251f91774...`
*-arm-linux-gnueabihf.tar.gz	`84ccb33a9842229d...`	`9b879e43e3331f97...`
*-osx-unsigned.dmg	`4a9adb0aa5ec9a6f...`	`857f7b32c6a1634b...`
*-osx64.tar.gz	`545fa26bc01a9b79...`	`d34e7ac615266fb6...`
*-riscv64-linux-gnu-debug.tar.gz	`2c4d543bc1b43d33...`	`8fa4edab26644fea...`
*-riscv64-linux-gnu.tar.gz	`41bca6ecee146491...`	`fd80fcf7ad14ac5a...`
*-win64-debug.zip	`9f8bb80a3fd510b8...`	`71f082a0c710cf5b...`
*-win64-setup-unsigned.exe	`db04c170eb0f0c75...`	`7f03cfbb8ef814ca...`
*-win64.zip	`c2ffbc59409f3c00...`	`714f958f42159a84...`
*-x86_64-linux-gnu-debug.tar.gz	`15a0f0131e7daef1...`	`fe84f19e087c2753...`
*-x86_64-linux-gnu.tar.gz	`22446c2d1d1d1b4d...`	`e37d7151dfd1876d...`
*.tar.gz	`a623828de9051d68...`	`d9372d15e2d72920...`
bitcoin-core-linux-0.21-res.yml	`00484df79e5bcebf...`	`62cf9376723af9b6...`
bitcoin-core-osx-0.21-res.yml	`f850bd04d4efe283...`	`c14945487090308b...`
bitcoin-core-win-0.21-res.yml	`5a1e861d61d968f1...`	`1e08ac81f4765cbe...`
linux-build.log	`33a770b52a732fab...`	`25f673974e2f4b80...`
osx-build.log	`fe6f0571f7541f57...`	`03dddb17abad5df9...`
win-build.log	`c7cae424b8235045...`	`ee9e48b59ef97779...`
bitcoin-core-linux-0.21-res.yml.diff		`8209209053652b0f...`
bitcoin-core-osx-0.21-res.yml.diff		`ef3ec4ebdcddfb1f...`
bitcoin-core-win-0.21-res.yml.diff		`baf7cfa6e1746c45...`
linux-build.log.diff		`cda35ff5b2e78a2b...`
osx-build.log.diff		`0e0b7a60a63a5785...`
win-build.log.diff		`8fee1e52f55901a8...`

DrahtBot removed the label Needs gitian build on Jul 29, 2020

DrahtBot commented at 8:20 am on July 30, 2020: member

Guix builds

File	commit 8db23349fe9b512e6801d59d17052c5a7a1c64df(master)	commit 939b8d11be84d8c439e38ee3b651a1b3ed99d55d(master and this pull)
*-aarch64-linux-gnu-debug.tar.gz	`d6b57beb5563ca6f...`	`28ff9966094d1c09...`
*-aarch64-linux-gnu.tar.gz	`1d94eea3e5cbf71a...`	`ae01d9d16f33cd0d...`
*-arm-linux-gnueabihf-debug.tar.gz	`39cf2efb57a15779...`	`8b9cbb90545a08df...`
*-arm-linux-gnueabihf.tar.gz	`ea581c23aaa89ef5...`	`91bce2fbc5ab2586...`
*-riscv64-linux-gnu-debug.tar.gz	`4dce94f7be912c67...`	`ef8f261fc3bf9300...`
*-riscv64-linux-gnu.tar.gz	`0f33b0d1cae94bac...`	`592b5a44acf1e093...`
*-win-unsigned.tar.gz	`61595ca3b7550e2d...`	`4ff6494b0b1929f9...`
*-win64-debug.zip	`722570586f961976...`	`baa17049d282f781...`
*-win64-setup-unsigned.exe	`7fee753a79251a55...`	`e8481a5aa7d49084...`
*-win64.zip	`90fb39f80493b473...`	`277603577b7b707a...`
*-x86_64-linux-gnu-debug.tar.gz	`ee1e44745f2c540a...`	`0a68735a091a7de0...`
*-x86_64-linux-gnu.tar.gz	`00a382982c4a3791...`	`3e4d515d97fe3e8a...`
*.tar.gz	`f7c2ffa73666984d...`	`4b968d73507f71cf...`
guix_build.log	`4c2f5c058987faa9...`	`834aab9d9c57dc2e...`
guix_build.log.diff		`b363a29b903fda95...`

DrahtBot removed the label Needs Guix build on Jul 30, 2020

practicalswift commented at 3:54 pm on August 3, 2020: contributor

ACK 1d8338d6b71447a5bf18750ca44724345aae5b60 – patch looks correct

laanwj commented at 3:33 pm on August 5, 2020: member

Wait, we already probe for HAVE_FDATASYNC in the build system but don’t use it? Weird. ACK 1d8338d6b71447a5bf18750ca44724345aae5b60

laanwj merged this on Aug 5, 2020

laanwj closed this on Aug 5, 2020

sidhujag referenced this in commit 8e779803bf on Aug 5, 2020

fanquake deleted the branch on Aug 6, 2020

luke-jr commented at 5:47 pm on August 20, 2020: member

HAVE_FDATASYNC was only being defined for LevelDB. Added a fix for this to #14501

fanquake referenced this in commit 0adb80fe63 on Aug 31, 2020

sidhujag referenced this in commit b58c80dbee on Aug 31, 2020

Fabcien referenced this in commit 89fed9b66d on Sep 7, 2021

PastaPastaPasta referenced this in commit 98c0cbf0ba on Sep 17, 2021

PastaPastaPasta referenced this in commit 682dba0245 on Sep 19, 2021

thelazier referenced this in commit 9a21e410f6 on Sep 25, 2021

DrahtBot locked this on Feb 15, 2022

util: use HAVE_FDATASYNC to determine fdatasync() use #19614

Conflicts

Gitian builds

Guix builds