build: set minimum required Boost to 1.58.0 #19667

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:boost_1_58_0 changing 2 files +4 −65

fanquake commented at 5:22 am on August 5, 2020: member

Any systems which only have an older installable Boost can use depends. 1.58.0 retains compatibility with the packages installable on Ubuntu 16.04.

The projects usage of Boost wont be going away any time soon, if ever (i.e #15382), and our usage of the test framework.

Fixes: #19506
fanquake added the label Build system on Aug 5, 2020
fanquake added the label Needs gitian build on Aug 5, 2020
fanquake added the label Needs Guix build on Aug 5, 2020
fanquake added this to the milestone 0.21.0 on Aug 5, 2020
MarcoFalke commented at 5:40 am on August 5, 2020: member

Concept ACK. Given that no one complained about the compile failure yet (other than me) probably means no one is running on that system. And it is still possible to compile from depends.
hebasto commented at 8:53 am on August 5, 2020: member

Concept ACK.

build: set minimum required Boost to 1.58

Any systems which only have an older install-able Boost can use depends.

Fixes: #19506

70452a070b

fanquake force-pushed on Aug 5, 2020
hebasto approved
hebasto commented at 9:15 am on August 5, 2020: member

ACK 70452a070b3b6d4d650a948b3337bc7b8bb2c3c3, tested on Linux Mint 20 (x86_64).
MarcoFalke commented at 9:19 am on August 5, 2020: member

For reference, here is the availability of boost in OSes: #16381 (comment) So, debian:jessie and centos:7 will from now on use depends to build Bitcoin Core, which seems fine.
laanwj commented at 1:08 pm on August 5, 2020: member

ACK 70452a070b3b6d4d650a948b3337bc7b8bb2c3c3

I wonder if there are more boost version workarounds that can be removed, but couldn’t find anything with a naive search for BBOST_VERSION at leat.

DrahtBot commented at 7:25 pm on August 5, 2020: member

File	commit 0f16212c5931b30f430014caa485de53f9a14920(master)	commit 33a1ef09523de33ff3a3399b1fc5cd3dff9c3df7(master and this pull)
*-aarch64-linux-gnu-debug.tar.gz	`0dfa29c4a69b6fb7...`	`0532334e8e3298ff...`
*-aarch64-linux-gnu.tar.gz	`4bb086beab5cb17a...`	`cf85ba65d0de472c...`
*-arm-linux-gnueabihf-debug.tar.gz	`8937c114b59e001f...`	`ff2fe3d55e0d9671...`
*-arm-linux-gnueabihf.tar.gz	`d34a9f1130a95611...`	`c25e5c1fac6040c5...`
*-riscv64-linux-gnu-debug.tar.gz	`07a51d5d320b6ca4...`	`956ff04a2d99872d...`
*-riscv64-linux-gnu.tar.gz	`2b2b67cd096e77a7...`	`d7783c7d5c6f8ecf...`
*-win-unsigned.tar.gz	`d55054ad2c1ae0cf...`	`a630a68df16b3d40...`
*-win64-debug.zip	`3e79bb97d04040b7...`	`20d546b5c7dd4f76...`
*-win64-setup-unsigned.exe	`9a54e8ef6408b1c5...`	`9ca51a1d5f9c34e8...`
*-win64.zip	`b9f473d6dedfc2c4...`	`3943eccb59f901a0...`
*-x86_64-linux-gnu-debug.tar.gz	`d3b50c729f53419a...`	`5a02efd70b207fb5...`
*-x86_64-linux-gnu.tar.gz	`3de5c36197b49d11...`	`54ea7f328e020619...`
*.tar.gz	`bd1e31b60c402683...`	`c7f5399bde87ef9b...`
guix_build.log	`69791fc6dd71841a...`	`4f6e7b7bd03cede0...`
guix_build.log.diff		`3007c685cf3d3090...`

DrahtBot commented at 3:13 am on August 6, 2020: member

File	commit e3272ff2907ca7a769d624698831a8605251b295(master)	commit c81f0eda7c5f541155496a14d49f5859ef04b539(master and this pull)
bitcoin-core-linux-0.21-res.yml	`6424df7c26806d72...`
bitcoin-core-win-0.21-res.yml	`24697b61456dc6e7...`
*-aarch64-linux-gnu-debug.tar.gz	`f51911ec9a64338b...`
*-aarch64-linux-gnu.tar.gz	`948666023ba1a895...`
*-arm-linux-gnueabihf-debug.tar.gz	`2ca5be799a7fcbb5...`
*-arm-linux-gnueabihf.tar.gz	`17e58f8ba54dd1ac...`
*-riscv64-linux-gnu-debug.tar.gz	`228ead59e5811c1f...`
*-riscv64-linux-gnu.tar.gz	`f58d692512fdbae4...`
*-win64-debug.zip	`d8c675be72a24179...`
*-win64-setup-unsigned.exe	`2ea4f8ae762c1d7b...`
*-win64.zip	`5e39e41c0096725f...`
*-x86_64-linux-gnu-debug.tar.gz	`baea5ed409e6aa32...`
*-x86_64-linux-gnu.tar.gz	`543a49f4d4bdea2e...`
*.tar.gz	`d4f179e9da6d20b4...`
linux-build.log	`fab3e95ec2bcf5c7...`
win-build.log	`fc0a91b685c0bb2d...`

DrahtBot removed the label Needs gitian build on Aug 6, 2020
practicalswift commented at 8:48 am on August 6, 2020: contributor

ACK 70452a070b3b6d4d650a948b3337bc7b8bb2c3c3 – patch looks correct

Nice cleanup!
fanquake merged this on Aug 6, 2020
fanquake closed this on Aug 6, 2020
fanquake deleted the branch on Aug 6, 2020
sidhujag referenced this in commit d1dcb3c0ba on Aug 6, 2020
hebasto commented at 7:13 pm on October 4, 2020: member

It turned out that before this change the actual minimum supported Boost version was 1.48 rather 1.47.
barton2526 referenced this in commit 34c25f485d on Jun 23, 2021
barton2526 referenced this in commit 07a4e3d578 on Jun 24, 2021
Fabcien referenced this in commit 572f52819d on Nov 29, 2021
DrahtBot locked this on Feb 15, 2022

Milestone
0.21.0