To simplify the interface of the Base32/Base64 encoding functions for raw data, this PR changes them from taking two arguments (pointer and length) to just one Span. Most calls to EncodeBase64 pass data from CDataStream instances, which unfortunately internally work with char* pointers rather than unsigned char*, but thanks to the recently introduced MakeUCharSpan helper, converting them is quite easy.
refactor: make EncodeBase{32,64} consume Spans #19687
pull theStack wants to merge 2 commits into bitcoin:master from theStack:20200807-util-make-encode-base3264-consume-spans changing 5 files +20 −19-
theStack commented at 11:12 AM on August 8, 2020: member
- DrahtBot added the label P2P on Aug 8, 2020
- DrahtBot added the label Refactoring on Aug 8, 2020
- DrahtBot added the label RPC/REST/ZMQ on Aug 8, 2020
- DrahtBot added the label Utils/log/libs on Aug 8, 2020
- MarcoFalke removed the label P2P on Aug 8, 2020
- MarcoFalke removed the label RPC/REST/ZMQ on Aug 8, 2020
-
DrahtBot commented at 8:47 PM on August 8, 2020: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
-
laanwj commented at 2:43 PM on August 9, 2020: member
Code review and concept ACK 08e73a2abf0035305b2d1a08f62161cd36cb39a5
-
promag commented at 8:17 AM on August 10, 2020: member
Concept ACK
- vasild approved
-
vasild commented at 12:48 PM on August 10, 2020: member
ACK 08e73a2ab
-
-
- laanwj referenced this in commit 44ddcd887d on Aug 19, 2020
- sidhujag referenced this in commit d2b5dc4fbc on Aug 19, 2020
- DrahtBot added the label Needs rebase on Aug 25, 2020
-
util: make EncodeBase32 consume Spans 2bc207190e
-
util: make EncodeBase64 consume Spans e2aa1a585a
- theStack force-pushed on Aug 25, 2020
-
- DrahtBot removed the label Needs rebase on Aug 25, 2020
- vasild approved
-
vasild commented at 7:47 AM on August 26, 2020: member
ACK e2aa1a585
-
MarcoFalke commented at 9:51 AM on August 26, 2020: member
ACK e2aa1a585a83971639572cd2c84565ec360deac9 🐮
<details><summary>Show signature and timestamp</summary>
Signature:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 ACK e2aa1a585a83971639572cd2c84565ec360deac9 🐮 -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p pUhs1Qv/QF5OYwppGsljksi+aAtIQl4ak8TlPxkTzbTTt0yKnxT0cll0Wi3mBjpl KnH0WqaKoGPpKX2WuZMDEw6ElIrGn2m8NKHHGDPd6RV+/VsXsoqJTfN0b9EyxOR1 b8I7WzTQ55sCOz9qxod2VwRhYupjJLaKPrOHkEsJbu+Cdp1W4V31nBK0le/Sbz3k 1P+kGTQBQJ4J7/R3ut6uv1AQM/yagTNIYJyujQ8dfaMY9W0463oBmzEZUC0Onn0n KD7lz9PhTy+Fab+eS4KGXqvdNwbTND5cC98ZbabeZYTtySOviXuuAOTkE/wqWAoW Y/BujW0WCR7RkKafTww4ehdHu4hM9EBu6XmUBJoN0WGnLz9tc4lzut7gEZVDdAxf 0H9iKZG8rRSjmaGLylRsN7ZVTrd4RI2cYOZgdW1tHXB3/9cjqCe8t8WLAKAbpbZd Cqt42I0/3k1sSOs09RuYm1U6PRJPKdUiQsGTwEG1JHVwqfHmkJh27y8VFLNP6Lts ExD2MEbH =DLNB -----END PGP SIGNATURE-----Timestamp of file with hash
6167e6861d81d53ab89ae9db25b356c5a5eeb5c7f418be3c91e0cec0355a00bf -</details>
- MarcoFalke merged this on Aug 26, 2020
- MarcoFalke closed this on Aug 26, 2020
- theStack deleted the branch on Dec 1, 2020
- Fabcien referenced this in commit 545de4f0d2 on Feb 9, 2021
- kittywhiskers referenced this in commit a9ee7ab13f on May 18, 2021
- kittywhiskers referenced this in commit b05773ffd4 on May 20, 2021
- kittywhiskers referenced this in commit f757937b52 on May 20, 2021
- kittywhiskers referenced this in commit 8ae49136bb on May 21, 2021
- kittywhiskers referenced this in commit 9dad315032 on May 22, 2021
- kittywhiskers referenced this in commit 065cc46b91 on May 23, 2021
- PastaPastaPasta referenced this in commit 41a8349d4d on May 23, 2021
- random-zebra referenced this in commit 56f10aaa51 on Jul 21, 2021
- random-zebra referenced this in commit b4751e10ce on Aug 11, 2021
- DrahtBot locked this on Feb 15, 2022
