build: Add Qt version checking

hebasto commented at 11:14 pm on August 9, 2020: member

Now configure script checks that Qt version is not less then minimum required (currently 5.5.1).

This PR is an alternative to #15706 (see #15706 (comment)).

Closes #15688.

The first commit removes dead code (see #18297 (comment)).

build: Drop unused bitcoin_cv_qt58 30e336f785

build, qt: Add Qt version checking 4af4672525

DrahtBot added the label Build system on Aug 10, 2020

fanquake renamed this:
~~build, qt: Add Qt version checking~~
build: Add Qt version checking
on Aug 10, 2020

DrahtBot commented at 2:15 am on August 10, 2020: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#19716 (build: Qt 5.15.x by fanquake)
#18750 (build: optionally skip external warnings by vasild)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

laanwj commented at 12:40 pm on August 10, 2020: member

Concept and light code review ACK (I’ll leave reviewing the build system changes in detail to someone else)

fanquake added the label Needs gitian build on Aug 18, 2020

fanquake added the label Needs Guix build on Aug 18, 2020

fanquake approved

fanquake commented at 5:31 am on August 18, 2020: member

ACK 4af4672525f698c7b491023fcd36a17a4e982070 - this looks ok. I’ve tested this with Qt 5.15.0 and Qt 5.7.1 system libs, as well as 5.9.8 from depends.

30e336f785e1b662cade3cfacea91a9785ea1023 - The check that used to set this, and all the other previous usages have been removed.

Have queued some gitian/guix builds.

DrahtBot commented at 0:45 am on August 22, 2020: member

Gitian builds

File	commit e9b30126545d6ddd8772363e4079d1e4908ad117(master)	commit f5438712c42851771e81ba87655e147844a2867d(master and this pull)
bitcoin-core-linux-0.21-res.yml	`cea1ba265603d02f...`	`16a89a67e10a19bf...`
bitcoin-core-osx-0.21-res.yml	`77d7884f6a574134...`	`a2cd12570f8e4bfa...`
bitcoin-core-win-0.21-res.yml	`0b0f6bbbd9a5c0ef...`	`0c891a685a704192...`
*-aarch64-linux-gnu-debug.tar.gz	`4ed42dd1dc70bea9...`	`d66448fc7ca70bfe...`
*-aarch64-linux-gnu.tar.gz	`8a7a6ef9cccbae35...`	`62fe63fa741c7bb3...`
*-arm-linux-gnueabihf-debug.tar.gz	`e40e4858ee8bd4d1...`	`dd64285cc64ae743...`
*-arm-linux-gnueabihf.tar.gz	`7ddca7cad75ef53b...`	`389607eb139a8240...`
*-osx-unsigned.dmg	`79a2858ea685e8b0...`	`a24c61c924546437...`
*-osx64.tar.gz	`e77905a2f3abb599...`	`d928876187dc339b...`
*-riscv64-linux-gnu-debug.tar.gz	`4ccc4f940f998b62...`	`7ba6a8c2d486542b...`
*-riscv64-linux-gnu.tar.gz	`561c5ed7ebaf0ea5...`	`f6b4318444335343...`
*-win64-debug.zip	`e0b30b67a2217a50...`	`087cb0f6f50f5162...`
*-win64-setup-unsigned.exe	`3e5025cde6a4d3d5...`	`2a68c3e8d53679b6...`
*-win64.zip	`caee7761af12305b...`	`ac31734edf91742a...`
*-x86_64-linux-gnu-debug.tar.gz	`4036b1cb7c0177b0...`	`13d944d13c47340f...`
*-x86_64-linux-gnu.tar.gz	`e15879353155c44c...`	`129ae8f33f4d91ea...`
*.tar.gz	`e8cbb99f0f9f02a0...`	`e41ecf1e1d32819d...`
linux-build.log	`43933168846d907b...`	`608b59ce550cee7d...`
osx-build.log	`f0d612ea7fbc1c07...`	`b16c94e7e06bf166...`
win-build.log	`54a3cd2d3d8f9dd4...`	`745a9c735678b819...`
bitcoin-core-linux-0.21-res.yml.diff		`8c5ef2bca5c099ca...`
bitcoin-core-osx-0.21-res.yml.diff		`e4e30f88aaea2af2...`
bitcoin-core-win-0.21-res.yml.diff		`7127b0306b8cb8f0...`
linux-build.log.diff		`0b1949a2b2be1700...`
osx-build.log.diff		`f078211466e9bfff...`
win-build.log.diff		`40fcfa7d8740b8ea...`

DrahtBot removed the label Needs gitian build on Aug 22, 2020

fanquake merged this on Aug 24, 2020

fanquake closed this on Aug 24, 2020

hebasto deleted the branch on Aug 24, 2020

DrahtBot commented at 8:10 am on August 24, 2020: member

Guix builds

File	commit 197450f80868fe752c6107955e5da80704212b34(master)	commit e4c7e956127e7e5cf257c0bf4ed7a46bbd92dc77(master and this pull)
*-aarch64-linux-gnu-debug.tar.gz	`8943872ac3d5df7c...`	`d14cb24c1fdb9ef8...`
*-aarch64-linux-gnu.tar.gz	`7307c4ee3d4934bd...`	`4c61b246b4a87f87...`
*-arm-linux-gnueabihf-debug.tar.gz	`fccc26d7c7dfa90b...`	`0aadadf72b55b668...`
*-arm-linux-gnueabihf.tar.gz	`34e1140f65a0f606...`	`627c3c6760ad32b8...`
*-riscv64-linux-gnu-debug.tar.gz	`a94385d318571b00...`	`ecfdb7b778cb2529...`
*-riscv64-linux-gnu.tar.gz	`3abb016b01e33949...`	`cfff43cb55164f9d...`
*-win-unsigned.tar.gz	`f35d661c7f1bbdae...`	`c840f3fa6ffe529c...`
*-win64-debug.zip	`62437d10c94cfef6...`	`5467a83b69c2224c...`
*-win64-setup-unsigned.exe	`5e2b6831dd645b79...`	`1db77c30421d188e...`
*-win64.zip	`c9829996dc3386f5...`	`37b21d057e03abb4...`
*-x86_64-linux-gnu-debug.tar.gz	`effc996453960003...`	`9c2a867c0bf922d8...`
*-x86_64-linux-gnu.tar.gz	`7ef18c4f4cd4f2e2...`	`c2ae836b87e3a4a1...`
*.tar.gz	`5c60a590f5e9971c...`	`81df8cb087ecfdd8...`
guix_build.log	`3eca0392f5149475...`	`1e8108363d02af0e...`
guix_build.log.diff		`19be2837860d4e49...`

DrahtBot removed the label Needs Guix build on Aug 24, 2020

sidhujag referenced this in commit dafb919f5c on Aug 24, 2020

xdustinface referenced this in commit 3e8687603d on Feb 17, 2021

gades referenced this in commit 0e12d032a0 on Jun 27, 2021

DrahtBot locked this on Feb 15, 2022

build: Add Qt version checking #19689

Conflicts

Gitian builds

Guix builds