doc: update PyZMQ install instructions, fix zmq_sub.py file permissions #19870
pull jonatack wants to merge 2 commits into bitcoin:master from jonatack:zmq-doc-fix changing 2 files +4 −3-
jonatack commented at 12:05 pm on September 4, 2020: memberSeen while reviewing #19572.
-
fanquake added the label Docs on Sep 4, 2020
-
doc: update PyZMQ installation instructions, ZeroMQ link 36f8e0cce7
-
script: fix zmq_sub.py file permissions 062e6699c4
-
in doc/zmq.md:3 in 9e18609cc4 outdated
0@@ -1,6 +1,6 @@ 1 # Block and Transaction Broadcasting with ZeroMQ 2 3-[ZeroMQ](http://zeromq.org/) is a lightweight wrapper around TCP 4+[ZeroMQ](https://zeromq.org/) is a lightweight wrapper around TCP
laanwj commented at 1:37 pm on September 4, 2020:How are we stil finding http links in the repository in the year 2020 :sweat_smile:
practicalswift commented at 3:18 pm on September 4, 2020:Thanks for fixing @jonatack! :)
Aside:
A
scripted-diff
might be needed to bring the remaining old school style links to year 2020 :)0$ git grep 'http://www.opensource.org/licenses/mit-license.php' | wc -l 11092
Bonus points if we can remove the external – and thus potentially changing – reference to simply referencing the
COPYING
file. That would get rid of the horriblephp
extension too :)Edit: Not a suggestion for this PR.
jonatack commented at 3:43 pm on September 4, 2020:True :dango: :icecream: though updating all those links isn’t really in the scope of this patch. I actually only noticed the http url just before opening it. :shipit:
laanwj commented at 11:18 am on September 5, 2020:Ahhhhh updating 1002 files sounds … pretty awful … that fully answers my question though. Together with XML schemas and such it makes it hard to search for relevant ones. Agree it’s out of scope of this PR, if worthwhile at all (not sure anymroe).jonatack force-pushed on Sep 4, 2020jonatack renamed this:
doc: update PyZMQ installation instructions, ZeroMQ link
script, doc: update PyZMQ install instructions, fix zmq_sub.py file permissions
on Sep 4, 2020jonatack commented at 3:57 pm on September 4, 2020: memberIf I’m not mistaken,contrib/zmq/zmq_sub.py
has the wrong file permissions; changed them to755
.theStack approvedtheStack commented at 7:02 pm on September 6, 2020: memberACK 062e6699c4ac48c3d46516190ec411dec3680a0d 🧷 Checked that the changed/introduced URLs are visitable and correct and that the PyZMQ install instruction via pip works (tested in Ubuntu Xenial). Also ran the zmq_sub.py script directly to double-check that the execution flag is set now.fanquake approvedfanquake commented at 5:11 am on September 11, 2020: memberACK 062e6699c4ac48c3d46516190ec411dec3680a0dfanquake renamed this:
script, doc: update PyZMQ install instructions, fix zmq_sub.py file permissions
doc: update PyZMQ install instructions, fix zmq_sub.py file permissions
on Sep 11, 2020fanquake merged this on Sep 11, 2020fanquake closed this on Sep 11, 2020
jonatack deleted the branch on Sep 11, 2020sidhujag referenced this in commit 27c6cdde45 on Sep 11, 2020PastaPastaPasta referenced this in commit bc18d5d458 on Jun 27, 2021PastaPastaPasta referenced this in commit 9762ada89e on Jun 28, 2021PastaPastaPasta referenced this in commit 36237fe794 on Jun 29, 2021PastaPastaPasta referenced this in commit 66c1ad151a on Jul 1, 2021PastaPastaPasta referenced this in commit b17d32b26f on Jul 1, 2021PastaPastaPasta referenced this in commit 6ef9992a26 on Jul 15, 2021PastaPastaPasta referenced this in commit 788e3d31b4 on Jul 16, 2021deadalnix referenced this in commit 738a757d5d on Oct 1, 2021DrahtBot locked this on Feb 15, 2022
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 18:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 18:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me