depends: Fix `make --just-print` command #19891

hebasto commented at 9:30 AM on September 6, 2020: member

Dry run make is very useful for debugging. From the GNU make manual:

‘-n’ ‘--just-print’ ‘--dry-run’ ‘--recon’

“No-op”. Causes make to print the recipes that are needed to make the targets up to date, but not actually execute them. Note that some recipes are still executed, even with this flag (see How the MAKE Variable Works). Also any recipes needed to update included makefiles are still executed (see How Makefiles Are Remade).

On master (03689317021a72431762c1974530f2a980a7fffa) this option is not so useful:

$ make -n -C depends zlib
make: Entering directory '/home/hebasto/guix/GitHub/bitcoin/depends'
mkdir -p /home/hebasto/guix/GitHub/bitcoin/depends/sources/download-stamps /home/hebasto/guix/GitHub/bitcoin/depends/sources
rm -f /home/hebasto/guix/GitHub/bitcoin/depends/sources/download-stamps/.stamp_fetched-zlib-zlib-1.2.11.tar.gz.hash
touch /home/hebasto/guix/GitHub/bitcoin/depends/sources/download-stamps/.stamp_fetched-zlib-zlib-1.2.11.tar.gz.hash
cd /home/hebasto/guix/GitHub/bitcoin/depends/sources/download-stamps; ( test -f /home/hebasto/guix/GitHub/bitcoin/depends/sources/zlib-1.2.11.tar.gz || (     ( mkdir -p /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11 && echo Fetching zlib-1.2.11.tar.gz from https://www.zlib.net && curl --location --fail --connect-timeout 30 --retry 3 -o "/home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/zlib-1.2.11.tar.gz.temp" "https://www.zlib.net/zlib-1.2.11.tar.gz" && echo "c3e5e9fdd5004dcb542feda5ee4f0ff0744628baf8ed2dd5d66f8ca1197cb1a1  /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/zlib-1.2.11.tar.gz.temp" > /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/.zlib-1.2.11.tar.gz.hash && sha256sum -c /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/.zlib-1.2.11.tar.gz.hash && mv /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/zlib-1.2.11.tar.gz.temp /home/hebasto/guix/GitHub/bitcoin/depends/sources/zlib-1.2.11.tar.gz && rm -rf /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11 ) ||     ( mkdir -p /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11 && echo Fetching zlib-1.2.11.tar.gz from https://bitcoincore.org/depends-sources && curl --location --fail --connect-timeout 30 --retry 3 -o "/home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/zlib-1.2.11.tar.gz.temp" "https://bitcoincore.org/depends-sources/zlib-1.2.11.tar.gz" && echo "c3e5e9fdd5004dcb542feda5ee4f0ff0744628baf8ed2dd5d66f8ca1197cb1a1  /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/zlib-1.2.11.tar.gz.temp" > /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/.zlib-1.2.11.tar.gz.hash && sha256sum -c /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/.zlib-1.2.11.tar.gz.hash && mv /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/zlib-1.2.11.tar.gz.temp /home/hebasto/guix/GitHub/bitcoin/depends/sources/zlib-1.2.11.tar.gz && rm -rf /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11 )))
cd /home/hebasto/guix/GitHub/bitcoin/depends/sources; sha256sum zlib-1.2.11.tar.gz >> /home/hebasto/guix/GitHub/bitcoin/depends/sources/download-stamps/.stamp_fetched-zlib-zlib-1.2.11.tar.gz.hash;
touch /home/hebasto/guix/GitHub/bitcoin/depends/sources/download-stamps/.stamp_fetched-zlib-zlib-1.2.11.tar.gz.hash
echo Extracting zlib...
mkdir -p /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-4416f3f0c58
cd /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-4416f3f0c58; mkdir -p /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-4416f3f0c58 && echo "c3e5e9fdd5004dcb542feda5ee4f0ff0744628baf8ed2dd5d66f8ca1197cb1a1  /home/hebasto/guix/GitHub/bitcoin/depends/sources/zlib-1.2.11.tar.gz" > /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-4416f3f0c58/.zlib-1.2.11.tar.gz.hash &&  sha256sum -c /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-4416f3f0c58/.zlib-1.2.11.tar.gz.hash && tar --no-same-owner --strip-components=1 -xf /home/hebasto/guix/GitHub/bitcoin/depends/sources/zlib-1.2.11.tar.gz
touch /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-4416f3f0c58/.stamp_extracted
echo Preprocessing zlib...
mkdir -p /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-4416f3f0c58 /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-4416f3f0c58/.patches-4416f3f0c58
cd /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-4416f3f0c58; 
touch /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-4416f3f0c58/.stamp_preprocessed
echo Configuring zlib...
rm -rf /home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu; mkdir -p /home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu/lib; cd /home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu; 
mkdir -p /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-4416f3f0c58/.
cd /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-4416f3f0c58/.;     PKG_CONFIG_LIBDIR=/home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu/lib/pkgconfig PKG_CONFIG_PATH=/home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu/share/pkgconfig CMAKE_MODULE_PATH=/home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu/lib/cmake PATH=/home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu/native/bin:/home/hebasto/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin   env CC="gcc -m64" CFLAGS="-pipe -O2 -I/home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu/include -fPIC" RANLIB="ranlib" AR="ar"        ./configure --static --prefix=/home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu
/bin/sh: 1: cd: can't cd to /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-4416f3f0c58/.
env: ‘./configure’: No such file or directory
make: *** [funcs.mk:268: /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-4416f3f0c58/./.stamp_configured] Error 127

With this PR:

$ make -n -C depends zlib
make: Entering directory '/home/hebasto/guix/GitHub/bitcoin/depends'
mkdir -p /home/hebasto/guix/GitHub/bitcoin/depends/sources/download-stamps /home/hebasto/guix/GitHub/bitcoin/depends/sources
rm -f /home/hebasto/guix/GitHub/bitcoin/depends/sources/download-stamps/.stamp_fetched-zlib-zlib-1.2.11.tar.gz.hash
touch /home/hebasto/guix/GitHub/bitcoin/depends/sources/download-stamps/.stamp_fetched-zlib-zlib-1.2.11.tar.gz.hash
cd /home/hebasto/guix/GitHub/bitcoin/depends/sources/download-stamps; ( test -f /home/hebasto/guix/GitHub/bitcoin/depends/sources/zlib-1.2.11.tar.gz || (     ( mkdir -p /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11 && echo Fetching zlib-1.2.11.tar.gz from https://www.zlib.net && curl --location --fail --connect-timeout 30 --retry 3 -o "/home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/zlib-1.2.11.tar.gz.temp" "https://www.zlib.net/zlib-1.2.11.tar.gz" && echo "c3e5e9fdd5004dcb542feda5ee4f0ff0744628baf8ed2dd5d66f8ca1197cb1a1  /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/zlib-1.2.11.tar.gz.temp" > /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/.zlib-1.2.11.tar.gz.hash && sha256sum -c /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/.zlib-1.2.11.tar.gz.hash && mv /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/zlib-1.2.11.tar.gz.temp /home/hebasto/guix/GitHub/bitcoin/depends/sources/zlib-1.2.11.tar.gz && rm -rf /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11 ) ||     ( mkdir -p /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11 && echo Fetching zlib-1.2.11.tar.gz from https://bitcoincore.org/depends-sources && curl --location --fail --connect-timeout 30 --retry 3 -o "/home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/zlib-1.2.11.tar.gz.temp" "https://bitcoincore.org/depends-sources/zlib-1.2.11.tar.gz" && echo "c3e5e9fdd5004dcb542feda5ee4f0ff0744628baf8ed2dd5d66f8ca1197cb1a1  /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/zlib-1.2.11.tar.gz.temp" > /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/.zlib-1.2.11.tar.gz.hash && sha256sum -c /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/.zlib-1.2.11.tar.gz.hash && mv /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11/zlib-1.2.11.tar.gz.temp /home/hebasto/guix/GitHub/bitcoin/depends/sources/zlib-1.2.11.tar.gz && rm -rf /home/hebasto/guix/GitHub/bitcoin/depends/work/download/zlib-1.2.11 )))
cd /home/hebasto/guix/GitHub/bitcoin/depends/sources; sha256sum zlib-1.2.11.tar.gz >> /home/hebasto/guix/GitHub/bitcoin/depends/sources/download-stamps/.stamp_fetched-zlib-zlib-1.2.11.tar.gz.hash;
touch /home/hebasto/guix/GitHub/bitcoin/depends/sources/download-stamps/.stamp_fetched-zlib-zlib-1.2.11.tar.gz.hash
echo Extracting zlib...
mkdir -p /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a
cd /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a; mkdir -p /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a && echo "c3e5e9fdd5004dcb542feda5ee4f0ff0744628baf8ed2dd5d66f8ca1197cb1a1  /home/hebasto/guix/GitHub/bitcoin/depends/sources/zlib-1.2.11.tar.gz" > /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a/.zlib-1.2.11.tar.gz.hash &&  sha256sum -c /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a/.zlib-1.2.11.tar.gz.hash && tar --no-same-owner --strip-components=1 -xf /home/hebasto/guix/GitHub/bitcoin/depends/sources/zlib-1.2.11.tar.gz
touch /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a/.stamp_extracted
echo Preprocessing zlib...
mkdir -p /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a/.patches-38eb814ef0a
cd /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a; 
touch /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a/.stamp_preprocessed
echo Configuring zlib...
rm -rf /home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu; mkdir -p /home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu/lib; cd /home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu; 
mkdir -p /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a/.
cd /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a/.;     PKG_CONFIG_LIBDIR=/home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu/lib/pkgconfig PKG_CONFIG_PATH=/home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu/share/pkgconfig CMAKE_MODULE_PATH=/home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu/lib/cmake PATH=/home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu/native/bin:/home/hebasto/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin   env CC="gcc -m64" CFLAGS="-pipe -O2 -I/home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu/include -fPIC" RANLIB="ranlib" AR="ar"        ./configure --static --prefix=/home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu
touch /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a/./.stamp_configured
echo Building zlib...
mkdir -p /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a/.
cd /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a/.; PATH=/home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu/native/bin:/home/hebasto/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin   make libz.a
touch /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a/./.stamp_built
echo Staging zlib...
mkdir -p /home/hebasto/guix/GitHub/bitcoin/depends/work/staging/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a//home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu
cd /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a/.; PATH=/home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu/native/bin:/home/hebasto/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin   make DESTDIR=/home/hebasto/guix/GitHub/bitcoin/depends/work/staging/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a install
rm -rf /home/hebasto/guix/GitHub/bitcoin/depends/work/build/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a
touch /home/hebasto/guix/GitHub/bitcoin/depends/work/staging/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a/.stamp_staged
echo Postprocessing zlib...
cd /home/hebasto/guix/GitHub/bitcoin/depends/work/staging/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a/home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu; 
touch /home/hebasto/guix/GitHub/bitcoin/depends/work/staging/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a/home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu/.stamp_postprocessed
echo Caching zlib...
cd /home/hebasto/guix/GitHub/bitcoin/depends/work/staging/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a//home/hebasto/guix/GitHub/bitcoin/depends/x86_64-pc-linux-gnu; find . | sort | tar --no-recursion -czf /home/hebasto/guix/GitHub/bitcoin/depends/work/staging/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a/zlib-1.2.11-38eb814ef0a.tar.gz -T -
mkdir -p /home/hebasto/guix/GitHub/bitcoin/depends/built/x86_64-pc-linux-gnu/zlib
rm -rf /home/hebasto/guix/GitHub/bitcoin/depends/built/x86_64-pc-linux-gnu/zlib && mkdir -p /home/hebasto/guix/GitHub/bitcoin/depends/built/x86_64-pc-linux-gnu/zlib
mv /home/hebasto/guix/GitHub/bitcoin/depends/work/staging/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a/zlib-1.2.11-38eb814ef0a.tar.gz /home/hebasto/guix/GitHub/bitcoin/depends/built/x86_64-pc-linux-gnu/zlib/zlib-1.2.11-38eb814ef0a.tar.gz
rm -rf /home/hebasto/guix/GitHub/bitcoin/depends/work/staging/x86_64-pc-linux-gnu/zlib/1.2.11-38eb814ef0a
cd /home/hebasto/guix/GitHub/bitcoin/depends/built/x86_64-pc-linux-gnu/zlib; sha256sum zlib-1.2.11-38eb814ef0a.tar.gz > /home/hebasto/guix/GitHub/bitcoin/depends/built/x86_64-pc-linux-gnu/zlib/zlib-1.2.11-38eb814ef0a.tar.gz.hash
make: Leaving directory '/home/hebasto/guix/GitHub/bitcoin/depends'

fanquake added the label Build system on Sep 6, 2020

MarcoFalke added the label Needs gitian build on Sep 6, 2020

MarcoFalke added the label Needs Guix build on Sep 6, 2020

DrahtBot commented at 11:03 PM on September 7, 2020: member

Guix builds

File	commit 03689317021a72431762c1974530f2a980a7fffa<br>(master)	commit 6fe885f4192ae933e8b82e95c2ca3ac092fd221f<br>(master and this pull)
*-aarch64-linux-gnu-debug.tar.gz	`0565e9124a7e70d0...`	`d840d7fc073c2d08...`
*-aarch64-linux-gnu.tar.gz	`f55121157904f450...`	`8497ba989ab46b71...`
*-arm-linux-gnueabihf-debug.tar.gz	`c179f046ab1af496...`	`2e10f5d9648ab2f7...`
*-arm-linux-gnueabihf.tar.gz	`505a1f259e2e21e0...`	`1f6feec931e38aa2...`
*-riscv64-linux-gnu-debug.tar.gz	`deee8a0158ffd4de...`	`79cfcb399d55bf58...`
*-riscv64-linux-gnu.tar.gz	`1cebfa2cd81bf921...`	`6edc6b653bfb840e...`
*-win-unsigned.tar.gz	`3e1d834224b2d2f9...`	`8702888fb62f54f7...`
*-win64-debug.zip	`45db7e0d66bc374f...`	`0e409ec6186e2a0f...`
*-win64-setup-unsigned.exe	`f2f9fa7faa750005...`	`8829b5ad2257a129...`
*-win64.zip	`c4a55fdb09c332fa...`	`063600e3fa30cd4c...`
*-x86_64-linux-gnu-debug.tar.gz	`769a32a7a0cf7ad2...`	`a08500790ed1b342...`
*-x86_64-linux-gnu.tar.gz	`5aafa7f637ad9e26...`	`36ae30f257bbae5f...`
*.tar.gz	`28930600bb9eb969...`	`afbccedea88ae5dd...`
guix_build.log	`618e483294b1a544...`	`5eb6adf16de1d7bd...`
guix_build.log.diff		`25e01f9da8cb92e8...`

DrahtBot removed the label Needs Guix build on Sep 7, 2020

laanwj commented at 9:37 AM on September 8, 2020: member

I don't know enough about make syntax to review this but concept ACK, TIL that this is possible at all it seems useful for troubleshooting in some cases.

practicalswift commented at 1:41 PM on September 9, 2020: contributor

Concept ACK

DrahtBot commented at 4:31 PM on September 9, 2020: member

Gitian builds

File	commit 147d50d63e07f600b414273a9f6b84f9f4ad9696<br>(master)	commit f61ab8ee90e278e133c12c20219b331753e9bc05<br>(master and this pull)
*-osx-unsigned.dmg	`1d7d296708757cef...`	`3ba99f813f1147b2...`
*-osx64.tar.gz	`9e821c9b3e134d48...`	`c56407ef30bd0cae...`
*-win64-debug.zip	`04ac1747661a84dd...`	`fbcddc74c973274f...`
*-win64-setup-unsigned.exe	`d0ceda199ff6e367...`	`a6049ca5efea7242...`
*-win64.zip	`2c6c7a31de99aabf...`	`83c38bb733365fa7...`
*.tar.gz	`af3af29edf3b9091...`	`a2a09cd36cba425e...`
bitcoin-core-osx-0.21-res.yml	`98b77bce1f24258c...`	`c0949e2a5c11312f...`
bitcoin-core-win-0.21-res.yml	`f773a050bab67b57...`	`784470b64b7b7692...`
osx-build.log	`7d70efc9433568e4...`	`ce4050f0ae264e61...`
win-build.log	`94c38d7f7e948bef...`	`356af361a6aaf3e1...`
bitcoin-core-linux-0.21-res.yml		`96921ad1410d4693...`
bitcoin-core-osx-0.21-res.yml.diff		`a3c0f72bfa77c355...`
bitcoin-core-win-0.21-res.yml.diff		`c31328189b5eb694...`
*-aarch64-linux-gnu-debug.tar.gz		`588d27942b27250f...`
*-aarch64-linux-gnu.tar.gz		`c11c50ee01ede991...`
*-arm-linux-gnueabihf-debug.tar.gz		`4e164dfa917eefb4...`
*-arm-linux-gnueabihf.tar.gz		`d7b8e68649bf1839...`
*-riscv64-linux-gnu-debug.tar.gz		`91beb0488c1fbd51...`
*-riscv64-linux-gnu.tar.gz		`bd311d36c25a43e6...`
*-x86_64-linux-gnu-debug.tar.gz		`b6795e15e2b9eff3...`
*-x86_64-linux-gnu.tar.gz		`2196b2c2e4912b55...`
linux-build.log		`f3e110dede240853...`
osx-build.log.diff		`84aaee9aa4e4edfb...`
win-build.log.diff		`7e66d90629ce5ffb...`

DrahtBot removed the label Needs gitian build on Sep 9, 2020

MarcoFalke added the label Needs gitian build on Sep 9, 2020

depends: Fix `make --just-print` command 85e2b50888

in depends/funcs.mk:197 in ce3dc08ce1 outdated

 193 | @@ -194,13 +194,13 @@ $($(1)_preprocessed): | $($(1)_extracted)
 194 |  $($(1)_configured): | $($(1)_dependencies) $($(1)_preprocessed)
 195 |  	$(AT)echo Configuring $(1)...
 196 |  	$(AT)rm -rf $(host_prefix); mkdir -p $(host_prefix)/lib; cd $(host_prefix); $(foreach package,$($(1)_all_dependencies), tar --no-same-owner -xf $($(package)_cached); )
 197 | -	$(AT)mkdir -p $$(@D)
 198 | -	$(AT)+cd $$(@D); $($(1)_config_env) $(call $(1)_config_cmds, $(1))
 199 | +	$(AT)+mkdir -p $$(@D)

unknown commented at 10:41 PM on September 10, 2020:

This seems to be the only + left after your suggested changes (which look good to me, fixing cding into directories that have not been created). Wouldn't it be possible/better to drop this last +, too? Or is there a reasoning why this line has to be prefixed with a +, creating a folder?

To be honest: I've not run make to test it out and I'm new to the code base, so just asking.

hebasto commented at 6:53 AM on September 11, 2020:

@madietlx

Or is there a reasoning why this line has to be prefixed with a +, creating a folder?

Not-creating that folder causes an error when one runs make --dry-run. The + forces make to execute a line even in --dry-run mode.

unknown commented at 10:19 AM on September 11, 2020:

Not-creating that folder causes an error when one runs make --dry-run. The + forces make to execute a line even in --dry-run mode. @hebasto And that error would still occur - even though you did remove the + in front of the following cd line which caused the error in the first place?

hebasto commented at 10:59 AM on September 11, 2020:

Thanks. Updated.

hebasto force-pushed on Sep 11, 2020

hebasto commented at 10:59 AM on September 11, 2020: member

Updated ce3dc08ce1c9f5a977eea2d20a9cc3e352cd75bd -> 85e2b50888a598fccd771db1e5726159af147ff8 (pr19891.01 -> pr19891.02, diff):

dropped unneeded change

unknown approved

unknown commented at 1:54 PM on September 11, 2020: none

Code Review ACK 85e2b50888a598fccd771db1e5726159af147ff8

I've not run make to test the changes, but the code looks good to me.

hebasto marked this as a draft on Sep 11, 2020

hebasto commented at 5:12 PM on September 11, 2020: member

Closing as this is a wrong approach due to https://www.gnu.org/software/make/manual/html_node/MAKE-Variable.html#MAKE-Variable

hebasto closed this on Sep 11, 2020

DrahtBot commented at 7:17 PM on September 11, 2020: member

Gitian builds

File	commit 564e1ab0f3dc573bd3ea60a80f6649c361243df9<br>(master)	commit 6058386d7c51d48a3334168b412413dbbff4567e<br>(master and this pull)
*-aarch64-linux-gnu-debug.tar.gz	`1c2a2879aff10050...`	`d2f12424bcadd9d2...`
*-aarch64-linux-gnu.tar.gz	`8263bd68197c690a...`	`bd4249b27cf5248c...`
*-arm-linux-gnueabihf-debug.tar.gz	`8e4006209f34d307...`	`514995c04450e42f...`
*-arm-linux-gnueabihf.tar.gz	`5c6b4eeae96cbdf5...`	`d2d2bef7902b7b72...`
*-osx-unsigned.dmg	`706f4c304d69fbaf...`	`0da4e622dc45681b...`
*-osx64.tar.gz	`8d8f17681d009f87...`	`0f2c664c707ce503...`
*-riscv64-linux-gnu-debug.tar.gz	`c641ebb8299ea759...`	`d4a9a5ba90b0b0e3...`
*-riscv64-linux-gnu.tar.gz	`44cd59e7f8a6e22c...`	`7b2af39987be06ab...`
*-win64-debug.zip	`814e2cabe80bf5c6...`	`61df0371454677cb...`
*-win64-setup-unsigned.exe	`b707c53c178fa6f8...`	`4c24ef66df874dca...`
*-win64.zip	`6a987afaebc0f819...`	`77db29a0ee97e707...`
*-x86_64-linux-gnu-debug.tar.gz	`c2d88d24933aa767...`	`ac240921da90333f...`
*-x86_64-linux-gnu.tar.gz	`475eb02def77f698...`	`6ad9eda48f775f14...`
*.tar.gz	`7962eade9c35ee6d...`	`67d66619b4a91e84...`
bitcoin-core-linux-0.21-res.yml	`415da1b615c1b005...`	`accfb5b5adf4f208...`
bitcoin-core-osx-0.21-res.yml	`13ecc6ad5763ceb8...`	`38d55b89c7e72873...`
bitcoin-core-win-0.21-res.yml	`c9609ff38f5b4905...`	`95892b1c687e3539...`
linux-build.log	`b6cbf93873089e39...`	`1651b4ab1787e60b...`
osx-build.log	`bd5b90656229ce8c...`	`f835b037ada76fef...`
win-build.log	`8aed8b2efff10101...`	`25f65c8901869251...`
bitcoin-core-linux-0.21-res.yml.diff		`fa83a0b3d1193d4c...`
bitcoin-core-osx-0.21-res.yml.diff		`e89b074e294458dd...`
bitcoin-core-win-0.21-res.yml.diff		`5f6154ac9abffae3...`
linux-build.log.diff		`f28d72017e32ec37...`
osx-build.log.diff		`d07eaa22ea5c3650...`
win-build.log.diff		`0e40be91572276c1...`

DrahtBot removed the label Needs gitian build on Sep 11, 2020

ghost commented at 4:37 AM on September 12, 2020: none

Closing as this is a wrong approach due to https://www.gnu.org/software/make/manual/html_node/MAKE-Variable.html#MAKE-Variable

Could you explain why you think that your approach is wrong?

hebasto commented at 9:18 AM on September 12, 2020: member

Could you explain why you think that your approach is wrong?

It prevents passing -j to sub-makes.

ghost commented at 11:16 PM on September 12, 2020: none

It prevents passing -j to sub-makes. @hebasto I have to admit that I did not see this coming. I definitely need to set up a local dev environment to test those things out.

Thanks for your quick responses to my questions!

hebasto deleted the branch on Sep 24, 2020

DrahtBot locked this on Feb 15, 2022