build: allow user to specify DIR_FUZZ_SEED_CORPUS for cov_fuzz #19916

pull Crypt-iQ wants to merge 2 commits into bitcoin:master from Crypt-iQ:cov_fuzz_cleanup_0908 changing 2 files +4 −1

Crypt-iQ commented at 8:36 AM on September 8, 2020: contributor
This PR contains two commits:
- The cov_fuzz target now uses DIR_FUZZ_SEED_CORPUS as the seed directory instead of the hard-coded qa-assets/fuzz_seed_corpus. Otherwise, running it requires me to copy the corpus to the bitcoin directory first. In case DIR_FUZZ_SEED_CORPUS is not specified, the original default is used.
- add qa-assets folder to gitignore
Example usage: make cov_fuzz DIR_FUZZ_SEED_CORPUS=~/workspace/qa-assets/fuzz_seed_corpus

It can also just be an environment variable.

build: use DIR_FUZZ_SEED_CORPUS if specified for cov_fuzz target

This commit allows the user to specify the location of the
fuzz_seed_corpus directory on their machine when running the cov_fuzz
target. If DIR_FUZZ_SEED_CORPUS is specified, then this will be used.
Otherwise, qa-assets/fuzz_seed_corpus is assumed to be in the bitcoin
directory.

a9f201439a

.gitignore: ignore qa-assets/ folder

This commit ignores the qa-assets/ folder in case a user is running
the cov_fuzz target without DIR_FUZZ_SEED_CORPUS set. In this case,
the qa-assets folder is assumed to live in the bitcoin directory and
should be ignored by git.

fb3bacce69

Crypt-iQ renamed this:
~~build: allow user to specify DIR_FUZZ_SEED_CORPUS when invoking cov_fuzz target~~
build: allow user to specify DIR_FUZZ_SEED_CORPUS for cov_fuzz
on Sep 8, 2020
DrahtBot added the label Build system on Sep 8, 2020
practicalswift commented at 7:26 PM on September 9, 2020: contributor

Concept ACK

Thanks for improving the fuzzing experience!
fanquake approved
fanquake commented at 5:58 AM on September 11, 2020: member

ACK fb3bacce69a39bf86288ece239c1be63518e11fb - looks fine.
practicalswift commented at 6:02 AM on September 11, 2020: contributor

ACK fb3bacce69a39bf86288ece239c1be63518e11fb - patch looks correct
fanquake merged this on Sep 11, 2020
fanquake closed this on Sep 11, 2020
Crypt-iQ deleted the branch on Sep 11, 2020
sidhujag referenced this in commit e79e6c711f on Sep 11, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels