fuzz: Configure check for main function #20065

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2010-fuzzMainConfig changing 2 files +14 −9

MarcoFalke commented at 9:04 AM on October 3, 2020: member

Instead of the PP jungle, use a proper configure check

Fixes https://github.com/google/honggfuzz/issues/336#issuecomment-702972138
in configure.ac:1184 in fab4827da2 outdated
```
1179 | +    [],
1180 | +    [AC_LANG_PROGRAM([[
1181 | +    #include <cstdint>
1182 | +    #include <cstddef>
1183 | +    extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { return 0; }
1184 | +    /* no main function ...
```
practicalswift commented at 9:37 AM on October 3, 2020:

/* not terminated? :)

MarcoFalke commented at 9:46 AM on October 3, 2020:

Yes

practicalswift commented at 3:09 PM on October 4, 2020:

From a reviewer perspective it looks odd that /* isn't terminated. Please add a comment if it is intentional :)

MarcoFalke commented at 3:51 PM on October 4, 2020:

Thx. Made the comment longer
practicalswift commented at 9:45 AM on October 3, 2020: contributor

Concept ACK

Thanks for fixing this!
DrahtBot added the label Build system on Oct 3, 2020
fuzz: Configure check for main function fae7a1c188
MarcoFalke force-pushed on Oct 4, 2020
practicalswift commented at 7:22 PM on October 4, 2020: contributor

ACK fae7a1c18803675e70b9bf66575e1e0a6e01f6f6
MarcoFalke merged this on Oct 8, 2020
MarcoFalke closed this on Oct 8, 2020
MarcoFalke deleted the branch on Oct 8, 2020
sidhujag referenced this in commit b9e6f192d0 on Oct 8, 2020
MarcoFalke referenced this in commit 01d2cf2674 on Feb 5, 2021
sidhujag referenced this in commit 961bb9e095 on Feb 5, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

MarcoFalke

practicalswift

Labels

Build system

Linked (view graph)

#21080 fuzz: Configure check for main function (take 2)