fuzz: Configure check for main function (take 2) #21080

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2101-fuzzTake2 changing 1 files +4 −2
  1. MarcoFalke commented at 12:14 PM on February 4, 2021: member

    Actually fix https://github.com/google/honggfuzz/issues/336#issuecomment-702972138

    Follow-up to #20065

    Steps to test: honggfuzz section in doc/fuzzing.md

  2. fuzz: Configure check for main function (take 2) fac4be3048
  3. MarcoFalke commented at 12:25 PM on February 4, 2021: member

    On master:

    • Incorrectly compiles with -DPROVIDE_MAIN_FUNCTION
    • Thus, the persistent fuzz config fails:
    # FUZZ=process_message_version  ./honggfuzz/honggfuzz -i ./qa-assets/fuzz_seed_corpus/process_message_version -- ./src/test/fuzz/fuzz 
    [2021-02-04T13:19:41+0100][E][72620] cmdlineVerify():242 You must specify '___FILE___' if the -s (stdin fuzzing) or --persistent options are not set
    [2021-02-04T13:19:41+0100][F][72620] main():325 Parsing of the cmd-line arguments failed
    

    It is only possible to run the extremely slow -s (stdin) fuzz config:

    # FUZZ=process_message_version  ./honggfuzz/honggfuzz -s -i ./qa-assets/fuzz_seed_corpus/process_message_version -- ./src/test/fuzz/fuzz
    ...
           Speed : 0/sec [avg: 13]
    ...
    

    On this pull:

    # FUZZ=process_message_version  ./honggfuzz/honggfuzz -i ./qa-assets/fuzz_seed_corpus/process_message_version -- ./src/test/fuzz/fuzz
    ...
           Speed : 13,184/sec [avg: 12,328]
    ...
    
  4. fanquake added the label Build system on Feb 4, 2021
  5. DrahtBot commented at 8:49 PM on February 4, 2021: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #20936 (build: build fuzz tests by default by danben)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  6. practicalswift commented at 9:04 AM on February 5, 2021: contributor

    cr ACK fac4be30482c21ac330e09ef8756c49e37faa6fa: patch looks correct!

    Thanks for fixing.

  7. MarcoFalke merged this on Feb 5, 2021
  8. MarcoFalke closed this on Feb 5, 2021

  9. MarcoFalke deleted the branch on Feb 5, 2021
  10. sidhujag referenced this in commit 961bb9e095 on Feb 5, 2021
  11. PastaPastaPasta referenced this in commit 6aad5ec0a4 on Apr 3, 2022
  12. PastaPastaPasta referenced this in commit 31a0d2f8f4 on Apr 4, 2022
  13. PastaPastaPasta referenced this in commit 353dc403f5 on Apr 6, 2022
  14. DrahtBot locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-16 21:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me