[0.20] build: set minimum required Boost to 1.48.0 #20142

pull fanquake wants to merge 1 commits into bitcoin:0.20 from fanquake:min_boost_actually_1480 changing 2 files +2 −2
  1. fanquake commented at 5:06 am on October 13, 2020: member

    Due to the use of boost::filesystem::canonical(), the minimum required version of Boost is actually 1.48.0. Use of canonical was introduced in #14146.

    See also Boost filesystem 1.48.0 release notes. Also discussed in #20080.

  2. build: set minimum required Boost to 1.48.0
    Due to the use of boost::filesystem::canonical(), the minimum required
    version of Boost is actually 1.48.0. Use of canonical was introduced
    in #14146.
    
    See also Boost filesystem 1.48.0 release notes:
    https://github.com/boostorg/filesystem/blob/6b5e38134a336b6ea777cd8a69b6ae929819db7e/doc/release_history.html#L508
    3562c15be3
  3. hebasto approved
  4. hebasto commented at 5:55 am on October 13, 2020: member

    ACK 3562c15be3dbf725197d719d58c8d78e2f2c6779, this is the status quo.

    Are we going to update 0.19 branch as well?

  5. DrahtBot added the label Backport on Oct 13, 2020
  6. fanquake removed the label Backport on Oct 13, 2020
  7. MarcoFalke commented at 7:12 am on October 13, 2020: member
    ACK, but I doubt anyone is affected by this practically or even reads the docs
  8. MarcoFalke added the label Build system on Oct 13, 2020
  9. practicalswift commented at 9:28 am on October 13, 2020: contributor
    ACK 3562c15be3dbf725197d719d58c8d78e2f2c6779: correct is better than incorrect :)
  10. Saibato commented at 9:31 am on October 13, 2020: contributor

    @MarcoFalke

    or even reads the docs

    I have, does that count? And is there a “u get extra points if u find the diff between reality and believe, in our adventure tale source and stars if u find out that all is a sophisticated foo”, bonus program?

  11. fanquake commented at 12:01 pm on October 13, 2020: member

    Are we going to update 0.19 branch as well?

    I’ll pull this change in when I do some other 0.19 backports.

  12. MarcoFalke merged this on Oct 13, 2020
  13. MarcoFalke closed this on Oct 13, 2020

  14. fanquake deleted the branch on Oct 13, 2020
  15. fanquake referenced this in commit 39cc842f1f on Oct 14, 2020
  16. fanquake referenced this in commit 71a9475957 on Oct 15, 2020
  17. fanquake referenced this in commit 6957419a28 on Oct 16, 2020
  18. MarcoFalke referenced this in commit 5baaea4410 on Dec 2, 2020
  19. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-04 22:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me