test: Fix -Wunused-function warnings if configured --without-libs #20180

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:201018-unused changing 1 files +30 −30

hebasto commented at 4:10 PM on October 18, 2020: member

On master (80c8a02f1b4f6ad2b5c02595d66a74db22373ed4) compiling with gcc:

$ ./configure --without-libs
$ make clean && make
...
test/script_tests.cpp:1369:23: warning: ‘CScriptWitness script_tests::ScriptWitnessFromJSON(const UniValue&)’ defined but not used [-Wunused-function]
 1369 | static CScriptWitness ScriptWitnessFromJSON(const UniValue& univalue)
      |                       ^~~~~~~~~~~~~~~~~~~~~
test/script_tests.cpp:1357:28: warning: ‘std::vector<CTxOut> script_tests::TxOutsFromJSON(const UniValue&)’ defined but not used [-Wunused-function]
 1357 | static std::vector<CTxOut> TxOutsFromJSON(const UniValue& univalue)
      |                            ^~~~~~~~~~~~~~
test/script_tests.cpp:1350:28: warning: ‘CMutableTransaction script_tests::TxFromHex(const string&)’ defined but not used [-Wunused-function]
 1350 | static CMutableTransaction TxFromHex(const std::string& str)
      |                            ^~~~~~~~~
...

This change is move-only (nice to review with git diff --color-moved).

test: Fix -Wunused-function warning if configured --without-libs
This is a move-only change.
76bbcc414f
DrahtBot added the label Tests on Oct 18, 2020
hebasto renamed this:
~~test: Fix -Wunused-function warning if configured --without-libs~~
test: Fix -Wunused-function warnings if configured --without-libs
on Oct 18, 2020
hebasto commented at 6:01 PM on October 18, 2020: member

This regression was introduced in 4567ba034c5ae6e6cc161360f7425c9e844738f0 (#19953).
practicalswift commented at 9:03 PM on October 18, 2020: contributor

ACK 76bbcc414f3001b16ac0101f738ed0b3e6f1a372: diff looks correct
fanquake approved
fanquake commented at 4:00 AM on October 19, 2020: member

ACK 76bbcc414f3001b16ac0101f738ed0b3e6f1a372 - verified that this fixes the warnings. As mentioned can be reviewed with git diff HEAD~ --color-moved=dimmed_zebra.
MarcoFalke merged this on Oct 19, 2020
MarcoFalke closed this on Oct 19, 2020
hebasto deleted the branch on Oct 19, 2020
sidhujag referenced this in commit 43ff41f050 on Oct 19, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels