doc: rename CODEOWNERS to REVIEWERS #20200

pull adamjonas wants to merge 1 commits into bitcoin:master from adamjonas:102020-fix-codeowners changing 1 files +9 −14
  1. adamjonas commented at 4:26 PM on October 20, 2020: member

    This PR renames the CODEOWNERS file to REVIEWERS and works with DrahtBot to leave a comment requesting a review.

    Testing of the functionality was done on https://github.com/adamjonas/bitcoin-codeowners-sandbox/pulls.

    ~EDIT: after further testing of a fake organization, it appears that in order to be automatically tagged, the reviewer requires write level permissions. This is undocumented and will obviously close the circle of who can be tagged and so this PR reverts the addition of the file in #18949.~

    ~This removes a line not being parsed in the CODEOWNERS file introduced in #18949. While the pattern checked out using git ls-files, it is preventing the CODEOWNERS file from automatically tagging reviewers. For future modifications to this file, note that any line failing to parse causes the entire file to stop identifying codeowners.~

    ~I experimented in a sandbox repo to discover the offending line and this change appears to fix the problem.~

  2. DrahtBot added the label Docs on Oct 20, 2020
  3. adamjonas marked this as a draft on Oct 20, 2020
  4. jnewbery commented at 8:12 AM on October 22, 2020: member

    The people you choose as code owners must have write permissions for the repository.

    https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/about-code-owners

  5. adamjonas force-pushed on Oct 22, 2020
  6. adamjonas renamed this:
    doc: Remove breaking line of CODEOWNERS file
    doc: revert #18949 since CODEOWNERS require write permission
    on Oct 22, 2020
  7. adamjonas commented at 5:11 PM on October 22, 2020: member

    @fanquake offered to ask GitHub if they would remove the requirement. Alternatively, this functionality could be added to DrahtBot, which I can explore next.

  8. fanquake commented at 7:05 AM on October 23, 2020: member

    @fanquake offered to ask GitHub if they would remove the requirement.

    I've followed up in the maintainers group about this.

  9. fanquake commented at 2:15 PM on October 27, 2020: member

    ACK cfa08ffb069594f010c76986f6d31563be559e50 - It's been 4 days, and there's been no reply from GitHub, so happy for this to be removed if that's what we want to do.

  10. practicalswift commented at 7:09 AM on October 28, 2020: contributor

    ACK cfa08ffb069594f010c76986f6d31563be559e50: the number of people with write permission should be kept to a minimum which in turn makes CODEOWNERS as currently designed unusable.

  11. adamjonas commented at 3:08 PM on October 28, 2020: member

    In that case, I'd like to rename this file to REVIEWERS and attempt to add some comment tagging to DrahtBot to simulate this functionality. I'll circle back when I have more progress on that.

  12. DrahtBot commented at 7:45 PM on November 1, 2020: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

  13. adamjonas commented at 7:34 PM on November 3, 2020: member

    I wrote a script for DrahtBot that parses a REVIEWERS file and leaves a comment requesting a review. Testing for this was done on https://github.com/adamjonas/bitcoin-codeowners-sandbox/pulls and I've sent the script to @MarcoFalke for review.

    If that checks out, I'll update this PR to rename the CODEOWNERS file to REVIEWERS and add the appropriate documentation and instructions.

  14. MarcoFalke commented at 9:09 AM on November 30, 2020: member

    This is what the script does (approximately):

  15. adamjonas force-pushed on Nov 30, 2020
  16. adamjonas renamed this:
    doc: revert #18949 since CODEOWNERS require write permission
    doc: rename CODEOWNERS to REVIEWERS
    on Nov 30, 2020
  17. in REVIEWERS:8 in 6b2bfb5803 outdated 
       9 | +# via DrahtBot.
  10 |  
  11 | -# Order is important; the last matching pattern takes the most precedence.
  12 | -# More info on how this file works can be found at:
  13 | -# https://help.github.com/articles/about-codeowners/
  14 | +# Order is not important; if a modified file or directory matches a regex,
    MarcoFalke commented at 6:17 PM on November 30, 2020:

    fnmatch is not regex

    adamjonas commented at 6:54 PM on November 30, 2020:

    updated

  18. doc: rename CODEOWNERS to REVIEWERS
    This reverts #18949 since CODEOWNERS require write permission.
Instead the REVIEWERS file uses DrahtBot to tag reviewers in PR
comments.
    86e6add5ca
  19. adamjonas force-pushed on Nov 30, 2020
  20. adamjonas marked this as ready for review on Dec 1, 2020
  21. laanwj commented at 9:35 AM on December 4, 2020: member

    Doesn't look like github is going to fix this any time soon and besides REVIEWERS is a better name so ACK 86e6add5ca7d425faa314103df6617044a910ab3

  22. laanwj merged this on Dec 4, 2020
  23. laanwj closed this on Dec 4, 2020
  24. sidhujag referenced this in commit 9a14b02330 on Dec 4, 2020
  25. PastaPastaPasta referenced this in commit 05341c8ca2 on Jun 27, 2021
  26. PastaPastaPasta referenced this in commit a9840c1343 on Jun 28, 2021
  27. PastaPastaPasta referenced this in commit 771514fc49 on Jun 29, 2021
  28. PastaPastaPasta referenced this in commit c81497ab2d on Jul 1, 2021
  29. PastaPastaPasta referenced this in commit 8656b10b23 on Jul 1, 2021
  30. DrahtBot locked this on Feb 15, 2022
Contributors
adamjonasjnewberyfanquakepracticalswiftDrahtBotMarcoFalkelaanwj
Labels
Docs
Linked (view graph)
#18949 doc: Add CODEOWNERS file to automatically nominate PR reviewers
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 21:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me