doc: CI system link added, clarity increased #20215

pull sushant-varanasi wants to merge 3 commits into bitcoin:master from sushant-varanasi:patch-1 changing 1 files +2 −2

sushant-varanasi commented at 8:05 PM on October 21, 2020: none

No description provided.
Travis CI system link added for clarity (https://travis-ci.org/) 1a520fc8db

in README.md:56 in 1a520fc8db outdated

  55 | @@ -56,7 +56,7 @@ There are also [regression and integration tests](/test), written
  56 |  in Python, that are run automatically on the build server.

MarcoFalke commented at 8:17 PM on October 21, 2020:

in Python.

sushant-varanasi commented at 8:32 PM on October 21, 2020:

commit done

in README.md:59 in 1a520fc8db outdated

  55 | @@ -56,7 +56,7 @@ There are also [regression and integration tests](/test), written
  56 |  in Python, that are run automatically on the build server.
  57 |  These tests can be run (if the [test dependencies](/test) are installed) with: `test/functional/test_runner.py`
  58 |  
  59 | -The Travis CI system makes sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.
  60 | +The [Travis CI system](https://travis-ci.org/) makes sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.

MarcoFalke commented at 8:20 PM on October 21, 2020:

The [CI system](/ci) defines build configs for Windows, Linux, and macOS, unit/sanity tests are part of the CI configs.

sushant-varanasi commented at 8:32 PM on October 21, 2020:

commit done

MarcoFalke commented at 8:22 PM on October 21, 2020: member

We've switched to our own ci system with config files. They can be executed on any machine. Currently we use Appveyor, Cirrus and Travis for build resources, but I don't think it is worth listing all of them in the top-level readme.

I suggest to strip down the verbosity a bit.

Update README.md

Co-authored-by: MarcoFalke <falkemarco@gmail.com>

c6bfa028e9

Update README.md - CI system related

Co-authored-by: MarcoFalke <falkemarco@gmail.com>

81b69b0577

sushant-varanasi renamed this:
~~Travis CI system link (https://travis-ci.org/) added for clarity~~
CI system link added, clarity increased
on Oct 21, 2020
DrahtBot added the label Docs on Oct 21, 2020
sushant-varanasi commented at 6:14 AM on October 22, 2020: none

@MarcoFalke @practicalswift could you merge this pr now.
practicalswift commented at 6:19 AM on October 22, 2020: contributor

@sushant-varanasi Please squash :)
MarcoFalke commented at 7:31 AM on October 22, 2020: member

could you merge this pr now

This is not how contributing works here. Please refer to our docs
sushant-varanasi commented at 7:58 AM on October 22, 2020: none

"If you have problems with squashing or other git workflows, you can enable "Allow edits from maintainers" in the right-hand sidebar of the GitHub web interface and ask for help in the pull request." - (Sentence in the contribution docs) @practicalswift I think u can "squash and merge" as I have allowed edits by maintainers.
sushant-varanasi renamed this:
~~CI system link added, clarity increased~~
doc: CI system link added, clarity increased
on Oct 22, 2020
fanquake commented at 11:48 PM on October 22, 2020: member

In future, don't open multiple PRs (#20224) for the same change. If you'd like to contribute to this project you'll need to learn how to use git. That includes how to squash, rebase, edit commits messages etc.
fanquake closed this on Oct 22, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels