fuzz: Properly initialize PrecomputedTransactionData #20242

1. 
   MarcoFalke commented at 8:38 AM on October 26, 2020: member

   Fixes:

   script_flags: script/interpreter.cpp:1512: bool SignatureHashSchnorr(uint256 &, const ScriptExecutionData &, const T &, uint32_t, uint8_t, SigVersion, const PrecomputedTransactionData &) [T = CTransaction]: Assertion `cache.m_bip341_taproot_ready && cache.m_spent_outputs_ready' failed.
   ==34989== ERROR: libFuzzer: deadly signal
       [#0](/bitcoin-bitcoin/0/) 0x55e90077ff11 in __sanitizer_print_stack_trace (/tmp/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/script_flags+0x20cf11)
       [#1](/bitcoin-bitcoin/1/) 0x55e9006cb068 in fuzzer::PrintStackTrace() (/tmp/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/script_flags+0x158068)
       [#2](/bitcoin-bitcoin/2/) 0x55e9006b01b3 in fuzzer::Fuzzer::CrashCallback() (/tmp/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/script_flags+0x13d1b3)
       [#3](/bitcoin-bitcoin/3/) 0x7f6fb89383bf  (/lib/x86_64-linux-gnu/libpthread.so.0+0x153bf)
       [#4](/bitcoin-bitcoin/4/) 0x7f6fb855018a in raise (/lib/x86_64-linux-gnu/libc.so.6+0x4618a)
       [#5](/bitcoin-bitcoin/5/) 0x7f6fb852f858 in abort (/lib/x86_64-linux-gnu/libc.so.6+0x25858)
       [#6](/bitcoin-bitcoin/6/) 0x7f6fb852f728  (/lib/x86_64-linux-gnu/libc.so.6+0x25728)
       [#7](/bitcoin-bitcoin/7/) 0x7f6fb8540f35 in __assert_fail (/lib/x86_64-linux-gnu/libc.so.6+0x36f35)
       [#8](/bitcoin-bitcoin/8/) 0x55e9008275bd in bool SignatureHashSchnorr<CTransaction>(uint256&, ScriptExecutionData const&, CTransaction const&, unsigned int, unsigned char, SigVersion, PrecomputedTransactionData const&) /tmp/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/script/interpreter.cpp:1512:5
       [#9](/bitcoin-bitcoin/9/) 0x55e900825a3f in GenericTransactionSignatureChecker<CTransaction>::CheckSchnorrSignature(Span<unsigned char const>, Span<unsigned char const>, SigVersion, ScriptExecutionData const&, ScriptError_t*) const /tmp/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/script/interpreter.cpp:1699:10
       [#10](/bitcoin-bitcoin/10/) 0x55e900832503 in VerifyWitnessProgram(CScriptWitness const&, int, std::vector<unsigned char, std::allocator<unsigned char> > const&, unsigned int, BaseSignatureChecker const&, ScriptError_t*, bool) /tmp/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/script/interpreter.cpp:1900:26
       [#11](/bitcoin-bitcoin/11/) 0x55e90082ecb5 in VerifyScript(CScript const&, CScript const&, CScriptWitness const*, unsigned int, BaseSignatureChecker const&, ScriptError_t*) /tmp/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/script/interpreter.cpp:1977:18
       [#12](/bitcoin-bitcoin/12/) 0x55e9007a9b61 in test_one_input(std::vector<unsigned char, std::allocator<unsigned char> > const&) /tmp/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/script_flags.cpp:51:30
       [#13](/bitcoin-bitcoin/13/) 0x55e9007d0b49 in LLVMFuzzerTestOneInput /tmp/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz.cpp:36:5
       [#14](/bitcoin-bitcoin/14/) 0x55e9006b1871 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) (/tmp/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/script_flags+0x13e871)
       [#15](/bitcoin-bitcoin/15/) 0x55e9006b0fb5 in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long, bool, fuzzer::InputInfo*, bool*) (/tmp/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/script_flags+0x13dfb5)
       [#16](/bitcoin-bitcoin/16/) 0x55e9006b38d7 in fuzzer::Fuzzer::ReadAndExecuteSeedCorpora(std::__Fuzzer::vector<fuzzer::SizedFile, fuzzer::fuzzer_allocator<fuzzer::SizedFile> >&) (/tmp/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/script_flags+0x1408d7)
       [#17](/bitcoin-bitcoin/17/) 0x55e9006b3c39 in fuzzer::Fuzzer::Loop(std::__Fuzzer::vector<fuzzer::SizedFile, fuzzer::fuzzer_allocator<fuzzer::SizedFile> >&) (/tmp/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/script_flags+0x140c39)
       [#18](/bitcoin-bitcoin/18/) 0x55e9006a290e in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) (/tmp/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/script_flags+0x12f90e)
       [#19](/bitcoin-bitcoin/19/) 0x55e9006cb752 in main (/tmp/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/script_flags+0x158752)
       [#20](/bitcoin-bitcoin/20/) 0x7f6fb85310b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
       [#21](/bitcoin-bitcoin/21/) 0x55e9006776ad in _start (/tmp/bitcoin-core/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/script_flags+0x1046ad)
   

2. fuzz: Properly initialize PrecomputedTransactionData fa56d56d4e
3. 
   MarcoFalke commented at 8:39 AM on October 26, 2020: member

   Link to crash: https://cirrus-ci.com/task/5355130436452352?command=ci#L3963

4. DrahtBot added the label Tests on Oct 26, 2020
5. MarcoFalke added this to the milestone 0.21.0 on Oct 28, 2020
6. 
   laanwj commented at 10:50 AM on October 29, 2020: member

   Code review ACK fa56d56d4e9b69fdd02e631b9a2380cfd3095144

7. laanwj merged this on Oct 29, 2020
8. laanwj closed this on Oct 29, 2020

   ---

9. MarcoFalke deleted the branch on Oct 29, 2020
10. sidhujag referenced this in commit 69877a92ab on Oct 29, 2020
11. PastaPastaPasta referenced this in commit 1e60a10f08 on Sep 17, 2021
12. PastaPastaPasta referenced this in commit c393bb74ab on Sep 19, 2021
13. PastaPastaPasta referenced this in commit 5041bb7a17 on Sep 21, 2021
14. PastaPastaPasta referenced this in commit b04842974d on Sep 24, 2021
15. kittywhiskers referenced this in commit 06a96b195e on Oct 12, 2021
16. DrahtBot locked this on Feb 15, 2022

Milestone
0.21.0