tests: Skip –descriptor tests if sqlite is not compiled #20262

1. 
   achow101 commented at 4:36 pm on October 29, 2020: member

   #20156 allows sqlite to not be compiled by configuring --without-sqlite. However doing so and then running the test runner will result in all of the --descriptor tests to fail. We should be skipping those tests if sqlite was not compiled.
2. Skip --descriptor tests if sqlite is not compiled 586640381a
3. 
   michaelfolkson commented at 5:01 pm on October 29, 2020: contributor

   Concept ACK

   Getting test failures on another PR because of this (I think)

4. MarcoFalke added this to the milestone 0.21.0 on Oct 29, 2020
5. DrahtBot added the label Build system on Oct 29, 2020
6. 
   michaelfolkson commented at 6:55 pm on October 29, 2020: contributor

   This PR successfully skips the --descriptor tests on MacOS Catalina.

   I’m still getting failures on feature_pruning.py, interface_rpc.py, p2p_addrv2_relay.py but not related to this PR I don’t think.

7. Ensure a legacy wallet for BDB format check 7411876c75
8. 
   practicalswift commented at 7:46 pm on October 29, 2020: contributor

   ACK 7411876c75471a45ad40c38c668db3a4b9413fb9: patch looks correct
9. ryanofsky approved
10. 
    ryanofsky commented at 7:50 pm on October 29, 2020: member

    Code review ACK 7411876c75471a45ad40c38c668db3a4b9413fb9
11. in test/functional/wallet_descriptor.py:23 in 7411876c75

    15@@ -16,18 +16,22 @@ def set_test_params(self):
    16         self.setup_clean_chain = True
    17         self.num_nodes = 1
    18         self.extra_args = [['-keypool=100']]
    19+        self.wallet_names = []
    20 
    21     def skip_test_if_missing_module(self):
    22         self.skip_if_no_wallet()
    23+        self.skip_if_no_sqlite()
    

    ---

    ---

    

    mjdietzx commented at 9:15 pm on October 29, 2020:

    Is it necessary to call self.skip_if_no_sqlite() explicitly here, since it is already called in skip_if_no_wallet(self) if --descriptors is set (and looking at the additions to test_runner.py this seems to now be the case)?

    ---

    

    achow101 commented at 9:39 pm on October 29, 2020:

    It’s being done for people who just run it on the command line without --descriptor. This test always needs this check.
12. in test/functional/wallet_importdescriptors.py:40 in 7411876c75

    36@@ -37,6 +37,7 @@ def set_test_params(self):
    37 
    38     def skip_test_if_missing_module(self):
    39         self.skip_if_no_wallet()
    40+        self.skip_if_no_sqlite()
    

    ---

    ---

    

    mjdietzx commented at 9:18 pm on October 29, 2020:

    same as my comment in wallet_descriptor.py
13. in test/functional/wallet_descriptor.py:19 in 7411876c75

    15@@ -16,18 +16,22 @@ def set_test_params(self):
    16         self.setup_clean_chain = True
    17         self.num_nodes = 1
    18         self.extra_args = [['-keypool=100']]
    19+        self.wallet_names = []
    

    ---

    ---

    

    mjdietzx commented at 9:32 pm on October 29, 2020:

    Why did this need to be added? I’m not seeing it used anywhere

    ---

    

    achow101 commented at 9:40 pm on October 29, 2020:

    To ensure that no default wallets are created.
14. hebasto approved
15. 
    hebasto commented at 9:54 pm on October 29, 2020: member

    ACK 7411876c75471a45ad40c38c668db3a4b9413fb9, tested on Linux Mint 20 (x86_64), tests pass for binaries compiled with:

    • --without-sqlite
    • --disable-wallet
16. 
    DrahtBot commented at 1:22 am on October 30, 2020: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #20267 (Disable and fix tests for when BDB is not compiled by achow101)
    • #18788 (tests: Update more tests to work with descriptor wallets by achow101)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

17. 
    Sjors commented at 10:24 am on October 30, 2020: member

    tACK 7411876c75471a45ad40c38c668db3a4b9413fb9

    You may want to swap the commits, so none of them break the tests.

18. meshcollider merged this on Nov 1, 2020
19. meshcollider closed this on Nov 1, 2020

    ---

20. sidhujag referenced this in commit 9f0ec85a18 on Nov 2, 2020
21. DrahtBot locked this on Feb 15, 2022

Contributors
achow101 michaelfolkson practicalswift ryanofsky mjdietzx hebasto DrahtBot Sjors

Labels
Build system

Milestone
0.21.0