script, doc: contrib/seeds updates #20288

pull jonatack wants to merge 2 commits into bitcoin:master from jonatack:contrib-seeds-fixups changing 2 files +8 −2

jonatack commented at 8:15 PM on November 2, 2020: member
Seen while reviewing #20237.
1. Fix a deprecation warning in contrib/seeds/makeseeds.py
```
    makeseeds.py:139: DeprecationWarning: please use dns.resolver.resolve() instead
      asn = int([x.to_text() for x in dns.resolver.query('.'.join(
```
- Per https://dnspython.readthedocs.io/en/latest/whatsnew.html, dns.resolver.query() was deprecated in dnspython version 2.0.0.
- See https://dnspython.readthedocs.io/en/latest/resolver-class.html for more info on the resolver class.
1. Update the dnspython dependency installation instructions in contrib/seeds/README
- The markdown rendering can be seen here: https://github.com/jonatack/bitcoin/tree/contrib-seeds-fixups/contrib/seeds

script: fix deprecation warning in makeseeds.py

makeseeds.py:139: DeprecationWarning: please use dns.resolver.resolve() instead
  asn = int([x.to_text() for x in dns.resolver.query('.'.join(

per https://dnspython.readthedocs.io/en/latest/whatsnew.html
dns.resolver.query() was deprecated in dnspython version 2.0.0

dd7b5f46d8

doc: update contrib/seeds/README dnspython installation info 961f148cb1
DrahtBot added the label Docs on Nov 2, 2020
DrahtBot added the label Scripts and tools on Nov 2, 2020
practicalswift commented at 9:01 PM on November 2, 2020: contributor

Concept ACK

Thanks for cleaning up!
fanquake commented at 11:53 PM on November 2, 2020: member

~0. This has to wait until after branch off otherwise it will break our Python 3.5 requirement.
jonatack commented at 9:21 AM on November 3, 2020: member

Sure, can re-open after we bump the minimum to 3.6.
jonatack closed this on Nov 3, 2020
jonatack commented at 10:24 AM on November 18, 2020: member

Re-opening now that the minimum Python version has been bumped to 3.6.
jonatack reopened this on Nov 18, 2020
laanwj commented at 9:11 AM on November 19, 2020: member

code review ACK 961f148cb1b4caab86b4354357999e03433b04b1
laanwj merged this on Nov 19, 2020
laanwj closed this on Nov 19, 2020
jonatack deleted the branch on Nov 19, 2020
sidhujag referenced this in commit 0c1c7970e8 on Nov 19, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Docs Scripts and tools

Linked (view graph)

#20237 net: Hardcoded seeds update for 0.21