script, doc: contrib/seeds updates #20288

pull jonatack wants to merge 2 commits into bitcoin:master from jonatack:contrib-seeds-fixups changing 2 files +8 −2
  1. jonatack commented at 8:15 PM on November 2, 2020: member

    Seen while reviewing #20237.

    1. Fix a deprecation warning in contrib/seeds/makeseeds.py
        makeseeds.py:139: DeprecationWarning: please use dns.resolver.resolve() instead
          asn = int([x.to_text() for x in dns.resolver.query('.'.join(
    
    1. Update the dnspython dependency installation instructions in contrib/seeds/README
  2. script: fix deprecation warning in makeseeds.py
    makeseeds.py:139: DeprecationWarning: please use dns.resolver.resolve() instead
      asn = int([x.to_text() for x in dns.resolver.query('.'.join(
    
    per https://dnspython.readthedocs.io/en/latest/whatsnew.html
    dns.resolver.query() was deprecated in dnspython version 2.0.0
    dd7b5f46d8
  3. doc: update contrib/seeds/README dnspython installation info 961f148cb1
  4. DrahtBot added the label Docs on Nov 2, 2020
  5. DrahtBot added the label Scripts and tools on Nov 2, 2020
  6. practicalswift commented at 9:01 PM on November 2, 2020: contributor

    Concept ACK

    Thanks for cleaning up!

  7. fanquake commented at 11:53 PM on November 2, 2020: member

    ~0. This has to wait until after branch off otherwise it will break our Python 3.5 requirement.

  8. jonatack commented at 9:21 AM on November 3, 2020: member

    Sure, can re-open after we bump the minimum to 3.6.

  9. jonatack closed this on Nov 3, 2020

  10. jonatack commented at 10:24 AM on November 18, 2020: member

    Re-opening now that the minimum Python version has been bumped to 3.6.

  11. jonatack reopened this on Nov 18, 2020

  12. laanwj commented at 9:11 AM on November 19, 2020: member

    code review ACK 961f148cb1b4caab86b4354357999e03433b04b1

  13. laanwj merged this on Nov 19, 2020
  14. laanwj closed this on Nov 19, 2020

  15. jonatack deleted the branch on Nov 19, 2020
  16. sidhujag referenced this in commit 0c1c7970e8 on Nov 19, 2020
  17. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 21:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me