See https://docs.python.org/3/library/plistlib.html. The old API was deprecated in 3.4 and removed in 3.9.
AFAIK the macdeployplus scripts is only used when calling make deploy locally (on macOS). The linux cross compile build (like gitian) are not affected by this PR.
585@@ -586,7 +586,12 @@ if len(config.fancy) == 1:
586 sys.exit(1)
587
588 try:
589- fancy = plistlib.readPlist(p)
590+ # the old plistlib API was removed in python3.9, use the new API instead
591+ if (sys.version_info.major, sys.version_info.minor) >= (3, 9):
no need for this check. This has been added in python 3.4 https://docs.python.org/3.4/library/plistlib.html#plistlib.load
And we don’t even support 3.4 anymore.
See https://docs.python.org/3/library/plistlib.html.
The new API was added in 3.4 and old removed in 3.9.
AFAIK the macdeployplus scripts is only used when calling make deploy locally (on macOS). The linux cross compile build (like gitian) are not affected by this PR.
The macdeployqtplus script is used on macOS and Linux for the cross-compile/gitian. See here:
https://github.com/bitcoin/bitcoin/blob/88776c2926061482ab551b0cf5c408fc1bc39ac3/Makefile.am#L153-L155
make deploy on macOS currently fails when building master and using Python 3.9. This PR fixes that, and it’s fine to use (and backport) these changes as they only require Python 3.4. Related note: I think we could just about drop our native_biplist dependency entirely given some changes upstream.