ci: Use travis_fold on Travis CI only #20357

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:201109-travis changing 1 files +7 −2

hebasto commented at 8:13 PM on November 9, 2020: member

No description provided.
ci: Use travis_fold on Travis CI only dde5f4a1a5
DrahtBot added the label Tests on Nov 9, 2020

in ci/test/03_before_install.sh:24 in dde5f4a1a5

  21 |  END_FOLD () {
  22 |    RET=$?
  23 | -  echo "travis_fold:end:${CURRENT_FOLD_NAME}"
  24 | +  echo "${FOLD_COMMAND}end:${CURRENT_FOLD_NAME}"
  25 |    if [ $RET != 0 ]; then
  26 |      echo "${CURRENT_FOLD_NAME} failed with status code ${RET}"

maflcko commented at 9:16 AM on November 10, 2020:

Pretty sure this is dead code due to use of our errexit.

in ci/test/03_before_install.sh:12 in dde5f4a1a5
```
   5 | @@ -6,15 +6,20 @@
   6 |  
   7 |  export LC_ALL=C.UTF-8
   8 |  
   9 | +FOLD_COMMAND=""
  10 | +if [[ ${TRAVIS} == "true" ]]; then
  11 | +  FOLD_COMMAND="travis_fold:"
  12 | +fi
```
maflcko commented at 9:18 AM on November 10, 2020:

Not sure if it is worth it to keep travis related code in our ci files, given that we move away from it.

maflcko commented at 7:27 AM on December 2, 2020:

./ci/test/ doesn't use travis anymore
maflcko commented at 9:18 AM on November 10, 2020: member

review ACK dde5f4a1a57a6fcbbadb47e35b2b409eadac0a2f, but I am not sure if it is worth it to keep travis related code in our ci files at all, given that we move away from it.
fanquake commented at 4:16 AM on December 2, 2020: member

I agree with Marco, lets just finish up removing the remaining Travis related code. I assume that'll be done as part of, or just after #20467.
fanquake closed this on Dec 2, 2020
maflcko commented at 7:27 AM on December 2, 2020: member

#20467 is only about the linters. ./ci/test doesn't use travis anymore already.
maflcko reopened this on Dec 2, 2020
hebasto commented at 7:36 AM on December 2, 2020: member

Agree. After linter moving from Travis, all Travis related code should be just removed.
hebasto commented at 8:07 PM on December 17, 2020: member

Closed in favor of #20691.
hebasto closed this on Dec 17, 2020
bitcoin locked this on Feb 22, 2021
hebasto deleted the branch on Dec 11, 2023

Contributors

Labels