fanquake
commented at 1:50 pm on November 18, 2020:
member
This is a requirement for C++17 support. See my comments here:
You cannot use std::get with std::variant on macOS < 10.14, because Apples libc++ doesn’t support the std::bad_variant_access exception. Relevant comment in #19183.
While we could work around this in our own code, using std::get_if, this would still be a problem for 3rd-party dependencies.
I’ve been testing Qt 5.15LTS (we’ll have to enable C++17 in qt, and may upgrade to a newer version at the same time), and you can’t enable -std c++17, while targeting a macOS deployment version < 10.14, configuring will fail. They are making use of std::get with std::variant throughout their cocoa code.
We would have to had to have bumped to at least 10.13 in any case, as Qt 5.15 (#19716) requires 10.13+.
build: set minimum supported macOS to 10.14a52ecc936a
fanquake added the label
macOS
on Nov 18, 2020
fanquake added the label
Build system
on Nov 18, 2020
fanquake added this to the milestone 22.0
on Nov 18, 2020
MarcoFalke added the label
Needs gitian build
on Nov 18, 2020
MarcoFalke added the label
Needs Guix build
on Nov 18, 2020
jonasschnelli
commented at 2:05 pm on November 18, 2020:
contributor
macOS 10.14 was released Sept 2018. Do we really want to drop older macOSes? Also some (older) Mac Hardware can’t be upgraded to 10.14.
MarcoFalke
commented at 2:17 pm on November 18, 2020:
member
No opinion on this, but it should be possible to use C++17, but postpone std::variant and qt5.15 to a later release?
luke-jr
commented at 3:33 pm on November 18, 2020:
member
macOS 10.13 is still supported and 10.13.6 was released only 6 days ago…
But, we only support the most recent LTS of major Linux distros. I see no reason the macOS equivalent wouldn’t be macOS 11 (Big Sur)…
otoh, maybe the policy needs to be different for macOS due to the hardware incompatibility @jonasschnelli mentions…
DrahtBot
commented at 4:07 pm on November 18, 2020:
member
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Conflicts
Reviewers, this pull request conflicts with the following ones:
#20019 (depends: Properly pass $PATH to configure and pin by dongcarl)
#19179 (ci: Run ci configs on cirrus by MarcoFalke)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
MarcoFalke
commented at 4:43 pm on November 18, 2020:
member
But, we only support the most recent LTS of major Linux distros. I see no reason the macOS equivalent wouldn’t be macOS 11 (Big Sur)…
You keep repeating that, but I can’t find where this is documented or was discussed.
hebasto
commented at 5:01 pm on November 18, 2020:
member
macOS 10.13 is still supported and 10.13.6 was released only 6 days ago…
Not a release, but a security update, right?
If C++17 and macOS 10.13 cannot coexist peacefully, I Concept ACK on moving to macOS 10.14+
Owners of macOS 10.13 have two choices:
upgrade macOS (if hw supports it)
do not upgrade Bitcoin Core
luke-jr
commented at 5:13 pm on November 18, 2020:
member
@MarcoFalke That’s been the case for many years. I don’t recall when it was first discussed, but it likely came up around C++11 migration.
@hebasto I think there’s also an option to install Linux? Also, I don’t think anyone has plans to support 0.21 longer than normal…
MarcoFalke
commented at 6:37 pm on November 18, 2020:
member
@luke-jr The previous LTS of Ubuntu (18.04) is fully supported and stays that way. Dropping support for that would also drop support for the most prominent OS that all nodes run on.
MarcoFalke
commented at 6:55 pm on November 18, 2020:
member
macOS 10.13 High Sierra - End of Life Support Ending November 30, 2020
DrahtBot removed the label
Needs Guix build
on Nov 19, 2020
laanwj
commented at 10:01 am on November 19, 2020:
member
Concept ACK. I don’t think bumping the minimum MacOS version was ever an issue before. In contrast to Windows and Linux users, Mac users tend to be, in general, really eager for OS updates, and the life of an older version is very short.
practicalswift
commented at 10:50 am on November 19, 2020:
contributor
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2024-11-17 00:12 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me
