Check both failure cases:
- Use a glibc symbol from a version that is too new
- Use a symbol from a library that is not in the allowlist
And also check a conforming binary.
Adding a similar check for Windows PE can be done in a separate PR.
contrib: Add test for ELF symbol-check #20476
pull laanwj wants to merge 2 commits into bitcoin:master from laanwj:2020_11_test_symbol_check changing 3 files +129 −0-
laanwj commented at 12:20 PM on November 24, 2020: member
- laanwj added the label Tests on Nov 24, 2020
- laanwj added the label Scripts and tools on Nov 24, 2020
-
in contrib/devtools/test-symbol-check.py:31 in afc20c234f outdated
26 | + # there's no way to do this test for RISC-V at the moment; bionic's libc is 2.27 27 | + # and we allow all symbols from 2.27. 28 | + if 'riscv' in get_machine(cc): 29 | + self.skipTest("test not available for RISC-V") 30 | + 31 | + # emfd_create was introduced in GLIBC 2.27, so is newer than the upper limit of
fanquake commented at 9:50 AM on November 30, 2020:s/emfd_create/memfd_create
fanquake commented at 9:54 AM on November 30, 2020: memberConcept ACK - thanks for putting this together. Will actually test shortly.
fanquake added the label Needs gitian build on Nov 30, 2020fanquake commented at 10:04 AM on December 2, 2020: memberI added a test for macOS if you wanted to pull that in as well: https://github.com/fanquake/bitcoin/commit/9e6e59b01e1e4e3325bab59cf97139b462b42651.
DrahtBot commented at 1:28 PM on December 2, 2020: member<!--a722867cd34abeea1fadc8d60700f111-->
Gitian builds
DrahtBot removed the label Needs gitian build on Dec 2, 20205bab08df17contrib: Add test for ELF symbol-check
Check both failure cases: - Use a glibc symbol from a version that is too new - Use a symbol from a library that is not in the allowlist And also check a conforming binary. Adding a similar check for Windows PE can be done in a separate PR.
contrib: add MACHO tests to symbol-check tests ed1bbcefealaanwj force-pushed on Dec 3, 2020laanwj commented at 11:17 AM on December 3, 2020: memberI added a test for macOS if you wanted to pull that in as well: fanquake@9e6e59b.
Thanks ! I didn't mention macOS in the OP because I (mistakenly) thought we only had a symbol check for windows and linux. Good to have a test for that too.
I've fixed the comment and cherry-picked that commit.
laanwj closed this on Dec 3, 2020laanwj reopened this on Dec 3, 2020laanwj commented at 11:13 PM on December 3, 2020: member(close/ropen was to test the IRC bot)
fanquake approvedfanquake commented at 7:33 AM on December 7, 2020: memberACK ed1bbcefeaafef460b6e5609de85e13c12e0d2a4
fanquake merged this on Dec 7, 2020fanquake closed this on Dec 7, 2020sidhujag referenced this in commit 5c42906277 on Dec 7, 2020fanquake referenced this in commit 054710615c on Dec 10, 2020sidhujag referenced this in commit bb1ae294fc on Dec 10, 2020DrahtBot locked this on Feb 15, 2022Labels
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 06:14 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 06:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me