Follow up to #20476. Adds a test for the PE symbol check. One failing case where we link against -lpdh and a pass case.
contrib: add symbol check test for PE binaries #20608
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:symbol_check_test_pe changing 2 files +38 −0-
fanquake commented at 3:15 PM on December 9, 2020: member
-
contrib: add symbol check test for PE ae9b48995b
- fanquake added the label Windows on Dec 9, 2020
- fanquake added the label Scripts and tools on Dec 9, 2020
-
laanwj commented at 8:33 PM on December 9, 2020: member
Code review ACK ae9b48995bff505ea2b771313cac65d9acf6f29e The ARM failure seems unrelated.
-
dongcarl commented at 10:17 PM on December 9, 2020: member
Code Review ACK ae9b48995bff505ea2b771313cac65d9acf6f29e
Currently this doesn't run in Guix containers due to the debian-specific
--no-*flags. Will patch our binutils in Guix to enable these flags. -
fanquake commented at 3:33 AM on December 10, 2020: member
Currently this doesn't run in Guix containers due to the debian-specific --no-* flags.
Worth noting that these flags are unavailable in Ubuntu 20.04LTS, as the
binutils-mingw-w64-x86-64package is version 8.8, and the commit to restore the--no-*flags (related discussion in #18629) is in 8.9. The flags are present again in 20.10+ (Groovy). - fanquake merged this on Dec 10, 2020
- fanquake closed this on Dec 10, 2020
- sidhujag referenced this in commit bb1ae294fc on Dec 10, 2020
- fanquake deleted the branch on Feb 9, 2021
- DrahtBot locked this on Aug 16, 2022
Labels