Add "checkpoints" option, to permit disabling of checkpoint logic. #2048

pull jgarzik wants to merge 2 commits into bitcoin:master from jgarzik:no-checkpoints changing 2 files +10 −0

jgarzik commented at 5:09 PM on November 28, 2012: contributor

No description provided.
Add "checkpoints" option, to permit disabling of checkpoint logic. 857b3ad923
New 'checkpoints' option should default to true. e6955d0411
BitcoinPullTester commented at 5:28 PM on November 28, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/e6955d04111e842cce55dc230d9dcc971560a299 for binaries and test log.

in src/init.cpp:None in e6955d0411

 257 | @@ -258,6 +258,7 @@ bool static Bind(const CService &addr, unsigned int flags) {
 258 |          "  -onlynet=<net>         " + _("Only connect to nodes in network <net> (IPv4, IPv6 or Tor)") + "\n" +
 259 |          "  -discover              " + _("Discover own IP address (default: 1 when listening and no -externalip)") + "\n" +
 260 |          "  -irc                   " + _("Find peers using internet relay chat (default: 0)") + "\n" +
 261 | +        "  -checkpoints           " + _("Lock in block chain with compiled-in checkpoints (default: 1)") + "\n" +

Diapolo commented at 6:40 PM on November 28, 2012:

I find it hard to understand that explanation, can you try to explain what this does? @jgarzik Why not just use Enable block chain checkpoint logic (default: 1)? Your current help string seems impossible to translate for me currently ^^.

rebroad commented at 4:03 PM on December 20, 2012:

I prefer Diapolo's description also...

Diapolo commented at 10:22 AM on December 21, 2012:

And I still don't get the meaning in german from that weird english description...

gavinandresen commented at 6:53 PM on November 28, 2012: contributor

ACK
gmaxwell commented at 6:57 PM on November 28, 2012: contributor

ACK
sipa commented at 7:42 PM on November 28, 2012: member

Do you mind adding a CheckPoints::fEnabled, and setting that from AppInit2(), instead of constantly reparsing the command-line flag?
gavinandresen referenced this in commit a9e055a1ca on Dec 12, 2012
gavinandresen merged this on Dec 12, 2012
gavinandresen closed this on Dec 12, 2012
laudney referenced this in commit 2fb90e767b on Mar 19, 2014
sidhujag referenced this in commit 399cc913c7 on Apr 23, 2018
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#2693 Replace repeated GetBoolArg() calls with Checkpoint::fEnabled variable set once at init time #17729 Fuzzing Bug undefined-behavior pubkey.cpp:210:38 #18913 ci: fuzz/process_message fails #22233 fuzz: UndefinedBehaviorSanitizer warnings in consensus/tx_verify.cpp #25323 miniscript fuzzer failing after qa-assets update #27992 ci: build Valgrind (3.21) from source #28665 'std::out_of_range' crash in I2P fuzz test #30473 fuzz: Limit parse_univalue input length #30476 scriptpubkeyman fuzz target TopUp is slow