Remove unused bits from service flags enum #20606

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2012-netServiceFlags changing 3 files +0 −6

MarcoFalke commented at 11:40 AM on December 9, 2020: member

Remove service bits that haven't been observed on the active network for years and won't ever be observed on the network with this meaning. Keeping this dead assignment in our source code forever doesn't add any value.

I somehow forgot to do this in commit fa0d0ff6e1bee60fde63724ae28a51aac5a94d4a.
Remove unused bits from service flags enum fa40168ab3
MarcoFalke added the label P2P on Dec 9, 2020
laanwj commented at 11:42 AM on December 9, 2020: member

Code review ACK fa40168ab3102b9ad850f967a0e7fa22dbfbd0c6
fanquake approved
fanquake commented at 1:19 PM on December 9, 2020: member

ACK fa40168ab3102b9ad850f967a0e7fa22dbfbd0c6
practicalswift commented at 2:27 PM on December 9, 2020: contributor

cr ACK fa40168ab3102b9ad850f967a0e7fa22dbfbd0c6

Thanks for cleaning up!
laanwj merged this on Dec 9, 2020
laanwj closed this on Dec 9, 2020
MarcoFalke deleted the branch on Dec 9, 2020
sidhujag referenced this in commit ab38cdbc57 on Dec 9, 2020
laanwj commented at 9:51 AM on December 10, 2020: member

I think it would be sensible to have a similar policy here as the Linux kernel has in regards to hardware documentation. This amounts to only including the part of the hardware interface (registers, bitfields, etc) that are used in the code. It's out of scope to provide or maintain e a full overview.

Same here for the protocol. We need to be only concerned with the parts that directly affect us. For the rest there's the BIPs repository.
DrahtBot locked this on Feb 15, 2022

Contributors

Labels