Add /opt/homebrew to path to look for boost libraries

fyquah commented at 1:41 am on February 19, 2021: contributor

Following the instruction in https://github.com/bitcoin/bitcoin/blob/master/doc/build-osx.md for building on the M1 Macs don’t work out of the box, because homebrew now defaults to /opt/homebrew instead of /usr/local. This PR fixes that.

build: Add /opt/homebrew to path to look for boost libraries 9a0969585f

MarcoFalke added the label Build system on Feb 19, 2021

MarcoFalke added the label macOS on Feb 19, 2021

MarcoFalke added the label Needs gitian build on Feb 19, 2021

MarcoFalke added the label Needs Guix build on Feb 19, 2021

jonasschnelli approved

jonasschnelli commented at 11:38 am on February 19, 2021: contributor

Thanks! utACK 9a0969585fce03b45be7004bba865bc15909904c

DrahtBot removed the label Needs Guix build on Feb 20, 2021

MarcoFalke deleted a comment on Feb 20, 2021

DrahtBot commented at 1:29 am on February 21, 2021: member

Gitian builds

File	commit c46fe4d1073cd220b55ec8d55da2605529ea57a5(master)	commit bc7b99379132b5fbdd041317c1f2cbb8d7bc162a(master and this pull)
*-aarch64-linux-gnu-debug.tar.gz	`78c9c6d6d6928989...`	`d9e6f16aaffd0866...`
*-aarch64-linux-gnu.tar.gz	`af17571d516202c2...`	`45d984e9956a42f7...`
*-arm-linux-gnueabihf-debug.tar.gz	`78da25299d8399ba...`	`4b0cc2c5b2c514f1...`
*-arm-linux-gnueabihf.tar.gz	`b6e0759fda4c5599...`	`6ad1efb4725a222f...`
*-osx-unsigned.dmg	`c3879cd906f24184...`	`c3216cf9d97a0428...`
*-osx64.tar.gz	`cf4f938aee9348d1...`	`5b0a5ccea43e7658...`
*-powerpc64-linux-gnu-debug.tar.gz	`f72fb1addb3d2432...`	`c70058e7fbb6754f...`
*-powerpc64-linux-gnu.tar.gz	`1b236870c1c396c5...`	`8a8cbca15ddd61ab...`
*-powerpc64le-linux-gnu-debug.tar.gz	`f2a5d7460d4c724d...`	`433790c5bdafc827...`
*-powerpc64le-linux-gnu.tar.gz	`5aac39efa275b5e1...`	`b61a3ac1496b7f9c...`
*-riscv64-linux-gnu-debug.tar.gz	`135ecf7fd345dca1...`	`3fd577568ce14b0f...`
*-riscv64-linux-gnu.tar.gz	`c6d977137497bca9...`	`f41a61c70fd31a48...`
*-win64-debug.zip	`4de92538e25b760b...`	`be85928d31ec509f...`
*-win64-setup-unsigned.exe	`25a1eafea154cad1...`	`941b734d4f074a51...`
*-win64.zip	`acb89cdad7fd5600...`	`1d6d6496fffd608f...`
*-x86_64-linux-gnu-debug.tar.gz	`c32979a83b665138...`	`7a8c3799f2c65684...`
*-x86_64-linux-gnu.tar.gz	`3cd921825821892c...`	`6c83c2f37b11e92a...`
*.tar.gz	`3e1136eeafb3c989...`	`e5fb550b098c70f3...`
bitcoin-core-linux-22-res.yml	`8aeb808977e6530d...`	`c51c1f7fdc518d3c...`
bitcoin-core-osx-22-res.yml	`d35e35d2007eaf6e...`	`2a2b24052f98f063...`
bitcoin-core-win-22-res.yml	`7a63f6b736929f72...`	`c1558f75833ffb16...`
linux-build.log	`89e3d2dbca7c1641...`	`0993c1718dbf2b42...`
osx-build.log	`288b6624e9bef1d7...`	`aa4c83e4bb9399ae...`
win-build.log	`eb9dcb674de8f9c7...`	`def369ee82d491d6...`
bitcoin-core-linux-22-res.yml.diff		`3857868fc6dc05e0...`
bitcoin-core-osx-22-res.yml.diff		`c250bc50f9034360...`
bitcoin-core-win-22-res.yml.diff		`7f17a9977f1a6ad4...`
linux-build.log.diff		`6468119d5e7e6606...`
osx-build.log.diff		`b2198d8d4e59e3ef...`
win-build.log.diff		`c3d891081be4879a...`

DrahtBot removed the label Needs gitian build on Feb 21, 2021

fanquake commented at 2:32 am on February 21, 2021: member

This file is from an upstream respository. Can you submit your changes there as well? Generally we prefer not to modify these macros ourselves (or at least not without the changes sent upstream). In the mean time, you should be able to pass --with-boost=/opt/homebrew to configure.

laanwj commented at 12:03 pm on February 22, 2021: member

Concept ACK, but yes please submit this upstream, it wouldn’t be the first time that we make a custom change to the m4 scripts here and it gets lost on an update from upstream, better to avoid that.

laanwj added the label Upstream on Feb 22, 2021

fyquah commented at 2:42 pm on February 22, 2021: contributor

A patch is underway: https://lists.gnu.org/archive/html/autoconf-patches/2021-02/msg00006.html , i will update this thread when it gets accepted.

practicalswift commented at 5:08 pm on February 24, 2021: contributor

Concept ACK

Nice first-time contribution! Warm welcome as a contributor @fyquah.

laanwj commented at 1:42 pm on March 3, 2021: member

I really wish boost used pkgconfig like other libraries, to make it easy to find its include/lib directories; hardcoding paths is by definition always incomplete. (not something you can do anything with here but it came to mind again)

practicalswift commented at 2:20 pm on March 3, 2021: contributor

@laanwj

Aren’t we quite near the point where our Boost usage is header-only?

At that point I’ve assumed we will simply include the required headers in our repo, no? :)

fanquake commented at 12:26 pm on March 16, 2021: member

@fyquah Looks like you haven’t gotten a response on the mailing list. You might have more luck opening a PR here : https://github.com/autoconf-archive/autoconf-archive.

laanwj commented at 8:10 am on May 18, 2021: member

At that point I’ve assumed we will simply include the required headers in our repo, no? :)

I’m not sure what the legal situation around this is? Is the boost license compatible with MIT? (it is an interesting idea anyhow!)

promag commented at 8:58 pm on May 31, 2021: member

Tested ACK 9a0969585fce03b45be7004bba865bc15909904c.

Before I had to configure --with-boost=/opt/homebrew/Cellar/boost/1.76.0/ for instance (edit: @fanquake already points this above).

laanwj merged this on Jun 2, 2021

laanwj closed this on Jun 2, 2021

sidhujag referenced this in commit 70654e594f on Jun 3, 2021

PastaPastaPasta referenced this in commit d9a29ed7b6 on Jun 27, 2021

PastaPastaPasta referenced this in commit b204e02bf0 on Jun 28, 2021

PastaPastaPasta referenced this in commit 1983e97fea on Jun 29, 2021

PastaPastaPasta referenced this in commit 46a2d53f4a on Jul 1, 2021

PastaPastaPasta referenced this in commit eef8daa352 on Jul 1, 2021

PastaPastaPasta referenced this in commit 8ebffdfa7c on Jul 15, 2021

gwillen referenced this in commit 17f9112019 on Jun 1, 2022

DrahtBot locked this on Aug 16, 2022

Add /opt/homebrew to path to look for boost libraries #21231

Gitian builds