assumptions: Assume C++17 #21274

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:assuming_c++17 changing 2 files +6 −10

fanquake commented at 5:04 AM on February 23, 2021: member

This has been the case since #20413.

This should also enable the check for MSVC. From my reading of https://docs.microsoft.com/en-us/cpp/build/reference/zc-cplusplus?view=msvc-160 and https://devblogs.microsoft.com/cppblog/msvc-now-correctly-reports-__cplusplus/ if we set the /Zc:__cplusplus switch in additional options, MSVC will report the correct value for __cplusplus. However I have not tested this.
assumptions: assume a C++17 compiler
This has already been the case since #20413.
c7b46489f8

assumptions: check C++17 assumption with MSVC

From my reading of
https://docs.microsoft.com/en-us/cpp/build/reference/zc-cplusplus?view=msvc-160
and
https://devblogs.microsoft.com/cppblog/msvc-now-correctly-reports-__cplusplus/
if we set the `/Zc:__cplusplus` switch in additional options, MSVC will
report the correct value for `__cplusplus`.

5e531e6beb

fanquake added the label Build system on Feb 23, 2021
hebasto approved
hebasto commented at 7:47 AM on February 23, 2021: member

ACK 5e531e6beb5381c0be5efaa24b7e423e593568e4, checked the MS docs, and AppVeyor build is green.
laanwj commented at 7:56 AM on February 23, 2021: member

Code review ACK 5e531e6beb5381c0be5efaa24b7e423e593568e4 (201703L is the correct value for C++17)
sipa commented at 8:02 AM on February 23, 2021: member

@PS113 Stop spamming this repository.
fanquake requested review from practicalswift on Feb 23, 2021
practicalswift approved
practicalswift commented at 12:30 PM on February 23, 2021: contributor

ACK 5e531e6beb5381c0be5efaa24b7e423e593568e4

Thanks for fixing this: being explicit about our assumptions is a precondition for formal reasoning :)
MarcoFalke merged this on Feb 23, 2021
MarcoFalke closed this on Feb 23, 2021
fanquake deleted the branch on Feb 23, 2021
fanquake locked this on Feb 23, 2021

Contributors

Labels

Linked (view graph)

#20413 build: Require C++17 compiler