script: Add explanatory comment to tc.sh #21300

pull dscotese wants to merge 1 commits into bitcoin:master from dscotese:tc.sh changing 1 files +1 −1
  1. dscotese commented at 3:16 AM on February 26, 2021: contributor

    This is a replacement for #21289

    tc.sh is used to limit bandwidth. I ran it and it is limiting my bandwidth. When I ran it, I got one error. I have not found an explanation anywhere of what the error means, but my best guess is consistent with the result, so I propose the explanatory comment to save others time when they use it and also get the error.

  2. script: Add explanatory comment to tc.sh 3a0446fad4
  3. fanquake added the label Scripts and tools on Feb 26, 2021
  4. DrahtBot commented at 4:49 PM on March 15, 2021: member

    <!--4a62be1de6b64f3ed646cdc7932c8cf5-->

    🕵️ @practicalswift has been requested to review this pull request as specified in the REVIEWERS file.

  5. fanquake commented at 8:35 AM on April 1, 2021: member

    @laanwj in #21289 you said "Looks good to me otherwise.", is that still the case here?

  6. laanwj commented at 10:49 AM on April 1, 2021: member

    yes, i am okay with adding this comment, i am not happy with all the hassle around it though, it makes me reluctant to comment at all if every fixup is going to result in a new PR cycle

    i would also ideally prefer putting some more effort in it: prevent that error from happening in the first place, so that no one has to be surprised by it, for example by checking if there are tc rules and not sending the command unnecessarily (i don't use the tool myself so consider this a random bs suggestion)

    that said, LGTM ACK 3a0446fad470595db09929695ff02debe12bd4cd

  7. fanquake merged this on Apr 1, 2021
  8. fanquake closed this on Apr 1, 2021

  9. sidhujag referenced this in commit 73b9875684 on Apr 1, 2021
  10. PastaPastaPasta referenced this in commit b8a12f86d6 on Jun 27, 2021
  11. PastaPastaPasta referenced this in commit 135227a06a on Jun 28, 2021
  12. PastaPastaPasta referenced this in commit fdbf16cf8c on Jun 29, 2021
  13. PastaPastaPasta referenced this in commit f2368857f9 on Jul 1, 2021
  14. PastaPastaPasta referenced this in commit 04c1422026 on Jul 1, 2021
  15. PastaPastaPasta referenced this in commit cb023700a6 on Jul 15, 2021
  16. PastaPastaPasta referenced this in commit f7d4f8ae98 on Jul 15, 2021
  17. PastaPastaPasta referenced this in commit dcadc441aa on Jul 16, 2021
  18. DrahtBot locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 21:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me