build: set Unicode true for NSIS installer #21333

1. 
   fanquake commented at 8:54 am on March 2, 2021: member

   Now that we are using Focal for gitian builds, and have NSIS 3.0+ available (also in Guix), we can create installers that support unicode.

   Unicode is only becoming the NSIS default beginning with the 3.07 release, so we need to set this attribute to get support.

   Should close: #13817

   Gitian builds:

   0b8553615b6b4be5e4459e03796e700b30b5d198a7f184f27be6983ff901b5592  bitcoin-9086e0dd3c92-win-unsigned.tar.gz
   1a6b024a5a68e0196e8e118168c918285e820f2d0ffe9c38db680580459da8bf3  bitcoin-9086e0dd3c92-win64-debug.zip
   2ff4003d4f61127c707e44b5235eaf924b30351f20cde27e775131982a1b4cf92  bitcoin-9086e0dd3c92-win64-setup-unsigned.exe
   31876bee55fa9ea99b91203975c13d0ad8a046b4b58068bde41c977fd1d12de13  bitcoin-9086e0dd3c92-win64.zip
   4000f2778f8f166a89b4ab35f155156c1c34800be6e47d29b5308043c50128392  src/bitcoin-9086e0dd3c92.tar.gz
   5d650a9b8f2dd1df777bf42439dfcbcf6bc358e30ec148b9992a18b39f76b1ecf  bitcoin-core-win-22-res.yml
   

2. build: set Unicode true for NSIS installer

   Now that we are using Focal for gitian builds, and have NSIS 3.0+
   available (also in Guix), we can create installers that support unicode.
   
   Unicode is only becoming the default beginning with the 3.07 release,
   https://nsis.sourceforge.io/Docs/AppendixF.html#v3.07-cl,
   so we need to set this attribute to get support.
   
   Should close: #13817
   
   Co-authored-by: Chun Kuan Lee <ken2812221@gmail.com>

   9086e0dd3c
3. fanquake added the label Windows on Mar 2, 2021
4. fanquake added the label Build system on Mar 2, 2021
5. fanquake added the label Needs gitian build on Mar 2, 2021
6. fanquake added the label Needs Guix build on Mar 2, 2021
7. 
   hebasto commented at 8:59 am on March 2, 2021: member

   Concept ACK.
8. 
   MarcoFalke commented at 9:38 am on March 2, 2021: member

   version in current guix should be 3.05: https://github.com/dongcarl/guix/blob/7d6bd44da57926e0d4af25eba723a61c82beef98/gnu/packages/installers.scm#L37
9. 
   MarcoFalke commented at 9:39 am on March 2, 2021: member

   Might test if I find the windows vm again
10. 
    hebasto commented at 9:43 am on March 2, 2021: member

    Version in focal is 3.05 too: https://packages.ubuntu.com/focal/nsis
11. 
    laanwj commented at 10:17 am on March 2, 2021: member

    About time! Unicode? whoa, we’re in the future now :smile:

    ACK 9086e0dd3c924b6c9a5ad05799d30d97b9ced3be

12. 
    fanquake commented at 11:31 am on March 2, 2021: member

    Guix build @ 9086e0dd3c924b6c9a5ad05799d30d97b9ced3be:

    0bash-5.1# find output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
    110377ec7e6c54d0713623b987353d6724186103a5b6af6d9fe8eb7c543fb56bd  output/bitcoin-9086e0dd3c92-win-unsigned.tar.gz
    2e3dfd4e62381dcf8a7fda0045640449e04dfdc1eac8fbede9f82276a33909248  output/bitcoin-9086e0dd3c92-win64-debug.zip
    320411b4507e1a35fb6b1d19027883de64fbcb14cadd878a18e242cd65d54ec74  output/bitcoin-9086e0dd3c92-win64-setup-unsigned.exe
    4b929a62ed8d1ec4203b4d1d8f20a6c42883e583cda83b9b954b8076d64065f62  output/bitcoin-9086e0dd3c92-win64.zip
    5000f2778f8f166a89b4ab35f155156c1c34800be6e47d29b5308043c50128392  output/src/bitcoin-9086e0dd3c92.tar.gz
    

13. hebasto approved
14. 
    hebasto commented at 1:03 pm on March 2, 2021: member

    ACK 9086e0dd3c924b6c9a5ad05799d30d97b9ced3be, tested on Windows 10 Pro (20H2, build 19042.804):

    

    Compare to #13817 (comment)

15. 
    hebasto commented at 1:24 pm on March 2, 2021: member

    Guix build:

    0$ find output -type f -name *$(git rev-parse --short HEAD)*.* -print0 | sort -z | xargs -r0 sha256sum
    1e3dfd4e62381dcf8a7fda0045640449e04dfdc1eac8fbede9f82276a33909248  output/bitcoin-9086e0dd3c92-win64-debug.zip
    220411b4507e1a35fb6b1d19027883de64fbcb14cadd878a18e242cd65d54ec74  output/bitcoin-9086e0dd3c92-win64-setup-unsigned.exe
    3b929a62ed8d1ec4203b4d1d8f20a6c42883e583cda83b9b954b8076d64065f62  output/bitcoin-9086e0dd3c92-win64.zip
    410377ec7e6c54d0713623b987353d6724186103a5b6af6d9fe8eb7c543fb56bd  output/bitcoin-9086e0dd3c92-win-unsigned.tar.gz
    5000f2778f8f166a89b4ab35f155156c1c34800be6e47d29b5308043c50128392  output/src/bitcoin-9086e0dd3c92.tar.gz
    

16. 
    MarcoFalke commented at 6:49 pm on March 2, 2021: member

    Please upload the mismatching binaries. Otherwise this is harder to debug.
17. 
    hebasto commented at 6:53 pm on March 2, 2021: member

    @MarcoFalke

    Please upload the mismatching binaries. Otherwise this is harder to debug.

    Binaries (https://github.com/bitcoin/bitcoin/pull/21333#issuecomment-788840758, #21333 (comment)) match, only sort orders differ, no?

18. 
    fanquake commented at 1:18 am on March 3, 2021: member

    @hebasto you’ll need to update your output command so that the sorting matches every other contributor that has been posting hashes.
19. fanquake merged this on Mar 3, 2021
20. fanquake closed this on Mar 3, 2021

    ---

21. fanquake deleted the branch on Mar 3, 2021
22. sidhujag referenced this in commit 0eae38f8c7 on Mar 3, 2021
23. MarcoFalke removed the label Needs Guix build on Mar 3, 2021
24. MarcoFalke removed the label Needs gitian build on Mar 3, 2021
25. Fabcien referenced this in commit 5a7d692efc on Mar 11, 2021
26. deadalnix referenced this in commit 22a2525ecf on Mar 12, 2021
27. DrahtBot locked this on Aug 16, 2022

Contributors
fanquake hebasto MarcoFalke laanwj

Labels
Windows Build system