fuzz: Add missing include (test/util/setup_common.h) #21358

1. 
   MarcoFalke commented at 7:42 am on March 4, 2021: member

   src/test/fuzz/socks5.cpp is using the symbol BasicTestingSetup, which is defined in src/test/util/setup_common.h.

   Currently compilation happens to succeed because the needed dependency is indirectly included. Compilation will break as soon as the indirect dependency is broken. According to the dev notes, everything that is used must be included.

   Fix the issue by including the missing include.

2. fuzz: Add missing include (test/util/setup_common.h) fa59ad5130
3. MarcoFalke requested review from practicalswift on Mar 4, 2021
4. MarcoFalke requested review from fanquake on Mar 4, 2021
5. DrahtBot added the label Tests on Mar 4, 2021
6. in src/test/fuzz/torcontrol.cpp:8 in fa59ad5130

   0@@ -1,10 +1,11 @@
   1-// Copyright (c) 2020 The Bitcoin Core developers
   2+// Copyright (c) 2020-2021 The Bitcoin Core developers
   3 // Distributed under the MIT software license, see the accompanying
   4 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
   5 
   6 #include <test/fuzz/FuzzedDataProvider.h>
   7 #include <test/fuzz/fuzz.h>
   8 #include <test/fuzz/util.h>
   9+#include <test/util/setup_common.h>
   

   ---

   ---

   

   hebasto commented at 7:59 am on March 4, 2021:

   Which symbol does require this include?

   ---

   

   MarcoFalke commented at 8:15 am on March 4, 2021:

   Probably none in this file, but adding it in this commit will avoid a rebase in #21003 (comment)

   ---

   

   hebasto commented at 8:19 am on March 4, 2021:

   Does #21003 touch src/test/fuzz/torcontrol.cpp ?

   ---

   

   MarcoFalke commented at 8:34 am on March 4, 2021:

   No, but the MakeNoLogFileContext symbol is moved to a different file (via the indirect dependencies)
7. fanquake approved
8. 
   fanquake commented at 12:20 pm on March 4, 2021: member

   ACK fa59ad5130d732027d01b8aac04b88326b81ac5b
9. fanquake merged this on Mar 4, 2021
10. fanquake closed this on Mar 4, 2021

    ---

11. MarcoFalke deleted the branch on Mar 4, 2021
12. sidhujag referenced this in commit 1632df7f60 on Mar 4, 2021
13. 
    practicalswift commented at 8:12 pm on March 4, 2021: contributor

    Post-merge ACK fa59ad5130d732027d01b8aac04b88326b81ac5b

    Thanks for fixing this!

14. DrahtBot locked this on Aug 16, 2022

Contributors
MarcoFalke hebasto fanquake practicalswift

Review Requested
practicalswift

Labels
Tests