fuzz: Avoid -Wreturn-type warnings #21364

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:–Wreturn-type changing 1 files +3 −0

practicalswift commented at 8:36 PM on March 4, 2021: contributor

Avoid -Wreturn-type warnings.

Closes #21355.
fuzz: Avoid -Wreturn-type warnings 3f3646855c
in src/test/fuzz/util.h:13 in 3f3646855c
```
   9 | @@ -10,6 +10,7 @@
  10 |  #include <attributes.h>
  11 |  #include <chainparamsbase.h>
  12 |  #include <coins.h>
  13 | +#include <compat.h>
```
MarcoFalke commented at 8:52 PM on March 4, 2021:

nit: I am not really a fan of turning this into a "include all headers that exist" file. This could be a separate module, but as a start, what about moving the implementation details to the cpp file at least?

practicalswift commented at 7:32 AM on March 6, 2021:

I agree, but note that compat.h was already transitively included via at least four other already included files (net.h, netaddress.h, netbase.h and util/time.h).

Thus the explicit inclusion doesn't change anything in practice from a technical perspective: it only makes it clear that we depend on compat.h :)

Explicit is better than implicit as we all know by now :)
MarcoFalke approved
MarcoFalke commented at 8:53 PM on March 4, 2021: member

cr ACK 3f3646855c4005670909c8e76de91ad07c559c66

seems fine to do to, if this fixes a warning
DrahtBot added the label Tests on Mar 4, 2021
fanquake approved
fanquake commented at 2:41 AM on March 5, 2021: member

ACK 3f3646855c4005670909c8e76de91ad07c559c66 - thanks for cleaning this up.
fanquake merged this on Mar 5, 2021
fanquake closed this on Mar 5, 2021
sidhujag referenced this in commit 7106a1131e on Mar 5, 2021
practicalswift deleted the branch on Apr 10, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels

Linked (view graph)

#21355 windows: new -Wreturn-type warnings after #19203