guix: Do not treat directory existence as an error #21429

1. 
   hebasto commented at 5:26 PM on March 13, 2021: member

   This change prevents an error when doing consecutive guix builds for Windows.

   <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

   <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

   <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

2. guix: Do not treat directory existence as an error

   This change prevents an error when doing consecutive Windows builds.

   6216c1850e
3. hebasto added the label Build system on Mar 13, 2021
4. 
   DrahtBot commented at 11:49 PM on March 13, 2021: member

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #21462 (guix: Add guix-{attest,verify} scripts by dongcarl)
   • #21375 (guix: Misc feedback-based fixes + hier restructuring by dongcarl)
   • #21304 (guix: Add guix-clean script + establish gc-root for container profiles by dongcarl)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. 
   practicalswift commented at 4:32 PM on March 15, 2021: contributor

   Concept ACK on solving "consecutive builds" issues :)

   What would be the pros/cons of removing any leftovers (directories or files) from previous builds when starting a new Guix build? Are the Guix builds meant to be incremental?

6. 
   laanwj commented at 7:17 AM on March 16, 2021: member

   I think I would prefer to error out soon in this case like we do for the other build result / intermediate directories. All files left around are a potential source of non-determinism.

7. laanwj requested review from dongcarl on Mar 16, 2021
8. 
   laanwj commented at 5:44 PM on March 16, 2021: member

   See also #21304 which moves the directory into the distsrc.

9. 
   fanquake commented at 11:48 PM on March 17, 2021: member

   At this point I think we should just get #21375 reviewed and merged.

10. fanquake closed this on Mar 17, 2021

    ---

11. hebasto deleted the branch on Nov 27, 2021
12. DrahtBot locked this on Nov 27, 2022

Review Requested
dongcarl