Minor debugging change to only log this if bench debugging is enabled.
Only log time to write coins cache to disk if bench debug enabled #21475
pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:LogCoinsCacheDurationIfBenchDebug changing 2 files +4 −2-
rebroad commented at 9:56 AM on March 19, 2021: contributor
- DrahtBot added the label Validation on Mar 19, 2021
-
fanquake commented at 11:02 AM on March 19, 2021: member
~0. What is the motivation? This is generally useful information to have. You've also changed the file permissions.
-
practicalswift commented at 2:41 PM on March 19, 2021: contributor
Concept ACK on increasing signal-to-noise for our dear non-developer end-users by making debug style benchmarking output opt-in via
-debug. The file permission change seems like a mistake though? :) -
Only log time to write coins cache to disk if bench debug enabled 9594252905
- rebroad force-pushed on Mar 19, 2021
-
rebroad commented at 7:56 PM on March 19, 2021: contributor
@fanquake @practicalswift file permissions fixed - I'll keep an eye out for that in future, thanks.
-
practicalswift commented at 8:45 PM on March 19, 2021: contributor
cr ACK 95942529053554bcdc8c8937356c41a4b78c55d5: patch looks correct
-
jamesob commented at 10:16 PM on March 19, 2021: member
Why? This is useful information we use for bitcoinperf, and don't necessarily want to enable more severe debugging.
-
fanquake commented at 12:36 AM on March 20, 2021: member
You still haven't provided any motivation, this would likely just be a detriment to existing tools, and as mentioned above, this information is useful to have when not benchmarking/debugging.
- fanquake closed this on Mar 20, 2021
-
practicalswift commented at 9:55 AM on March 20, 2021: contributor
At least let him make his case before closing.
Consider re-opening.
-
- DrahtBot locked this on Aug 16, 2022
Contributors
Labels