fuzz: UndefinedBehaviorSanitizer warnings in netbase.cpp #21479

issue hebasto opened this issue on March 19, 2021

hebasto commented at 3:49 PM on March 19, 2021: member

https://cirrus-ci.com/task/6113700391157760:

Run netbase_dns_lookup with args ['/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz', '-runs=1', '/tmp/cirrus-ci-build/ci/scratch/qa-assets/fuzz_seed_corpus/netbase_dns_lookup']INFO: Seed: 2191391191
INFO: Loaded 1 modules   (515777 inline 8-bit counters): 515777 [0x55f8604c4498, 0x55f860542359), 
INFO: Loaded 1 PC tables (515777 PCs): 515777 [0x55f860542360,0x55f860d20f70), 
INFO:      510 files found in /tmp/cirrus-ci-build/ci/scratch/qa-assets/fuzz_seed_corpus/netbase_dns_lookup
INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 4096 bytes
INFO: seed corpus: files: 510 min: 1b max: 4042b total: 273870b rss: 117Mb
netbase.cpp:212:37: runtime error: implicit conversion from type 'int' of value -2147483632 (32-bit, signed) to type 'uint16_t' (aka 'unsigned short') changed the value to 16 (16-bit, unsigned)
    [#0](/bitcoin-bitcoin/0/) 0x55f85dbd91cc  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x338e1cc)
    [#1](/bitcoin-bitcoin/1/) 0x55f85cfd0f5f  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x2785f5f)
    [#2](/bitcoin-bitcoin/2/) 0x55f85ccebeb7  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x24a0eb7)
    [#3](/bitcoin-bitcoin/3/) 0x55f85e498067  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x3c4d067)
    [#4](/bitcoin-bitcoin/4/) 0x55f85e497d15  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x3c4cd15)
    [#5](/bitcoin-bitcoin/5/) 0x55f85cbf1851  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x23a6851)
    [#6](/bitcoin-bitcoin/6/) 0x55f85cbf0f95  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x23a5f95)
    [#7](/bitcoin-bitcoin/7/) 0x55f85cbf38b7  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x23a88b7)
    [#8](/bitcoin-bitcoin/8/) 0x55f85cbf3c19  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x23a8c19)
    [#9](/bitcoin-bitcoin/9/) 0x55f85cbe28ee  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x23978ee)
    [#10](/bitcoin-bitcoin/10/) 0x55f85cc0b732  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x23c0732)
    [#11](/bitcoin-bitcoin/11/) 0x7f05b2c830b2  (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
    [#12](/bitcoin-bitcoin/12/) 0x55f85cbb768d  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x236c68d)
SUMMARY: UndefinedBehaviorSanitizer: implicit-signed-integer-truncation netbase.cpp:212:37 in 
MS: 0 ; base unit: 0000000000000000000000000000000000000000
0xa,0x5c,0x0,0x1,0x0,0x0,0x10,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,
\x0a\\\x00\x01\x00\x00\x10\x00\x00\x00\x00\x00\x00\x00\x00
artifact_prefix='./'; Test unit written to ./crash-f5bef9785939348fdc554918c368ce0977d8fd7a
Base64: ClwAAQAAEAAAAAAAAAAA

INFO: Seed: 2191391191
INFO: Loaded 1 modules   (515777 inline 8-bit counters): 515777 [0x55f8604c4498, 0x55f860542359), 
INFO: Loaded 1 PC tables (515777 PCs): 515777 [0x55f860542360,0x55f860d20f70), 
INFO:      510 files found in /tmp/cirrus-ci-build/ci/scratch/qa-assets/fuzz_seed_corpus/netbase_dns_lookup
INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 4096 bytes
INFO: seed corpus: files: 510 min: 1b max: 4042b total: 273870b rss: 117Mb
netbase.cpp:212:37: runtime error: implicit conversion from type 'int' of value -2147483632 (32-bit, signed) to type 'uint16_t' (aka 'unsigned short') changed the value to 16 (16-bit, unsigned)
    [#0](/bitcoin-bitcoin/0/) 0x55f85dbd91cc  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x338e1cc)
    [#1](/bitcoin-bitcoin/1/) 0x55f85cfd0f5f  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x2785f5f)
    [#2](/bitcoin-bitcoin/2/) 0x55f85ccebeb7  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x24a0eb7)
    [#3](/bitcoin-bitcoin/3/) 0x55f85e498067  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x3c4d067)
    [#4](/bitcoin-bitcoin/4/) 0x55f85e497d15  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x3c4cd15)
    [#5](/bitcoin-bitcoin/5/) 0x55f85cbf1851  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x23a6851)
    [#6](/bitcoin-bitcoin/6/) 0x55f85cbf0f95  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x23a5f95)
    [#7](/bitcoin-bitcoin/7/) 0x55f85cbf38b7  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x23a88b7)
    [#8](/bitcoin-bitcoin/8/) 0x55f85cbf3c19  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x23a8c19)
    [#9](/bitcoin-bitcoin/9/) 0x55f85cbe28ee  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x23978ee)
    [#10](/bitcoin-bitcoin/10/) 0x55f85cc0b732  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x23c0732)
    [#11](/bitcoin-bitcoin/11/) 0x7f05b2c830b2  (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
    [#12](/bitcoin-bitcoin/12/) 0x55f85cbb768d  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x236c68d)
SUMMARY: UndefinedBehaviorSanitizer: implicit-signed-integer-truncation netbase.cpp:212:37 in 
MS: 0 ; base unit: 0000000000000000000000000000000000000000
0xa,0x5c,0x0,0x1,0x0,0x0,0x10,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,
\x0a\\\x00\x01\x00\x00\x10\x00\x00\x00\x00\x00\x00\x00\x00
artifact_prefix='./'; Test unit written to ./crash-f5bef9785939348fdc554918c368ce0977d8fd7a
Base64: ClwAAQAAEAAAAAAAAAAA

hebasto commented at 8:00 PM on March 19, 2021: member

I hope it is fixed in #21328.
hebasto closed this on Mar 19, 2021
jonatack commented at 8:10 PM on March 19, 2021: member

Yes :+1: hopefully #21328 (comment) should get it. I hit this issue in the fuzz CI there.
DrahtBot locked this on Aug 18, 2022

Contributors

hebasto

jonatack

Linked (view graph)

#1 JSON-RPC support for mobile devices ("ultra-lightweight" clients)#2 Long-term, safe, store-of-value #3 Encrypt wallet #4 Export/Import wallet in a human readable, future-proof format #5 Make the version number the protocol version and not the client version #6 Treat wallet as a generic keystore #7 Block-header-only, faster startup client #8 RPC command to sign text with wallet private key #9 Fix for GUI on Macs and latest wxWidgets #10 Add address to listtransactions output #11 Nolisten patch #12 Monitor transactions and/or blocks