build: Do not opt-in unused CoreWLAN stuff in depends for macOS #21497

We do not use any macOS CoreWLAN Framework stuff.

Changes in Qt Configure summary with HOST=x86_64-apple-darwin18:

--- wlan-master/summary	2021-03-22 00:26:04.377387806 +0200
+++ wlan-pr/summary	2021-03-22 00:37:07.060997990 +0200
@@ -49,7 +49,7 @@
     slog2 ................................ no
   Using system PCRE2 ..................... no
 Qt Network:
-  CoreWLan ............................... yes
+  CoreWLan ............................... no
   getifaddrs() ........................... yes
   IPv6 ifname ............................ yes
   libproxy ............................... no

Gitian build:

Generating report
8b390310dc632a6da8325bf9128097c108abab69c3f2eac3870128f58c518ed7  bitcoin-810b1310d617-osx-unsigned.dmg
4dc59bd29edccbca1b1d4ab6f206997d8afbc2304fc7f939d1047684c47b89c2  bitcoin-810b1310d617-osx-unsigned.tar.gz
64e63902ef654b89d1039068a2605b90a16d8a1d07bfa233c52ea75627d04e70  bitcoin-810b1310d617-osx64.tar.gz
8b1865ec89b25183c6fb7a7b4bdaf5c35d0645235d409badce6cb2e38364fb13  src/bitcoin-810b1310d617.tar.gz
f58d7bdf97840821ba1800079b87e8013266bbc08bfafcca678c4c4da3b424bd  bitcoin-core-osx-22-res.yml
Done.

Guix build:

$ find output -type f -name *$(git rev-parse --short HEAD)*.* -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
53f9ccf344e82e5bd76fa1ddb84be659f026ee267741f480869ae97dc103518c  output/bitcoin-810b1310d617-osx-unsigned.dmg
be07fd079ed96c5c760783ce10119a3101cf92cf8175f56d6f2858c387943ad5  output/bitcoin-810b1310d617-osx-unsigned.tar.gz
2cf3e1028d96322b1f263d57d6a3f5a3a8d736600c1a16ec21627c2dc31d08f7  output/bitcoin-810b1310d617-osx64.tar.gz
8b1865ec89b25183c6fb7a7b4bdaf5c35d0645235d409badce6cb2e38364fb13  output/src/bitcoin-810b1310d617.tar.gz

ACK 810b1310d6173250df850db0538e7f1b1cfb2843 - Only obvious difference I could see in the build is skipping a configure check.

Guix:

53f9ccf344e82e5bd76fa1ddb84be659f026ee267741f480869ae97dc103518c  output/bitcoin-810b1310d617-osx-unsigned.dmg
be07fd079ed96c5c760783ce10119a3101cf92cf8175f56d6f2858c387943ad5  output/bitcoin-810b1310d617-osx-unsigned.tar.gz
2cf3e1028d96322b1f263d57d6a3f5a3a8d736600c1a16ec21627c2dc31d08f7  output/bitcoin-810b1310d617-osx64.tar.gz
8b1865ec89b25183c6fb7a7b4bdaf5c35d0645235d409badce6cb2e38364fb13  output/src/bitcoin-810b1310d617.tar.gz

Gitian

Generating report
8b390310dc632a6da8325bf9128097c108abab69c3f2eac3870128f58c518ed7  bitcoin-810b1310d617-osx-unsigned.dmg
4dc59bd29edccbca1b1d4ab6f206997d8afbc2304fc7f939d1047684c47b89c2  bitcoin-810b1310d617-osx-unsigned.tar.gz
64e63902ef654b89d1039068a2605b90a16d8a1d07bfa233c52ea75627d04e70  bitcoin-810b1310d617-osx64.tar.gz
8b1865ec89b25183c6fb7a7b4bdaf5c35d0645235d409badce6cb2e38364fb13  src/bitcoin-810b1310d617.tar.gz
ce11429fd567c1bc27cd091138fe78396614361bd3efb32498fbaf695f0dcdc9  bitcoin-core-osx-22-res.yml
Done.

Concept ACK

Dependencies are part of the attack surface in some sense, and attack surface reduction is good by definition :)

Only obvious difference I could see in the build is skipping a configure check.

This is because CoreWLan is only used by the bearer plugin, which we already disable. So no compilation saved, just skipping a configure check.