build: Remove unused header from the build system #21505

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:210322-miniwget changing 2 files +1 −4

hebasto commented at 5:14 PM on March 22, 2021: member

The only #include <miniupnpc/miniwget.h> was removed in #16659.
build: Remove unused header from the build system 0eabb2abed
DrahtBot added the label Build system on Mar 22, 2021
hebasto marked this as ready for review on Mar 22, 2021

hebasto commented at 6:40 PM on March 22, 2021: member

Gitian builds:

Linux:

Generating report
08a16d4149e2d19d2cf7b232249d4a04e7a161e1b6cbb9eebdce0a06a45cbd2b  bitcoin-0eabb2abede1-aarch64-linux-gnu-debug.tar.gz
aaba52b759e65ab01eff9920817db7cad893e86e2c140dfc30ac18d1013efff5  bitcoin-0eabb2abede1-aarch64-linux-gnu.tar.gz
05c13e8fe4e13bba2b07af59efac2c5ec6e659e7eef68f75fcc9e23e374465d8  bitcoin-0eabb2abede1-arm-linux-gnueabihf-debug.tar.gz
58ceab528732b6c70f28b35ec79e231d642e10ab99a295ae2bd578fc47d9affa  bitcoin-0eabb2abede1-arm-linux-gnueabihf.tar.gz
c565394cfe33940f776d996c38a578a27396a51add80507f0e9101d5501f5761  bitcoin-0eabb2abede1-powerpc64-linux-gnu-debug.tar.gz
906735ab6772e3a620521729fd45fd63ab085f01b61ecbbd7ce76ac761b8071a  bitcoin-0eabb2abede1-powerpc64-linux-gnu.tar.gz
9b17e8dba0dbe9a12ca0cb4c95c4a92ce4120c4459458abb9928bdf5ad524622  bitcoin-0eabb2abede1-powerpc64le-linux-gnu-debug.tar.gz
ec23f9eb66706e2e42bfb7c46995f466457e5099e8146d50d8e71d1aec97dbb2  bitcoin-0eabb2abede1-powerpc64le-linux-gnu.tar.gz
2c51250b9950d13d47b087a3192e85ab7024bcbd54ea3aff1dd325b9738e5613  bitcoin-0eabb2abede1-riscv64-linux-gnu-debug.tar.gz
245718723f4f20f5a527026b8d8aebbf5cfebff638f980d68ff304170d3e4dac  bitcoin-0eabb2abede1-riscv64-linux-gnu.tar.gz
52704a84fb48bac4638778f092884ca65baa450bc609ebc013434f54679d6719  bitcoin-0eabb2abede1-x86_64-linux-gnu-debug.tar.gz
992590d70807ab26bb31b18ea3c72a81df42b8ed996b3f614fb120c6d06239e0  bitcoin-0eabb2abede1-x86_64-linux-gnu.tar.gz
237536775e3665d7f8f52a4a6b08d5da4929c489984810e7f62f49d8a54dc4dd  src/bitcoin-0eabb2abede1.tar.gz
088705f6837e36bf17765dfd4f706a344e325ea158771a2e245dc76923a92948  bitcoin-core-linux-22-res.yml
Done.

Windows:

Generating report
8edbbac0646dd0c4b94cb2f2d74c386b312a932fad3039651a67f7067d478e6c  bitcoin-0eabb2abede1-win-unsigned.tar.gz
404f367cf8045d5a72de93e05949d1b4b0510e7434ff9fa6e87612cec5b28858  bitcoin-0eabb2abede1-win64-debug.zip
1a31f3980080e17773818b99e32bd17604e8c8439ae6fb4a9a3d078185c57269  bitcoin-0eabb2abede1-win64-setup-unsigned.exe
8865dfc71a8833e1e5376e6eab72cc431efe07314a3764a8fd48a6afb5389ca0  bitcoin-0eabb2abede1-win64.zip
237536775e3665d7f8f52a4a6b08d5da4929c489984810e7f62f49d8a54dc4dd  src/bitcoin-0eabb2abede1.tar.gz
687eaeb1723d75bac9359dfb2bf3fb74366628239f187fa4156f7e9fc6e5e77a  bitcoin-core-win-22-res.yml
Done.

macOS:

Generating report
dc96f5ba67417912ab59ff660d195404c51420eda05fdd0ce2d03cc0d7ea499a  bitcoin-0eabb2abede1-osx-unsigned.dmg
36c611853f59b6d320e13fba6b39d2fb960985405bb8f0a4616d77351c54570d  bitcoin-0eabb2abede1-osx-unsigned.tar.gz
6819103cdb7704e0b8a01ce41c4ea37f39ec9d0f47d5657b3e6166eb8f7336c6  bitcoin-0eabb2abede1-osx64.tar.gz
237536775e3665d7f8f52a4a6b08d5da4929c489984810e7f62f49d8a54dc4dd  src/bitcoin-0eabb2abede1.tar.gz
ab251b27e94c8746dd14983995fec16d6a2de83b72e5f266f52ce14ab94f0730  bitcoin-core-osx-22-res.yml
Done.

practicalswift commented at 8:02 PM on March 22, 2021: contributor

cr ACK 0eabb2abede1230edcc0d7b660d9635135f0b4c1

Thanks for removing unused stuff!

hebasto commented at 8:52 PM on March 22, 2021: member

Guix builds:

$ find output -type f -name *$(git rev-parse --short HEAD)*.* -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
a806ba8be503d90d11b38b1824a98fa1a572251ec845c50ea9bb5ef8035559ed  output/bitcoin-0eabb2abede1-aarch64-linux-gnu-debug.tar.gz
aa5f1b9d2da4e346fcea778d1e211ac48808959e5f8bb567476c21d8e2431709  output/bitcoin-0eabb2abede1-aarch64-linux-gnu.tar.gz
403716b91ffb6241a371dec0b09665166e3e391f2a039b669f521f13ad023ba3  output/bitcoin-0eabb2abede1-arm-linux-gnueabihf-debug.tar.gz
d9c45d1538842a685f095e846ca65ef8f9e8f6c1c43b0700b62f6594c23aa989  output/bitcoin-0eabb2abede1-arm-linux-gnueabihf.tar.gz
e20c7d84e2c4db92a9c2629de496d88950db8c088dc09040add2552bc8cd1b41  output/bitcoin-0eabb2abede1-osx-unsigned.dmg
3f9c762dd2ed2ff0be8e8d74a7b7da273a2dbfc2586c568ef7ae3292eaff06c2  output/bitcoin-0eabb2abede1-osx-unsigned.tar.gz
c348b71f93044dabd9bf69e96ecb782ab7be9a5423276d45761c3fa54c03d231  output/bitcoin-0eabb2abede1-osx64.tar.gz
254259f21072bf30e5d81e0815042991b3d63f9d2c0f3a428cf780e505c4c7fc  output/bitcoin-0eabb2abede1-powerpc64-linux-gnu-debug.tar.gz
ad3e7905dd361f32dd291fb31a019cf6667ad3f55ec1456d42c91cc7781c30f9  output/bitcoin-0eabb2abede1-powerpc64-linux-gnu.tar.gz
9501d5fa9e7adb01fd2cb345cd1c377e59099689f06d826e318e2ad27f4353be  output/bitcoin-0eabb2abede1-powerpc64le-linux-gnu-debug.tar.gz
679d4a19c897f0f8d2b495d637a7f67ade44396d31b8fd1de4420f73da34f58b  output/bitcoin-0eabb2abede1-powerpc64le-linux-gnu.tar.gz
b5abd52d079d14471cb4e01a5d4d5e9ba8900ebf6acde38f7f1ac8fff758735b  output/bitcoin-0eabb2abede1-riscv64-linux-gnu-debug.tar.gz
8c82531c5ca467535448031c3a1ffd323d283499e41bbc33ff0e901fd9dd80a4  output/bitcoin-0eabb2abede1-riscv64-linux-gnu.tar.gz
9047148b43a7ecf41c86998991e8a58f092ea6d2370760a2331fb6c9fc8ecf3d  output/bitcoin-0eabb2abede1-win-unsigned.tar.gz
40da6455ef84164bff7bee94524f4e582f111e0f8586309f58dac8a3fc8f273a  output/bitcoin-0eabb2abede1-win64-debug.zip
c8bb3c0370a7cad7a2544bc34d8c404e983a004671579e4094e4c7c1875da825  output/bitcoin-0eabb2abede1-win64-setup-unsigned.exe
6879fa47ddbca1e68a7f7b47e2ead0776f9fa6e189c29cc735c6e07d515ecf46  output/bitcoin-0eabb2abede1-win64.zip
8416e317567fff458ada4c76d208d6b512763261ddd6e2317b1004244b5d79f4  output/bitcoin-0eabb2abede1-x86_64-linux-gnu-debug.tar.gz
0a2443732a837c50fbd472369711b6f3ae82d5562c29a482e04f4e0637eccd78  output/bitcoin-0eabb2abede1-x86_64-linux-gnu.tar.gz
237536775e3665d7f8f52a4a6b08d5da4929c489984810e7f62f49d8a54dc4dd  output/src/bitcoin-0eabb2abede1.tar.gz

fanquake approved

fanquake commented at 1:06 AM on March 27, 2021: member

ACK 0eabb2abede1230edcc0d7b660d9635135f0b4c1

Gitian: macOS

dc96f5ba67417912ab59ff660d195404c51420eda05fdd0ce2d03cc0d7ea499a  bitcoin-0eabb2abede1-osx-unsigned.dmg
36c611853f59b6d320e13fba6b39d2fb960985405bb8f0a4616d77351c54570d  bitcoin-0eabb2abede1-osx-unsigned.tar.gz
6819103cdb7704e0b8a01ce41c4ea37f39ec9d0f47d5657b3e6166eb8f7336c6  bitcoin-0eabb2abede1-osx64.tar.gz
237536775e3665d7f8f52a4a6b08d5da4929c489984810e7f62f49d8a54dc4dd  src/bitcoin-0eabb2abede1.tar.gz
31e484f882ef163d0ec17b89b87d71398e805dad70fa5415bdf5bb62cbaa56d8  bitcoin-core-osx-22-res.yml

Windows:

8edbbac0646dd0c4b94cb2f2d74c386b312a932fad3039651a67f7067d478e6c  bitcoin-0eabb2abede1-win-unsigned.tar.gz
404f367cf8045d5a72de93e05949d1b4b0510e7434ff9fa6e87612cec5b28858  bitcoin-0eabb2abede1-win64-debug.zip
1a31f3980080e17773818b99e32bd17604e8c8439ae6fb4a9a3d078185c57269  bitcoin-0eabb2abede1-win64-setup-unsigned.exe
8865dfc71a8833e1e5376e6eab72cc431efe07314a3764a8fd48a6afb5389ca0  bitcoin-0eabb2abede1-win64.zip
237536775e3665d7f8f52a4a6b08d5da4929c489984810e7f62f49d8a54dc4dd  src/bitcoin-0eabb2abede1.tar.gz
f55513a8dfe0d035bb34970997c33d744d4f1331a7aad063556915a429d04d99  bitcoin-core-win-22-res.yml

Linux:

08a16d4149e2d19d2cf7b232249d4a04e7a161e1b6cbb9eebdce0a06a45cbd2b  bitcoin-0eabb2abede1-aarch64-linux-gnu-debug.tar.gz
aaba52b759e65ab01eff9920817db7cad893e86e2c140dfc30ac18d1013efff5  bitcoin-0eabb2abede1-aarch64-linux-gnu.tar.gz
05c13e8fe4e13bba2b07af59efac2c5ec6e659e7eef68f75fcc9e23e374465d8  bitcoin-0eabb2abede1-arm-linux-gnueabihf-debug.tar.gz
58ceab528732b6c70f28b35ec79e231d642e10ab99a295ae2bd578fc47d9affa  bitcoin-0eabb2abede1-arm-linux-gnueabihf.tar.gz
c565394cfe33940f776d996c38a578a27396a51add80507f0e9101d5501f5761  bitcoin-0eabb2abede1-powerpc64-linux-gnu-debug.tar.gz
906735ab6772e3a620521729fd45fd63ab085f01b61ecbbd7ce76ac761b8071a  bitcoin-0eabb2abede1-powerpc64-linux-gnu.tar.gz
9b17e8dba0dbe9a12ca0cb4c95c4a92ce4120c4459458abb9928bdf5ad524622  bitcoin-0eabb2abede1-powerpc64le-linux-gnu-debug.tar.gz
ec23f9eb66706e2e42bfb7c46995f466457e5099e8146d50d8e71d1aec97dbb2  bitcoin-0eabb2abede1-powerpc64le-linux-gnu.tar.gz
2c51250b9950d13d47b087a3192e85ab7024bcbd54ea3aff1dd325b9738e5613  bitcoin-0eabb2abede1-riscv64-linux-gnu-debug.tar.gz
245718723f4f20f5a527026b8d8aebbf5cfebff638f980d68ff304170d3e4dac  bitcoin-0eabb2abede1-riscv64-linux-gnu.tar.gz
52704a84fb48bac4638778f092884ca65baa450bc609ebc013434f54679d6719  bitcoin-0eabb2abede1-x86_64-linux-gnu-debug.tar.gz
992590d70807ab26bb31b18ea3c72a81df42b8ed996b3f614fb120c6d06239e0  bitcoin-0eabb2abede1-x86_64-linux-gnu.tar.gz
237536775e3665d7f8f52a4a6b08d5da4929c489984810e7f62f49d8a54dc4dd  src/bitcoin-0eabb2abede1.tar.gz
6ece7e58ef4ec1438e7e1554e4e0464e139e1a685edc1bb846b62d0527c3fd99  bitcoin-core-linux-22-res.yml

Guix:

a806ba8be503d90d11b38b1824a98fa1a572251ec845c50ea9bb5ef8035559ed  output/bitcoin-0eabb2abede1-aarch64-linux-gnu-debug.tar.gz
aa5f1b9d2da4e346fcea778d1e211ac48808959e5f8bb567476c21d8e2431709  output/bitcoin-0eabb2abede1-aarch64-linux-gnu.tar.gz
403716b91ffb6241a371dec0b09665166e3e391f2a039b669f521f13ad023ba3  output/bitcoin-0eabb2abede1-arm-linux-gnueabihf-debug.tar.gz
d9c45d1538842a685f095e846ca65ef8f9e8f6c1c43b0700b62f6594c23aa989  output/bitcoin-0eabb2abede1-arm-linux-gnueabihf.tar.gz
e20c7d84e2c4db92a9c2629de496d88950db8c088dc09040add2552bc8cd1b41  output/bitcoin-0eabb2abede1-osx-unsigned.dmg
3f9c762dd2ed2ff0be8e8d74a7b7da273a2dbfc2586c568ef7ae3292eaff06c2  output/bitcoin-0eabb2abede1-osx-unsigned.tar.gz
c348b71f93044dabd9bf69e96ecb782ab7be9a5423276d45761c3fa54c03d231  output/bitcoin-0eabb2abede1-osx64.tar.gz
254259f21072bf30e5d81e0815042991b3d63f9d2c0f3a428cf780e505c4c7fc  output/bitcoin-0eabb2abede1-powerpc64-linux-gnu-debug.tar.gz
ad3e7905dd361f32dd291fb31a019cf6667ad3f55ec1456d42c91cc7781c30f9  output/bitcoin-0eabb2abede1-powerpc64-linux-gnu.tar.gz
9501d5fa9e7adb01fd2cb345cd1c377e59099689f06d826e318e2ad27f4353be  output/bitcoin-0eabb2abede1-powerpc64le-linux-gnu-debug.tar.gz
679d4a19c897f0f8d2b495d637a7f67ade44396d31b8fd1de4420f73da34f58b  output/bitcoin-0eabb2abede1-powerpc64le-linux-gnu.tar.gz
b5abd52d079d14471cb4e01a5d4d5e9ba8900ebf6acde38f7f1ac8fff758735b  output/bitcoin-0eabb2abede1-riscv64-linux-gnu-debug.tar.gz
8c82531c5ca467535448031c3a1ffd323d283499e41bbc33ff0e901fd9dd80a4  output/bitcoin-0eabb2abede1-riscv64-linux-gnu.tar.gz
9047148b43a7ecf41c86998991e8a58f092ea6d2370760a2331fb6c9fc8ecf3d  output/bitcoin-0eabb2abede1-win-unsigned.tar.gz
40da6455ef84164bff7bee94524f4e582f111e0f8586309f58dac8a3fc8f273a  output/bitcoin-0eabb2abede1-win64-debug.zip
c8bb3c0370a7cad7a2544bc34d8c404e983a004671579e4094e4c7c1875da825  output/bitcoin-0eabb2abede1-win64-setup-unsigned.exe
6879fa47ddbca1e68a7f7b47e2ead0776f9fa6e189c29cc735c6e07d515ecf46  output/bitcoin-0eabb2abede1-win64.zip
8416e317567fff458ada4c76d208d6b512763261ddd6e2317b1004244b5d79f4  output/bitcoin-0eabb2abede1-x86_64-linux-gnu-debug.tar.gz
0a2443732a837c50fbd472369711b6f3ae82d5562c29a482e04f4e0637eccd78  output/bitcoin-0eabb2abede1-x86_64-linux-gnu.tar.gz
237536775e3665d7f8f52a4a6b08d5da4929c489984810e7f62f49d8a54dc4dd  output/src/bitcoin-0eabb2abede1.tar.gz

fanquake merged this on Mar 27, 2021
fanquake closed this on Mar 27, 2021
sidhujag referenced this in commit adcbe1adaf on Mar 27, 2021
hebasto deleted the branch on Mar 27, 2021
PastaPastaPasta referenced this in commit 579ff9f89d on Jun 27, 2021
PastaPastaPasta referenced this in commit 803786cb8b on Jun 28, 2021
PastaPastaPasta referenced this in commit 67dd77e43b on Jun 29, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels

Linked (view graph)

#16659 refactoring: Remove unused includes