hebasto
commented at 3:58 am on March 30, 2021:
member
This PR:
gets rid off unreliable AppVeyor CI
places all CI configs in one place
allows to enable functional tests in the future (using a persistent worker)
no populated vcpkg cache
populated vcpkg cache
Currently, AppVeyor builds take about 44..48 minutes.
fanquake added the label
Tests
on Mar 30, 2021
hebasto
commented at 5:47 am on March 30, 2021:
member
The warmed up vcpkg cache reduces build time by about 40 minutes.
MarcoFalke
commented at 6:16 am on March 30, 2021:
member
Still takes longer than the appveyor 38 minutes right now?
hebasto
commented at 6:17 am on March 30, 2021:
member
Still takes longer than the appveyor 38 minutes right now?
Right.
The time is spent on installing msbuild tools, that are preinstalled on AppVeyor.
DrahtBot
commented at 0:49 am on April 7, 2021:
member
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Conflicts
Reviewers, this pull request conflicts with the following ones:
#22899 (ci: Build and cache static Qt instead of downloading a pre-built one by hebasto)
#22890 (doc: Replace a link to Qt precompiled binaries with compile instructions by hebasto)
#20744 (Use std::filesystem. Remove Boost Filesystem & System by fanquake)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot added the label
Needs rebase
on Apr 11, 2021
hebasto
commented at 8:20 am on April 11, 2021:
member
The msbuild -version output within the cirrusci/windowsservercore:visualstudio2019 Cirrus image:
0Microsoft (R) Build Engine version 16.9.0+5e4b48a27 for .NET Framework
1Copyright (C) Microsoft Corporation. All rights reserved.
216.9.0.16703
sipsorcery
commented at 12:55 pm on September 2, 2021:
member
The msvc -version output within the cirrusci/windowsservercore:visualstudio2019 Cirrus image:
0Microsoft (R) Build Engine version 16.9.0+5e4b48a27 for .NET Framework
1Copyright (C) Microsoft Corporation. All rights reserved.
216.9.0.16703
Thanks for doing that. I was trying to track it down via the docker files. I already have that version of msbuild installed so will attempt the Qt build tonight (it kills my machine so overnight job).
hebasto force-pushed
on Sep 2, 2021
hebasto force-pushed
on Sep 2, 2021
hebasto
commented at 3:22 pm on September 2, 2021:
member
sipsorcery
commented at 12:23 pm on September 4, 2021:
member
ACKca9b9b9a2c0dd7ab767788be6512cfc34f1f6ee4.
Makes sense to consolidate CI platforms.
Tested that latest msbuild version 16.11.0.36601 still works with the Qt5.12.11_x64_static_vs2019_160900 binaries.
One potential pitfall will be the vcpkg caching. We had some issues with that in the past, namely whan a PR added or changed a dependency and the vcpkg couldn’t deal with it. Since then the vcpkg manifest and binary caching features have been added. They may solve this problem.
hebasto added the label
Windows
on Sep 4, 2021
fanquake
commented at 1:56 am on September 6, 2021:
member
ACK after rebase
hebasto force-pushed
on Sep 6, 2021
hebasto
commented at 2:25 am on September 6, 2021:
member
Rebased ca9b9b9a2c0dd7ab767788be6512cfc34f1f6ee4 -> da8810e4f69b43e96ddf69400bec503451a0e847 (pr21551.06 -> pr21551.07) due to the conflict with #22861.
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2024-12-23 00:13 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me