This PR:
no populated vcpkg cache |
populated vcpkg cache |
|---|---|
 |
 |
Currently, AppVeyor builds take about 44..48 minutes.
Still takes longer than the appveyor 38 minutes right now?
Right.
The time is spent on installing msbuild tools, that are preinstalled on AppVeyor.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Still takes longer than the appveyor 38 minutes right now?
Does it make sense to move this task into the DrahtBot infrastructure? Or just close it?
Still takes longer than the appveyor 38 minutes right now?
It takes 27 minutes now.
The time is spent on installing
msbuildtools, that are preinstalled on AppVeyor.
Fixed by using visualstudio2019 image.
What is the status of this? Is the intention to replace Appveyor? If not, do we need two Windows builds?
An empty PR description is not really useful.
I started this because Cirrus CI seems the most reliable CI provider, so having all configs on them seemed preferable.
I guess the status here is: Needs review?
It seems Qt5.12.11_x64_static_vs2019_16101.zip is not compatible with the msbuild in the cirrusci/windowsservercore:visualstudio2019 image:
0LINK : fatal error C1900: Il mismatch between 'P1' version '20210202' and 'P2' version '20210113' [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\build_msvc\bitcoin-qt\bitcoin-qt.vcxproj]
1LINK : fatal error LNK1257: code generation failed [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\build_msvc\bitcoin-qt\bitcoin-qt.vcxproj]
2LINK : fatal error LNK1327: failure during running link.exe [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\build_msvc\bitcoin-qt\bitcoin-qt.vcxproj]
So, I switched back to Qt5.12.10_x64_static_vs2019_1694.zip for now.
May I ask you to build Qt5.12.11_x64_static_vs2019_1694.zip – the recent Qt 5.12.11 with an older msbuild?
May I ask you to build
Qt5.12.11_x64_static_vs2019_1694.zip– the recent Qt 5.12.11 with an oldermsbuild?
Sure, any idea where I can find the software versions installed on the cirrusci image you’re using?
May I ask you to build
Qt5.12.11_x64_static_vs2019_1694.zip– the recent Qt 5.12.11 with an oldermsbuild?Sure, any idea where I can find the software versions installed on the cirrusci image you’re using?
The msbuild -version output within the cirrusci/windowsservercore:visualstudio2019 Cirrus image:
0Microsoft (R) Build Engine version 16.9.0+5e4b48a27 for .NET Framework
1Copyright (C) Microsoft Corporation. All rights reserved.
216.9.0.16703
The
msvc -versionoutput within thecirrusci/windowsservercore:visualstudio2019Cirrus image:0Microsoft (R) Build Engine version 16.9.0+5e4b48a27 for .NET Framework 1Copyright (C) Microsoft Corporation. All rights reserved. 216.9.0.16703
Thanks for doing that. I was trying to track it down via the docker files. I already have that version of msbuild installed so will attempt the Qt build tonight (it kills my machine so overnight job).
To make debugging a bit easier in the future, I’ve added the following script:
0 build_environment_script:
1 - choco list --localonly
2 - msbuild -version
@MarcoFalke @fanquake @sipsorcery
This PR is ready for reviewing now :tiger2:
ACK ca9b9b9a2c0dd7ab767788be6512cfc34f1f6ee4.
Makes sense to consolidate CI platforms.
Tested that latest msbuild version 16.11.0.36601 still works with the Qt5.12.11_x64_static_vs2019_160900 binaries.
One potential pitfall will be the vcpkg caching. We had some issues with that in the past, namely whan a PR added or changed a dependency and the vcpkg couldn’t deal with it. Since then the vcpkg manifest and binary caching features have been added. They may solve this problem.
72@@ -89,6 +73,64 @@ task:
73 env:
74 << : *CIRRUS_EPHEMERAL_WORKER_TEMPLATE_ENV
75
76+task:
77+ name: "Win64 [unit tests, no functional tests] [msvc]"
78+ windows_container:
79+ cpu: 8
With cpu: 4:
And the total task time with a populated vcpkg cache:
72@@ -89,6 +73,64 @@ task:
73 env:
74 << : *CIRRUS_EPHEMERAL_WORKER_TEMPLATE_ENV
75
76+task:
77+ name: "Win64 [unit tests, no functional tests] [msvc]"
0 name: "Win64 native [unit tests, no functional tests] [msvc]"
77+ name: "Win64 [unit tests, no functional tests] [msvc]"
78+ windows_container:
79+ cpu: 8
80+ memory: 7424Mi
81+ image: cirrusci/windowsservercore:visualstudio2019
82+ << : *CREDITS_TEMPLATE
BASE_TEMPLATE to skip
Updated da8810e4f69b43e96ddf69400bec503451a0e847 -> 97292b19140db32c6d85d63b70382e7bf60a55c4 (pr21551.07 -> pr21551.08, diff):
Another (final?) review? :smile:
96+ IgnoreWarnIntDirInTempDetected: 'true'
97+ merge_script:
98+ - git config --global user.email "ci@ci.ci"
99+ - git config --global user.name "ci"
100+ - git config core.filemode false
101+ - git reset --hard
136+ build_script:
137+ - cd $env:CIRRUS_WORKING_DIR
138+ - python build_msvc\msvc-autogen.py
139+ - msbuild build_msvc\bitcoin.sln -property:Configuration=Release -maxCpuCount -verbosity:minimal -noLogo
140+ unit_tests_script:
141+ - src\test_bitcoin.exe
-l test_suite?