build, qt: Simplifies checks for `-fPIE` and `-fPIC` compatibility #21570

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:210402-pie changing 1 files +2 −22
  1. hebasto commented at 4:42 AM on April 2, 2021: member

    As noted in bitcoin/bitcoin#6978:

    When Qt discovered this issue (somewhere around 5.4), they added the check in qconfig.h so that compilation would fail in this QT_REDUCE_RELOCATIONS+-fPIE case.

    To be precise, since Qt 5.4.2 the qglobal.h header implements the correct checks for -fPIE and -fPIC compatibility:

    As now we require GCC 8.1+ and Qt 5.11.3+, it is safe to rely on Qt's checks. The removed lines

            #if defined(QT_REDUCE_RELOCATIONS)
        choke
        #endif

    are redundant now.

    One of the easiest way to test this PR is configure.log comparison.

    No behavior change.

  2. fanquake added the label Build system on Apr 2, 2021
  3. Ouch555 commented at 5:31 AM on April 2, 2021: none

    .

  4. hebasto commented at 6:42 AM on April 2, 2021: member

    Gitian builds:

    • Linux
    Generating report
7530556602ecb0e181d304a0f6f95719f10bf9460e9edff6ca15d425932e0387  bitcoin-f88a7051190e-aarch64-linux-gnu-debug.tar.gz
9857410c78dcc03f9db59ffe6b743a8607fe5a9f120607c97a4aed08462cdc1d  bitcoin-f88a7051190e-aarch64-linux-gnu.tar.gz
b50ca420fb863591b39dab5ab27b9e707d07d840c7ca782549c9a9d7d861f1a4  bitcoin-f88a7051190e-arm-linux-gnueabihf-debug.tar.gz
86d293038f91715e0f23ee54d7e79a244c7bfa80c014131d0018929a6865b0d5  bitcoin-f88a7051190e-arm-linux-gnueabihf.tar.gz
d85003847db80baa75ef949fed97f606d2068e8dfeb6be48820f847060f646f9  bitcoin-f88a7051190e-powerpc64-linux-gnu-debug.tar.gz
bcc33c04c67d44d485fef7be756c32f2270de697ab8f9e4a10349919d152ea2b  bitcoin-f88a7051190e-powerpc64-linux-gnu.tar.gz
b08b9716c3dccefca43a853ca4dcedd07432e9ba407bd03e58a429abc0c1b1bc  bitcoin-f88a7051190e-powerpc64le-linux-gnu-debug.tar.gz
a66557e638f79f752cb2c7a75923a9418947c88e93c495a46b43e5eacd5dbf1b  bitcoin-f88a7051190e-powerpc64le-linux-gnu.tar.gz
d56d2fbaa8a376f90663eb343ebc4a49841e598ee9b37bd08f8752b0f7f3ad2b  bitcoin-f88a7051190e-riscv64-linux-gnu-debug.tar.gz
202f4f0596856f8f37067ab3cc1179a16fb2ff8c5b3e2a39b2ec2bb28ca91df2  bitcoin-f88a7051190e-riscv64-linux-gnu.tar.gz
5749d9135ef69733a6fcb04e91727f3dfe6346047b45315b4e46264ad1c1706a  bitcoin-f88a7051190e-x86_64-linux-gnu-debug.tar.gz
c336beefa1d25100852a73d46bf6e194d2c3c6ace23ee4d48cd5456d2437d80b  bitcoin-f88a7051190e-x86_64-linux-gnu.tar.gz
d119be26184a03a1aa50c531495d5dfe5a078f989738b049d20d44a4ed4301e6  src/bitcoin-f88a7051190e.tar.gz
2e055c180833ae998606b3b1fe30a2a373b850e79f14e952b055e24c21c2b8f4  bitcoin-core-linux-22-res.yml
Done.
    • Windows
    Generating report
3f9bfbbcae64a5603dc97074004f6510643d23253ce612a6b75409fa9eacee81  bitcoin-f88a7051190e-win-unsigned.tar.gz
3d40f74779723f4b41d8577263db7ae8d8e32c7fc0923face79c8c7286f65f15  bitcoin-f88a7051190e-win64-debug.zip
268c45d21a6b05bf2f50c0b7ae415067414c2a9e4e98cb100beddb04d4b15f14  bitcoin-f88a7051190e-win64-setup-unsigned.exe
50e4d7790162fe33bb8297a548a70e62aa77310128e2a779eadd707fb2b8cb22  bitcoin-f88a7051190e-win64.zip
d119be26184a03a1aa50c531495d5dfe5a078f989738b049d20d44a4ed4301e6  src/bitcoin-f88a7051190e.tar.gz
eeab389bf1a4740acb64c1d8f4972b5e472fa05a035404c2865bc44c13a1380c  bitcoin-core-win-22-res.yml
Done.
    • macOS
    Generating report
38a9668171326481720e9979986916dfc3dcdc285d36b3f5fd7c36bdbd4f9992  bitcoin-f88a7051190e-osx-unsigned.dmg
fbb95689099f973b00d5c481a438dccfad8616fac3ce2fb4a272471e46189d2a  bitcoin-f88a7051190e-osx-unsigned.tar.gz
60f630d5feffce48891a0d85b04d430ad3930f664e79fca1e8ae7a6c70ce914e  bitcoin-f88a7051190e-osx64.tar.gz
d119be26184a03a1aa50c531495d5dfe5a078f989738b049d20d44a4ed4301e6  src/bitcoin-f88a7051190e.tar.gz
903a1290b88f518163b951767428d66823754668ea493e311cc961da87c7cd84  bitcoin-core-osx-22-res.yml
Done.
  5. hebasto marked this as ready for review on Apr 2, 2021
  6. hebasto commented at 8:37 AM on April 2, 2021: member

    Guix builds:

    $ find output -type f -name *$(git rev-parse --short HEAD)*.* -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
5362e85820b3ec4bfae9d5d1de9e79bd8f96ab373ebc96a097b21b6caf9efcf4  output/bitcoin-f88a7051190e-aarch64-linux-gnu-debug.tar.gz
659285ebfa690d584337c4ce45cf9056a2902bf78fb833d8ee12858170960412  output/bitcoin-f88a7051190e-aarch64-linux-gnu.tar.gz
3c2a404937d99c0890cad9097998397e8765e66f8efa0552b2374623ce645fc9  output/bitcoin-f88a7051190e-arm-linux-gnueabihf-debug.tar.gz
2ce15e053ca6c22f1683590ca262d4e8a0e99161293b9981ce4f7d8b4da97669  output/bitcoin-f88a7051190e-arm-linux-gnueabihf.tar.gz
5eb5379af5d01cbf5009b0c451e3c7f068c63d781c6f1d3260c378b56bade136  output/bitcoin-f88a7051190e-osx-unsigned.dmg
4bcd48bf7bd84137106c78995b730d254d012acec8e181b17104ae445b820f1e  output/bitcoin-f88a7051190e-osx-unsigned.tar.gz
1f97d02cd897294f1ffb7d12efb227aced384c7ceb8c4be5c83f54745dd1796f  output/bitcoin-f88a7051190e-osx64.tar.gz
a80932419d2d3d240297f164e02128e2e8e954a7eb0eebbaf05610935f105d7d  output/bitcoin-f88a7051190e-powerpc64-linux-gnu-debug.tar.gz
f6b0d20189511c73e17a5c80626d2954680ed75123c9bfffb58040a4363e6323  output/bitcoin-f88a7051190e-powerpc64-linux-gnu.tar.gz
efdfc396a7fc408a2fcd61a8fff1b68c12b56faf67851712f0f04e90c20da5e6  output/bitcoin-f88a7051190e-powerpc64le-linux-gnu-debug.tar.gz
a1ddab4d7f3a8ec38764830799f6ab2cab0073d60ce836298aadb21c0c3d3a20  output/bitcoin-f88a7051190e-powerpc64le-linux-gnu.tar.gz
1f4ec1dea68cd39e2ae08705c9fda5607a4b49ee53b01f3ef9e9a093f177dad5  output/bitcoin-f88a7051190e-riscv64-linux-gnu-debug.tar.gz
96430dd3e8e70e52502983c3b584c80f7cd4f8e67937fb10ef7a3fc47f76e5ab  output/bitcoin-f88a7051190e-riscv64-linux-gnu.tar.gz
22d908d26e5746a6348dadb04502470d53554697a78df12cc461b2a27f0b7b5f  output/bitcoin-f88a7051190e-win-unsigned.tar.gz
b0f1659967d03ab7099429c4d9e5a4520b3796906c1b3b60e1509fc8b4f14472  output/bitcoin-f88a7051190e-win64-debug.zip
20398fd8d45a49c34591d08bc1c32166d2c0d8afee90cbbd8220296ca5c1f7c0  output/bitcoin-f88a7051190e-win64-setup-unsigned.exe
0eee05248ddd27f138ece1eb57497e82bb5fcaeb95970513a98fca9ad37b3360  output/bitcoin-f88a7051190e-win64.zip
02161a94c043dc7959b88d2b84448d5787017ce40ebb76a703005940b9212f3a  output/bitcoin-f88a7051190e-x86_64-linux-gnu-debug.tar.gz
adfde597947b475e4c3aa6be6284c9c8f04d602537b8cb121582ae8d741b680b  output/bitcoin-f88a7051190e-x86_64-linux-gnu.tar.gz
d119be26184a03a1aa50c531495d5dfe5a078f989738b049d20d44a4ed4301e6  output/src/bitcoin-f88a7051190e.tar.gz
  7. jarolrod commented at 2:02 AM on April 12, 2021: member

    Contributing GUIX hashes, mine match @hebasto

    find output -type f -name *$(git rev-parse --short HEAD)*.* -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum

5362e85820b3ec4bfae9d5d1de9e79bd8f96ab373ebc96a097b21b6caf9efcf4  output/bitcoin-f88a7051190e-aarch64-linux-gnu-debug.tar.gz
659285ebfa690d584337c4ce45cf9056a2902bf78fb833d8ee12858170960412  output/bitcoin-f88a7051190e-aarch64-linux-gnu.tar.gz
3c2a404937d99c0890cad9097998397e8765e66f8efa0552b2374623ce645fc9  output/bitcoin-f88a7051190e-arm-linux-gnueabihf-debug.tar.gz
2ce15e053ca6c22f1683590ca262d4e8a0e99161293b9981ce4f7d8b4da97669  output/bitcoin-f88a7051190e-arm-linux-gnueabihf.tar.gz
5eb5379af5d01cbf5009b0c451e3c7f068c63d781c6f1d3260c378b56bade136  output/bitcoin-f88a7051190e-osx-unsigned.dmg
4bcd48bf7bd84137106c78995b730d254d012acec8e181b17104ae445b820f1e  output/bitcoin-f88a7051190e-osx-unsigned.tar.gz
1f97d02cd897294f1ffb7d12efb227aced384c7ceb8c4be5c83f54745dd1796f  output/bitcoin-f88a7051190e-osx64.tar.gz
a80932419d2d3d240297f164e02128e2e8e954a7eb0eebbaf05610935f105d7d  output/bitcoin-f88a7051190e-powerpc64-linux-gnu-debug.tar.gz
f6b0d20189511c73e17a5c80626d2954680ed75123c9bfffb58040a4363e6323  output/bitcoin-f88a7051190e-powerpc64-linux-gnu.tar.gz
efdfc396a7fc408a2fcd61a8fff1b68c12b56faf67851712f0f04e90c20da5e6  output/bitcoin-f88a7051190e-powerpc64le-linux-gnu-debug.tar.gz
a1ddab4d7f3a8ec38764830799f6ab2cab0073d60ce836298aadb21c0c3d3a20  output/bitcoin-f88a7051190e-powerpc64le-linux-gnu.tar.gz
1f4ec1dea68cd39e2ae08705c9fda5607a4b49ee53b01f3ef9e9a093f177dad5  output/bitcoin-f88a7051190e-riscv64-linux-gnu-debug.tar.gz
96430dd3e8e70e52502983c3b584c80f7cd4f8e67937fb10ef7a3fc47f76e5ab  output/bitcoin-f88a7051190e-riscv64-linux-gnu.tar.gz
22d908d26e5746a6348dadb04502470d53554697a78df12cc461b2a27f0b7b5f  output/bitcoin-f88a7051190e-win-unsigned.tar.gz
b0f1659967d03ab7099429c4d9e5a4520b3796906c1b3b60e1509fc8b4f14472  output/bitcoin-f88a7051190e-win64-debug.zip
20398fd8d45a49c34591d08bc1c32166d2c0d8afee90cbbd8220296ca5c1f7c0  output/bitcoin-f88a7051190e-win64-setup-unsigned.exe
0eee05248ddd27f138ece1eb57497e82bb5fcaeb95970513a98fca9ad37b3360  output/bitcoin-f88a7051190e-win64.zip
02161a94c043dc7959b88d2b84448d5787017ce40ebb76a703005940b9212f3a  output/bitcoin-f88a7051190e-x86_64-linux-gnu-debug.tar.gz
adfde597947b475e4c3aa6be6284c9c8f04d602537b8cb121582ae8d741b680b  output/bitcoin-f88a7051190e-x86_64-linux-gnu.tar.gz
d119be26184a03a1aa50c531495d5dfe5a078f989738b049d20d44a4ed4301e6  output/src/bitcoin-f88a7051190e.tar.gz
  8. fanquake commented at 4:33 AM on April 14, 2021: member

    All job is done in the global/qglobal.h header.

    I think you need to elaborate here. For example, the PR description (and commit message) could include:

    • What is being changed, and why is it equivalent to previous checks.
    • When did this change?
      • Qt 5.12 isn't the only version of Qt we build against, and our minimum supported is still 5.9.x.
      • If the version of Qt being built against is irrelevant to this change, why is that the case?
      • Link to relevant upstream changes if applicable.

    No behavior change.

    • How did you verify / how should reviewers verify that this is a no-op?
    • Given that this is a change to a configure check, the binaries produced before and after this change should be identical. You could show that to be the case, maybe using build-for-compare.py.

    Adding more information not only means that more contributors can, or will be more likely to review, but any security related change should be better summarized than "some changes happened in a dependency header".

  9. DrahtBot commented at 4:24 PM on November 11, 2021: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

  10. DrahtBot added the label Needs rebase on Nov 13, 2021
  11. fanquake commented at 3:38 AM on December 30, 2021: member

    What is the status of this PR?

  12. hebasto force-pushed on Jan 2, 2022
  13. hebasto commented at 3:37 PM on January 2, 2022: member

    The PR description has been updated aiming to address @fanquake's #21570 (comment).

  14. hebasto renamed this:
    build, qt: Simplifies checks for -fPIE and -fPIC
    build, qt: Simplifies checks for `QT_REDUCE_RELOCATIONS`
    on Jan 2, 2022
  15. DrahtBot removed the label Needs rebase on Jan 2, 2022
  16. hebasto commented at 8:38 AM on January 3, 2022: member

    Guix builds:

    $ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
c0c9c71f1f675eb8949ad0df660e5043d038f2f6963381911e6ddd973017ff0e  guix-build-a308515cbf2d/output/aarch64-linux-gnu/SHA256SUMS.part
b107554998b49b71e235f32f70b85037efbffd629ec709e776ebf5761a3ec45a  guix-build-a308515cbf2d/output/aarch64-linux-gnu/bitcoin-a308515cbf2d-aarch64-linux-gnu-debug.tar.gz
b58547bda6f7aac16ec64474098a8fbe005aceea26745df52adb51bb28011ae1  guix-build-a308515cbf2d/output/aarch64-linux-gnu/bitcoin-a308515cbf2d-aarch64-linux-gnu.tar.gz
3281acd564f9baadc8fd77704d9dc2ef26f2757abd7deeafd2f97654c7306143  guix-build-a308515cbf2d/output/arm-linux-gnueabihf/SHA256SUMS.part
b70315321048bd6e95b4375ef0e1eee552a803de430a48e3d10f38b3611e8cf8  guix-build-a308515cbf2d/output/arm-linux-gnueabihf/bitcoin-a308515cbf2d-arm-linux-gnueabihf-debug.tar.gz
945730db1b6ae51e6244e82389c9ae2f8c1cf5307806d017098bd1ab1885c734  guix-build-a308515cbf2d/output/arm-linux-gnueabihf/bitcoin-a308515cbf2d-arm-linux-gnueabihf.tar.gz
381a0c52137fbda46ecd82e88d94cfa4589fa4ccaf12e734e135797292a32e12  guix-build-a308515cbf2d/output/dist-archive/bitcoin-a308515cbf2d.tar.gz
14aceef2f5635e5d667d374dce5588ff0b006b0c22970dc78a1e9b080fe4f8cb  guix-build-a308515cbf2d/output/powerpc64-linux-gnu/SHA256SUMS.part
77e141676b5712439aded34ed6ea86f63f27ea4156d649b65b7ea751a81f5094  guix-build-a308515cbf2d/output/powerpc64-linux-gnu/bitcoin-a308515cbf2d-powerpc64-linux-gnu-debug.tar.gz
60600018a2194053937b8d62b4bf879900ad560bc8a9cdf269c052c3ca48ae1c  guix-build-a308515cbf2d/output/powerpc64-linux-gnu/bitcoin-a308515cbf2d-powerpc64-linux-gnu.tar.gz
3f48ece1ac1e90cded374b3e4aa75bcea6d546981a870c81525be37821575789  guix-build-a308515cbf2d/output/powerpc64le-linux-gnu/SHA256SUMS.part
9509316545fac2f9638d96d33c8809bead93e521a7494b756ee9224562a47baf  guix-build-a308515cbf2d/output/powerpc64le-linux-gnu/bitcoin-a308515cbf2d-powerpc64le-linux-gnu-debug.tar.gz
4586dc7467ab70652e3d3e51efd8cd751e476eef13105b5de6dc9b71004e2ee1  guix-build-a308515cbf2d/output/powerpc64le-linux-gnu/bitcoin-a308515cbf2d-powerpc64le-linux-gnu.tar.gz
5377056e9b4efb5558b10a71bd3ecf58d5ff07d5d939b218640d66d8f8040166  guix-build-a308515cbf2d/output/riscv64-linux-gnu/SHA256SUMS.part
7fb74dbaa06f342cc4d4d3d4b8ad4a57195cd2218bfba4fc49092fc93f8ad93f  guix-build-a308515cbf2d/output/riscv64-linux-gnu/bitcoin-a308515cbf2d-riscv64-linux-gnu-debug.tar.gz
31f182ba2e470fb37ccc3d0bafbee9e52207fa429f6ad2f45bdb2ebb0705ba4e  guix-build-a308515cbf2d/output/riscv64-linux-gnu/bitcoin-a308515cbf2d-riscv64-linux-gnu.tar.gz
5fd7bdb3e0a9bae79d19972b0b8843677e1a7c589df883d3350c350fd4f96e73  guix-build-a308515cbf2d/output/x86_64-apple-darwin/SHA256SUMS.part
b801dbe097f3d86ece0a84577b23a13691b789f5c6328e808d3e01c022ed6873  guix-build-a308515cbf2d/output/x86_64-apple-darwin/bitcoin-a308515cbf2d-osx-unsigned.dmg
9e24bcde6b4c7beb2a2cefe664edea3babcc60a3f8e62b09615051148d1c6c53  guix-build-a308515cbf2d/output/x86_64-apple-darwin/bitcoin-a308515cbf2d-osx-unsigned.tar.gz
ddb315806046736e1919beef1d305be711a9ac839c902c8824bc3bf3741fb56b  guix-build-a308515cbf2d/output/x86_64-apple-darwin/bitcoin-a308515cbf2d-osx64.tar.gz
8ebd5383a38b1c29132fe160198a2339f5a66840dd9c12f28eb860959ed3cd91  guix-build-a308515cbf2d/output/x86_64-linux-gnu/SHA256SUMS.part
dc49f6d6d1d3788129e18a604ba82de216161b4de906e48a68a281b9ffae51a2  guix-build-a308515cbf2d/output/x86_64-linux-gnu/bitcoin-a308515cbf2d-x86_64-linux-gnu-debug.tar.gz
3744496206afdad90b8becffb14d74da0fef85a3ffa2d9df28ffbe76ff9b3a91  guix-build-a308515cbf2d/output/x86_64-linux-gnu/bitcoin-a308515cbf2d-x86_64-linux-gnu.tar.gz
424219c6ce6b90e97e5139f68f992f6bbf404e14361c13ba120f0d6a43bab9bb  guix-build-a308515cbf2d/output/x86_64-w64-mingw32/SHA256SUMS.part
8bd65cdc63351a95ef1b58303e5d61966883fa9a45fd72465daddf1e95301682  guix-build-a308515cbf2d/output/x86_64-w64-mingw32/bitcoin-a308515cbf2d-win-unsigned.tar.gz
a7b4debc0cff53422687e305129a3e30f565e315dc3aa1c70bc34681986c6bd1  guix-build-a308515cbf2d/output/x86_64-w64-mingw32/bitcoin-a308515cbf2d-win64-debug.zip
cb000927d891c63e0153227bd64b5e810835fafe04d7895f55e6053464457377  guix-build-a308515cbf2d/output/x86_64-w64-mingw32/bitcoin-a308515cbf2d-win64-setup-unsigned.exe
9ce1c378fb3ea031d4aca6aa3267be0a9189a608d749d308cfb101ed7dd7e143  guix-build-a308515cbf2d/output/x86_64-w64-mingw32/bitcoin-a308515cbf2d-win64.zip
  17. DrahtBot added the label Needs rebase on Apr 5, 2022
  18. hebasto renamed this:
    build, qt: Simplifies checks for `QT_REDUCE_RELOCATIONS`
    build, qt: Simplifies checks for -fPIE and -fPIC compatibility
    on Apr 16, 2022
  19. build, qt: Simplifies checks for -fPIE and -fPIC compatibility
    The checks in global/qglobal.h header are correct since Qt 5.4.2.
    bbd09b1773
  20. hebasto force-pushed on Apr 16, 2022
  21. hebasto commented at 8:24 AM on April 16, 2022: member

    Rebased a308515cbf2d9c8eb086893ea7562894716b10f6 -> bbd09b1773a7d382b20d649fb1a6344a623e87c8 (pr21570.02 -> pr21570.03) due to the conflict with #24391.

  22. hebasto renamed this:
    build, qt: Simplifies checks for -fPIE and -fPIC compatibility
    build, qt: Simplifies checks for `-fPIE` and `-fPIC` compatibility
    on Apr 16, 2022
  23. hebasto commented at 8:44 AM on April 16, 2022: member

    @fanquake @jarolrod @laanwj @luke-jr

    The PR description has been reworked.

  24. DrahtBot removed the label Needs rebase on Apr 16, 2022
  25. hebasto commented at 3:58 PM on April 16, 2022: member

    Guix builds on x86_64:

    $ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
c31182b895ff9ab65c9b05b1062e00ddc3d6b051a8d794d2afb1b942e4dc0bca  guix-build-bbd09b1773a7/output/aarch64-linux-gnu/SHA256SUMS.part
07f958077ff9a810a38f1963d327205b628b0f68ccedef56e790753321ba79ed  guix-build-bbd09b1773a7/output/aarch64-linux-gnu/bitcoin-bbd09b1773a7-aarch64-linux-gnu-debug.tar.gz
5bc9c681a9dda19c22287ed444f0fbbe3f9c652a99d69fb6144e0e176ac17a3e  guix-build-bbd09b1773a7/output/aarch64-linux-gnu/bitcoin-bbd09b1773a7-aarch64-linux-gnu.tar.gz
1c4c0dd34fc6da1c2e872c346d1ab22acbd9efe9170425cab07ad622530c3b01  guix-build-bbd09b1773a7/output/arm-linux-gnueabihf/SHA256SUMS.part
9c7cad68e66f2e32506a8e4b79ad912f39fe20a803b1d98d5d61705b976e3606  guix-build-bbd09b1773a7/output/arm-linux-gnueabihf/bitcoin-bbd09b1773a7-arm-linux-gnueabihf-debug.tar.gz
e9ad63cddd5a22aa1175d2f07ab71208fb8a5d6b23f69b26db2cecf421770f64  guix-build-bbd09b1773a7/output/arm-linux-gnueabihf/bitcoin-bbd09b1773a7-arm-linux-gnueabihf.tar.gz
a27478f4706158488499fe9f5058bb489ef992a1719a77c8cc60e97809288e9d  guix-build-bbd09b1773a7/output/arm64-apple-darwin/SHA256SUMS.part
b62447e2e2dabc10c7b3f6eb3f5acc7f3df277f9828a49221a1fd2f7ed16b995  guix-build-bbd09b1773a7/output/arm64-apple-darwin/bitcoin-bbd09b1773a7-arm64-apple-darwin-unsigned.dmg
11915a145be1449544a8155b95ffac6efa57a6e14ee50609582cdf3c4478febc  guix-build-bbd09b1773a7/output/arm64-apple-darwin/bitcoin-bbd09b1773a7-arm64-apple-darwin-unsigned.tar.gz
3e9b548858b9aaa0e9075ff8bf3cb765d0ca95e51ffb97112680f382adbda6ab  guix-build-bbd09b1773a7/output/arm64-apple-darwin/bitcoin-bbd09b1773a7-arm64-apple-darwin.tar.gz
19a5c6aa4081cad18173232984eb183b97d8a2c8b25beba965934e3500db5f02  guix-build-bbd09b1773a7/output/dist-archive/bitcoin-bbd09b1773a7.tar.gz
9b1288b1c7cdf6fc74a9fe99f7db7a07ca52048fed408e53c869b5215477a61c  guix-build-bbd09b1773a7/output/powerpc64-linux-gnu/SHA256SUMS.part
1fc1d3dcbb19c95c7998030e4611cd8e3a244e03635582b9746c787161ce12b3  guix-build-bbd09b1773a7/output/powerpc64-linux-gnu/bitcoin-bbd09b1773a7-powerpc64-linux-gnu-debug.tar.gz
abb41c10f06ddae5d0489ac3262f67a5b37286a9134991a783b5c3348dcec8ac  guix-build-bbd09b1773a7/output/powerpc64-linux-gnu/bitcoin-bbd09b1773a7-powerpc64-linux-gnu.tar.gz
dbed5ae4edbca37a6f75b2a35754c933f16a267ea5b155ef8ae7d64ac682bdd0  guix-build-bbd09b1773a7/output/powerpc64le-linux-gnu/SHA256SUMS.part
8054559dcece9977b9da2bd8009db0ca6a824ddf03680afd5b369121d4b689f5  guix-build-bbd09b1773a7/output/powerpc64le-linux-gnu/bitcoin-bbd09b1773a7-powerpc64le-linux-gnu-debug.tar.gz
91e6b6f8574074ef44689d357f303377574c74cbacd94aedb744626e8d3bb466  guix-build-bbd09b1773a7/output/powerpc64le-linux-gnu/bitcoin-bbd09b1773a7-powerpc64le-linux-gnu.tar.gz
7433849202360ba40bce45c64eedf91ea8a77bcd30f9a9993536f375c635f2aa  guix-build-bbd09b1773a7/output/riscv64-linux-gnu/SHA256SUMS.part
41a0fdcfbb004f08428314354c2414c4b286630db5c2eca57b538a2046426002  guix-build-bbd09b1773a7/output/riscv64-linux-gnu/bitcoin-bbd09b1773a7-riscv64-linux-gnu-debug.tar.gz
5bb0391566c8a5ddbe0f13e0f7d427f97214106eaa4da6958c52feb9a77a72c2  guix-build-bbd09b1773a7/output/riscv64-linux-gnu/bitcoin-bbd09b1773a7-riscv64-linux-gnu.tar.gz
f85257d49c5792f1d46052914a26a92d366d3b494c378d392ec9ccbd7863a231  guix-build-bbd09b1773a7/output/x86_64-apple-darwin/SHA256SUMS.part
313dcc2afa7eec4d70924763d28d465abddccf664b9aaed528d626b14ea29008  guix-build-bbd09b1773a7/output/x86_64-apple-darwin/bitcoin-bbd09b1773a7-x86_64-apple-darwin-unsigned.dmg
d83d7878c1d439b6143b7ace08d2ef8d2f5bc23a43419d02513ef6f69a1b7874  guix-build-bbd09b1773a7/output/x86_64-apple-darwin/bitcoin-bbd09b1773a7-x86_64-apple-darwin-unsigned.tar.gz
a5a55d57ca8499d323687edaf5fa3afeca45139ff9260ca10ad50ae8a2b3ed76  guix-build-bbd09b1773a7/output/x86_64-apple-darwin/bitcoin-bbd09b1773a7-x86_64-apple-darwin.tar.gz
0d14761c7a12f80b2bffa72ee76c87ebd3d636caf599a8e9b592599005e9eb00  guix-build-bbd09b1773a7/output/x86_64-linux-gnu/SHA256SUMS.part
578d43af101196dadd53e7c0544ead4e9646db91fbf9fa42c43bcd053c64bd12  guix-build-bbd09b1773a7/output/x86_64-linux-gnu/bitcoin-bbd09b1773a7-x86_64-linux-gnu-debug.tar.gz
0f78dfd0c51d5aafa243e73d4557eb4d2fe457910c24fecd664d5f2e2d5d63c5  guix-build-bbd09b1773a7/output/x86_64-linux-gnu/bitcoin-bbd09b1773a7-x86_64-linux-gnu.tar.gz
4e2aeed355c615daa0bc1d6e1fd5ff5c9c7d2ecb81d6d19fc464a7c827cbc3e1  guix-build-bbd09b1773a7/output/x86_64-w64-mingw32/SHA256SUMS.part
91dcc3d4fe4af6561ca819dc9b19e55266f5788fc817da1d5f4181a259a729ae  guix-build-bbd09b1773a7/output/x86_64-w64-mingw32/bitcoin-bbd09b1773a7-win64-debug.zip
bd1aa4be050249e1d054f7f98e8e8d33576c908466acad5d5080d20ba96c79be  guix-build-bbd09b1773a7/output/x86_64-w64-mingw32/bitcoin-bbd09b1773a7-win64-setup-unsigned.exe
a52d34a080c1c18e0c6ca3ea2d2b6726adba04af12c2d04aeb1f04de90f5e9c7  guix-build-bbd09b1773a7/output/x86_64-w64-mingw32/bitcoin-bbd09b1773a7-win64-unsigned.tar.gz
45b793e490cd79cc22f82a0da47dcfe80e1d4e3e69e0a29e77bfed39e09c1295  guix-build-bbd09b1773a7/output/x86_64-w64-mingw32/bitcoin-bbd09b1773a7-win64.zip
  26. jarolrod commented at 4:57 AM on April 19, 2022: member

    Guix hashes x86

    c31182b895ff9ab65c9b05b1062e00ddc3d6b051a8d794d2afb1b942e4dc0bca  guix-build-bbd09b1773a7/output/aarch64-linux-gnu/SHA256SUMS.part
07f958077ff9a810a38f1963d327205b628b0f68ccedef56e790753321ba79ed  guix-build-bbd09b1773a7/output/aarch64-linux-gnu/bitcoin-bbd09b1773a7-aarch64-linux-gnu-debug.tar.gz
5bc9c681a9dda19c22287ed444f0fbbe3f9c652a99d69fb6144e0e176ac17a3e  guix-build-bbd09b1773a7/output/aarch64-linux-gnu/bitcoin-bbd09b1773a7-aarch64-linux-gnu.tar.gz
1c4c0dd34fc6da1c2e872c346d1ab22acbd9efe9170425cab07ad622530c3b01  guix-build-bbd09b1773a7/output/arm-linux-gnueabihf/SHA256SUMS.part
9c7cad68e66f2e32506a8e4b79ad912f39fe20a803b1d98d5d61705b976e3606  guix-build-bbd09b1773a7/output/arm-linux-gnueabihf/bitcoin-bbd09b1773a7-arm-linux-gnueabihf-debug.tar.gz
e9ad63cddd5a22aa1175d2f07ab71208fb8a5d6b23f69b26db2cecf421770f64  guix-build-bbd09b1773a7/output/arm-linux-gnueabihf/bitcoin-bbd09b1773a7-arm-linux-gnueabihf.tar.gz
a27478f4706158488499fe9f5058bb489ef992a1719a77c8cc60e97809288e9d  guix-build-bbd09b1773a7/output/arm64-apple-darwin/SHA256SUMS.part
b62447e2e2dabc10c7b3f6eb3f5acc7f3df277f9828a49221a1fd2f7ed16b995  guix-build-bbd09b1773a7/output/arm64-apple-darwin/bitcoin-bbd09b1773a7-arm64-apple-darwin-unsigned.dmg
11915a145be1449544a8155b95ffac6efa57a6e14ee50609582cdf3c4478febc  guix-build-bbd09b1773a7/output/arm64-apple-darwin/bitcoin-bbd09b1773a7-arm64-apple-darwin-unsigned.tar.gz
3e9b548858b9aaa0e9075ff8bf3cb765d0ca95e51ffb97112680f382adbda6ab  guix-build-bbd09b1773a7/output/arm64-apple-darwin/bitcoin-bbd09b1773a7-arm64-apple-darwin.tar.gz
19a5c6aa4081cad18173232984eb183b97d8a2c8b25beba965934e3500db5f02  guix-build-bbd09b1773a7/output/dist-archive/bitcoin-bbd09b1773a7.tar.gz
9b1288b1c7cdf6fc74a9fe99f7db7a07ca52048fed408e53c869b5215477a61c  guix-build-bbd09b1773a7/output/powerpc64-linux-gnu/SHA256SUMS.part
1fc1d3dcbb19c95c7998030e4611cd8e3a244e03635582b9746c787161ce12b3  guix-build-bbd09b1773a7/output/powerpc64-linux-gnu/bitcoin-bbd09b1773a7-powerpc64-linux-gnu-debug.tar.gz
abb41c10f06ddae5d0489ac3262f67a5b37286a9134991a783b5c3348dcec8ac  guix-build-bbd09b1773a7/output/powerpc64-linux-gnu/bitcoin-bbd09b1773a7-powerpc64-linux-gnu.tar.gz
dbed5ae4edbca37a6f75b2a35754c933f16a267ea5b155ef8ae7d64ac682bdd0  guix-build-bbd09b1773a7/output/powerpc64le-linux-gnu/SHA256SUMS.part
8054559dcece9977b9da2bd8009db0ca6a824ddf03680afd5b369121d4b689f5  guix-build-bbd09b1773a7/output/powerpc64le-linux-gnu/bitcoin-bbd09b1773a7-powerpc64le-linux-gnu-debug.tar.gz
91e6b6f8574074ef44689d357f303377574c74cbacd94aedb744626e8d3bb466  guix-build-bbd09b1773a7/output/powerpc64le-linux-gnu/bitcoin-bbd09b1773a7-powerpc64le-linux-gnu.tar.gz
7433849202360ba40bce45c64eedf91ea8a77bcd30f9a9993536f375c635f2aa  guix-build-bbd09b1773a7/output/riscv64-linux-gnu/SHA256SUMS.part
41a0fdcfbb004f08428314354c2414c4b286630db5c2eca57b538a2046426002  guix-build-bbd09b1773a7/output/riscv64-linux-gnu/bitcoin-bbd09b1773a7-riscv64-linux-gnu-debug.tar.gz
5bb0391566c8a5ddbe0f13e0f7d427f97214106eaa4da6958c52feb9a77a72c2  guix-build-bbd09b1773a7/output/riscv64-linux-gnu/bitcoin-bbd09b1773a7-riscv64-linux-gnu.tar.gz
f85257d49c5792f1d46052914a26a92d366d3b494c378d392ec9ccbd7863a231  guix-build-bbd09b1773a7/output/x86_64-apple-darwin/SHA256SUMS.part
313dcc2afa7eec4d70924763d28d465abddccf664b9aaed528d626b14ea29008  guix-build-bbd09b1773a7/output/x86_64-apple-darwin/bitcoin-bbd09b1773a7-x86_64-apple-darwin-unsigned.dmg
d83d7878c1d439b6143b7ace08d2ef8d2f5bc23a43419d02513ef6f69a1b7874  guix-build-bbd09b1773a7/output/x86_64-apple-darwin/bitcoin-bbd09b1773a7-x86_64-apple-darwin-unsigned.tar.gz
a5a55d57ca8499d323687edaf5fa3afeca45139ff9260ca10ad50ae8a2b3ed76  guix-build-bbd09b1773a7/output/x86_64-apple-darwin/bitcoin-bbd09b1773a7-x86_64-apple-darwin.tar.gz
0d14761c7a12f80b2bffa72ee76c87ebd3d636caf599a8e9b592599005e9eb00  guix-build-bbd09b1773a7/output/x86_64-linux-gnu/SHA256SUMS.part
578d43af101196dadd53e7c0544ead4e9646db91fbf9fa42c43bcd053c64bd12  guix-build-bbd09b1773a7/output/x86_64-linux-gnu/bitcoin-bbd09b1773a7-x86_64-linux-gnu-debug.tar.gz
0f78dfd0c51d5aafa243e73d4557eb4d2fe457910c24fecd664d5f2e2d5d63c5  guix-build-bbd09b1773a7/output/x86_64-linux-gnu/bitcoin-bbd09b1773a7-x86_64-linux-gnu.tar.gz
4e2aeed355c615daa0bc1d6e1fd5ff5c9c7d2ecb81d6d19fc464a7c827cbc3e1  guix-build-bbd09b1773a7/output/x86_64-w64-mingw32/SHA256SUMS.part
91dcc3d4fe4af6561ca819dc9b19e55266f5788fc817da1d5f4181a259a729ae  guix-build-bbd09b1773a7/output/x86_64-w64-mingw32/bitcoin-bbd09b1773a7-win64-debug.zip
bd1aa4be050249e1d054f7f98e8e8d33576c908466acad5d5080d20ba96c79be  guix-build-bbd09b1773a7/output/x86_64-w64-mingw32/bitcoin-bbd09b1773a7-win64-setup-unsigned.exe
a52d34a080c1c18e0c6ca3ea2d2b6726adba04af12c2d04aeb1f04de90f5e9c7  guix-build-bbd09b1773a7/output/x86_64-w64-mingw32/bitcoin-bbd09b1773a7-win64-unsigned.tar.gz
45b793e490cd79cc22f82a0da47dcfe80e1d4e3e69e0a29e77bfed39e09c1295  guix-build-bbd09b1773a7/output/x86_64-w64-mingw32/bitcoin-bbd09b1773a7-win64.zip
  27. fanquake commented at 10:11 AM on April 21, 2022: member

    The PR description has been reworked. To be precise, since Qt 5.4.2 the qglobal.h header implements the correct checks for -fPIE and -fPIC compatibility: As now we require GCC 8.1+ and Qt 5.11.3+, it is safe to rely on Qt's checks.

    So is there a reason for us to actually keep these checks in our configure at all then?

  28. hebasto commented at 10:25 AM on April 21, 2022: member

    The PR description has been reworked. To be precise, since Qt 5.4.2 the qglobal.h header implements the correct checks for -fPIE and -fPIC compatibility: As now we require GCC 8.1+ and Qt 5.11.3+, it is safe to rely on Qt's checks.

    So is there a reason for us to actually keep these checks in our configure at all then?

    To choose between -fPIE and -fPIC correctly when compiling against system Qt package, as the latter itself could be compiled with different flags.

  29. fanquake commented at 11:16 AM on April 21, 2022: member

    To choose between -fPIE and -fPIC correctly when compiling against system Qt package, as the latter itself could be compiled with different flags.

    Isn't the most relevant thing whether qt has been configured with -reduce-relocations? I think this could use a comment explaining why it's in our configure, and what it's checking for.

  30. hebasto commented at 11:31 AM on April 21, 2022: member

    To choose between -fPIE and -fPIC correctly when compiling against system Qt package, as the latter itself could be compiled with different flags.

    Isn't the most relevant thing whether qt has been configured with -reduce-relocations?

    Correct.

    I think this could use a comment explaining why it's in our configure, and what it's checking for.

    Agree. Mind suggesting one with a nice wording?

  31. achow101 commented at 6:25 PM on October 12, 2022: member

    Are you still working on this?

  32. hebasto commented at 6:32 PM on October 12, 2022: member

    Are you still working on this?

    I am. However, not sure about good wording for a comment requested by @fanquake.

    Nevertheless, closing due to the lack of interest from other developers.

  33. hebasto closed this on Oct 12, 2022
  34. bitcoin locked this on Oct 12, 2023
Contributors
hebastoOuch555jarolrodfanquakeDrahtBotachow101
Labels
Build system
Linked (view graph)
#6978 Alternative fix for #6248 (qt+fPIE)
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 21:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me