Explanation of the algorithm using Python snippets
Analysis of the maximum number of iterations the algorithm needs
Formal proof in Coq by Russell O’Connor, for a high-level equivalent algorithm
Removal of libgmp as an (optional) dependency (which wasn’t used in the Bitcoin Core build)
CI changes (Travis -> Cirrus)
Build system improvements
MarcoFalke added the label
Needs gitian build
on Apr 2, 2021
MarcoFalke added the label
Needs Guix build
on Apr 2, 2021
MarcoFalke added the label
Validation
on Apr 2, 2021
sipa
commented at 7:03 pm on April 2, 2021:
member
@sipsorcery Is there a way of disabling C4146 (at least inside src/secp256k1, and at least it being treated as an error)? All these instances of negating a positive number are well-defined and intentional…
sipsorcery
commented at 7:12 pm on April 2, 2021:
member
@sipa yes the warning should be disabled by adding <DisableSpecificWarnings>4146</DisableSpecificWarnings> to build_msvc\libsecp256k1\libsecp256k1.vcxproj.
Probably clearer putting it this way: replace the ClCompile XML node with the below:
Disable certain false positive warnings for libsecp256k1 msvc buildcabb566123
sipa force-pushed
on Apr 2, 2021
fanquake added the label
Upstream
on Apr 3, 2021
DrahtBot
commented at 1:28 am on April 3, 2021:
member
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Conflicts
Reviewers, this pull request conflicts with the following ones:
#21859 (Add minisketch subtree and integrate in build/test by sipa)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot
commented at 10:41 am on April 4, 2021:
member
DrahtBot removed the label
Needs Guix build
on Apr 6, 2021
fanquake
commented at 5:01 am on April 7, 2021:
member
Concept ACK. I’ve completed one (pruned) sync using this branch. @jamesob want to do some benchmarking?
Squashed 'src/secp256k1/' changes from 3967d96bf1..efad3506a8
efad3506a8 Merge #906: Use modified divsteps with initial delta=1/2 for constant-time
cc2c09e3a7 Merge #918: Clean up configuration in gen_context
07067967ee add ECMULT_GEN_PREC_BITS to basic_config.h
a3aa2628c7 gen_context: Don't include basic-config.h
be0609fd54 Add unit tests for edge cases with delta=1/2 variant of divsteps
cd393ce228 Optimization: only do 59 hddivsteps per iteration instead of 62
277b224b6a Use modified divsteps with initial delta=1/2 for constant-time
376ca366db Fix typo in explanation
1e5d50fa93 Merge #889: fix uninitialized read in tests
c083cc6e52 Merge #903: Make argument of fe_normalizes_to_zero{_var} const
6e898534ff Merge #907: changed import to use brackets <> for openssl
4504472269 changed import to use brackets <> for openssl as they are not local to the project
26de4dfeb1 Merge #831: Safegcd inverses, drop Jacobi symbols, remove libgmp
23c3fb629b Make argument of fe_normalizes_to_zero{_var} const
24ad04fc06 Make scalar_inverse{,_var} benchmark scale with SECP256K1_BENCH_ITERS
ebc1af700f Optimization: track f,g limb count and pass to new variable-time update_fg_var
b306935ac1 Optimization: use formulas instead of lookup tables for cancelling g bits
9164a1b658 Optimization: special-case zero modulus limbs in modinv64
1f233b3fa0 Remove num/gmp support
20448b8d09 Remove unused Jacobi symbol support
5437e7bdfb Remove unused scalar_sqr
aa9cc52180 Improve field/scalar inverse tests
1e0e885c8a Make field/scalar code use the new modinv modules for inverses
436281afdc Move secp256k1_fe_inverse{_var} to per-impl files
aa404d53be Move secp256k1_scalar_{inverse{_var},is_even} to per-impl files
08d54964e5 Improve bounds checks in modinv modules
151aac00d3 Add tests for modinv modules
d8a92fcc4c Add extensive comments on the safegcd algorithm and implementation
8e415acba2 Add safegcd based modular inverse modules
de0a643c3d Add secp256k1_ctz{32,64}_var functions
4c3ba88c3a Merge #901: ci: Switch all Linux builds to Debian and more improvements
9361f360bb ci: Select number of parallel make jobs depending on CI environment
28eccdf806 ci: Split output of logs into multiple sections
c7f754fe4d ci: Run PRs on merge result instead of on the source branch
b994a8be3c ci: Print information about binaries using "file"
f24e122d13 ci: Switch all Linux builds to Debian
ebdba03cb5 Merge #891: build: Add workaround for automake 1.13 and older
3a8b47bc6d Merge #894: ctime_test: move context randomization test to the end
7d3497cdc4 ctime_test: move context randomization test to the end
99a1cfec17 print warnings for conditional-uninitialized
3d2cf6c5bd initialize variable in tests
f329bba244 build: Add workaround for automake 1.13 and older
24d1656c32 Merge #882: Use bit ops instead of int mult for constant-time logic in gej_add_ge
e491d06b98 Use bit ops instead of int mult for constant-time logic in gej_add_ge
f8c0b57e6b Merge #864: Add support for Cirrus CI
cc2a5451dc ci: Refactor Nix shell files
2480e55c8f ci: Remove support for Travis CI
2b359f1c1d ci: Enable simple cache for brewing valgrind on macOS
8c02e465c5 ci: Add support for Cirrus CI
659d0d4798 Merge #880: Add parens around ROUND_TO_ALIGN's parameter.
b6f649889a Add parens around ROUND_TO_ALIGN's parameter. This makes the macro robust against a hypothetical ROUND_TO_ALIGN(foo ? sizeA : size B) invocation.
a4abaab793 Merge #877: Add missing secp256k1_ge_set_gej_var decl.
5671e5f3fd Merge #874: Remove underscores from header defs.
db726782fa Merge #878: Remove unused secp256k1_fe_inv_all_var
b732701faa Merge #875: Avoid casting (void**) values.
75d2ae149e Remove unused secp256k1_fe_inv_all_var
482e4a9cfc Add missing secp256k1_ge_set_gej_var decl.
2730618604 Avoid casting (void**) values. Replaced with an expression that only casts (void*) values.
fb390c5299 Remove underscores from header defs. This makes them consistent with other files and avoids reserved identifiers.
f2d9aeae6d Merge #862: Autoconf improvements
328aaef22a Merge #845: Extract the secret key from a keypair
3c15130709 Improve CC_FOR_BUILD detection
47802a4762 Restructure and tidy configure.ac
252c19dfc6 Ask brew for valgrind include path
8c727b9087 Merge #860: fixed trivial typo
b7bc3a4aaa fixed typo
33cb3c2b1f Add secret key extraction from keypair to constant time tests
36d9dc1e8e Add seckey extraction from keypair to the extrakeys tests
fc96aa73f5 Add a function to extract the secretkey from a keypair
98dac87839 Merge #858: Fix insecure links
07aa4c70ff Fix insecure links
b61f9da54e Merge #857: docs: fix simple typo, dependecy -> dependency
18aadf9d28 docs: fix simple typo, dependecy -> dependency
2d9e7175c6 Merge #852: Add sage script for generating scalar_split_lambda constants
dc6e5c3a5c Merge #854: Rename msg32 to msghash32 in ecdsa_sign/verify and add explanation
6e85d675aa Rename tweak to tweak32 in public API
f587f04e35 Rename msg32 to msghash32 in ecdsa_sign/verify and add explanation
329a2e0a3f sage: Add script for generating scalar_split_lambda constants
8f0c6f1545 Merge #851: make test count iteration configurable by environment variable
f4fa8d226a forbid a test iteration of 0 or less
f554dfc708 sage: Reorganize files
3a106966aa Merge #849: Convert Sage code to Python 3 (as used by Sage >= 9)
13c88efed0 Convert Sage code to Python 3 (as used by Sage >= 9)
0ce4554881 make test count iteration configurable by environment variable
9e5939d284 Merge #835: Don't use reserved identifiers memczero and benchmark_verify_t
d0a83f7328 Merge #839: Prevent arithmetic on NULL pointer if the scratch space is too small
903b16aa6c Merge #840: Return NULL early in context_preallocated_create if flags invalid
1f4dd03838 Typedef (u)int128_t only when they're not provided by the compiler
ebfa2058e9 Return NULL early in context_preallocated_create if flags invalid
29a299e373 Run the undefined behaviour sanitizer on Travis
7506e064d7 Prevent arithmetic on NULL pointer if the scratch space is too small
e89278f211 Don't use reserved identifiers memczero and benchmark_verify_t
git-subtree-dir: src/secp256k1
git-subtree-split: efad3506a8937162e8010f5839fdf3771dfcf516
bdca9bcb6c
Update libsecp256k1 subtree to latest upstream mastera5a447a352
libsecp256k1 no longer has --with-bignum= configure option5c7ee1b2da
sipa force-pushed
on Apr 23, 2021
sipa
commented at 7:19 pm on April 23, 2021:
member
Apologies, missed this notification. Will get some going in the next day or so.
DrahtBot
commented at 9:32 am on May 3, 2021:
member
🕵️ @practicalswift has been requested to review this pull request as specified in the REVIEWERS file.
Sjors
commented at 12:30 pm on May 5, 2021:
member
I’m running a full IBD with 5c7ee1b2da6b on mainnet with -assumevalid=0 on macOS 11.3.1 (Intel). It’s definately not a benchmark, because I’m using an external USB drive for -blocksdir which seems to dramatically slow it down. But at least it’s a consensus check.
0System: macOS 11.3, x86_64-little_endian-lp64
1Using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
2Using 16 MiB out of 32/2 requested for signature cache, able to store 524288 elements
3Using 16 MiB out of 32/2 requested for script execution cache, able to store 524288 elements
4Script verification uses 15 additional threads
Update 2021-05-07: that took a while, but it reached the tip
laanwj
commented at 5:01 pm on May 12, 2021:
member
Added this to my FreeBSD node for testing. Configure phase and compilation goes without hitch at least.
jamesob
commented at 2:13 pm on May 17, 2021:
member
Apologies, missed this notification. Will get some going in the next day or so.
Still planned, but debugging some build weirdness on the bench machines (bad interaction between ancient Debian and c++17 requirements).
jamesob
commented at 5:01 pm on May 19, 2021:
member
Happy to report that I’m seeing 1.07x speedup here.
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2024-12-21 15:12 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me
