build, qt: Fix wrong cross-compiling detection on macOS

hebasto commented at 4:57 am on April 4, 2021: member

When running make -C depends qt_configured it is expected that Qt is configured for a native build. That is not the case on master (ad4bf8a94594e7fe424e409ba9474d91584bb78c) on macOS.

This PR fixes this behavior. The diff for Qt’s “Configure summary”:

 0 Configure summary:
 1 
 2-Building on: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
 3-Building for: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
 4-Target compiler: clang (Apple) 12.0.0
 5-Configuration: cross_compile sse2 aesni sse3 ssse3 sse4_1 sse4_2 avx avx2 avx512f avx512bw avx512cd avx512dq avx512er avx512ifma avx512pf avx512vbmi avx512vl f16c largefile precompile_header rdrnd shani silent x86SimdAlways release c++11 c++14 c++1z reduce_exports static stl
 6+Build type: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
 7+Compiler: clang (Apple) 12.0.0
 8+Configuration: sse2 aesni sse3 ssse3 sse4_1 sse4_2 avx avx2 avx512f avx512bw avx512cd avx512dq avx512er avx512ifma avx512pf avx512vbmi avx512vl f16c largefile precompile_header rdrnd shani silent x86SimdAlways release c++11 c++14 c++1z reduce_exports static stl
 9 Build options:
10   Mode ................................... release
11   Optimize release build for size ........ no

Related to #21588.

Based on #21589, only the last commit belongs to this PR.

Guix builds:

 0$ find output -type f -name *$(git rev-parse --short HEAD)*.* -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1fbdc22dc3bd6c7aaf20686504ebf37c5920bef3c2e61d3746f96a450aa3b9c43  output/bitcoin-9d65a3b5a9a1-aarch64-linux-gnu-debug.tar.gz
 249610a02028a0bc99b65610c636737a8fe24a6b1d0d02f70fb8a0c25a4f71161  output/bitcoin-9d65a3b5a9a1-aarch64-linux-gnu.tar.gz
 35d07460dc2c77b740d40661f6d252da08435b255a8230158b018050c4215f74d  output/bitcoin-9d65a3b5a9a1-arm-linux-gnueabihf-debug.tar.gz
 42ce3f97ab7f2ac1198490e1437073662b17b7b8a5b335deccc07d067f4a3794c  output/bitcoin-9d65a3b5a9a1-arm-linux-gnueabihf.tar.gz
 58f76ec0227678f101d6477772ff08d74fd761558a714ff5b4b924334407b65ad  output/bitcoin-9d65a3b5a9a1-osx-unsigned.dmg
 60b9802d0cf36bc5b79835292880ec26a1fdd6e2203d8a65de345b32a44e7f7a6  output/bitcoin-9d65a3b5a9a1-osx-unsigned.tar.gz
 7470de76e81243be1cb21e33ddf6d1d1b5535f8b23678ba91a9ac2a8c824eb137  output/bitcoin-9d65a3b5a9a1-osx64.tar.gz
 8e10ba476bc901c7520b1d45e6fb68abbd13c3e3cf6d7e8edd7a881153b294123  output/bitcoin-9d65a3b5a9a1-powerpc64-linux-gnu-debug.tar.gz
 93f9fd8e74d90dc386dcd52f5ac426104d9e319853f9d2e2d796d4b9acb295567  output/bitcoin-9d65a3b5a9a1-powerpc64-linux-gnu.tar.gz
1092cef2b232cf111fbf71d4af1e928436234d8fc9030beb1e45c4229e25ae4f7d  output/bitcoin-9d65a3b5a9a1-powerpc64le-linux-gnu-debug.tar.gz
11160d6272ddffedd30935070da20fdbb4c610bcf6c9035cff59b66ab9cc0f7b35  output/bitcoin-9d65a3b5a9a1-powerpc64le-linux-gnu.tar.gz
12b05248ed798470a292d159a6993f38ef5404c13d145a2cecf671417d4cfe6cf4  output/bitcoin-9d65a3b5a9a1-riscv64-linux-gnu-debug.tar.gz
131507a8033522b5379655a8bbd27f7a56875923953f8882a4877f2c588ac2b9ec  output/bitcoin-9d65a3b5a9a1-riscv64-linux-gnu.tar.gz
1464bee253f7c0d9d498b17f00b9249da14331b8d36625ceb6e88c215528ca8536  output/bitcoin-9d65a3b5a9a1-win-unsigned.tar.gz
152596a9bfe47917f45d478a44f61ffe3d6c6b2d2555c20c24914b8ca844af9e60  output/bitcoin-9d65a3b5a9a1-win64-debug.zip
164b9edb6503ce0c87dce5341c37129d4856709f9be981e83ad7bf2c8b2f3f060d  output/bitcoin-9d65a3b5a9a1-win64-setup-unsigned.exe
175388679da7dc8ff95d6f9a42ddee57a0bc67b4f9c561a552a1663501d019b2df  output/bitcoin-9d65a3b5a9a1-win64.zip
18d8aeff23e0976287563c175bef1e4f39f90952ed8c14a33d5ef5a8e6b70e2b5c  output/bitcoin-9d65a3b5a9a1-x86_64-linux-gnu-debug.tar.gz
19038c216652ceeb3b5a03804976a57637333573d4e4989e720d8212818439a7c5  output/bitcoin-9d65a3b5a9a1-x86_64-linux-gnu.tar.gz
207693757063a6f76d223e6a3aa5e57baa08ba340f12a734dba2e9e7efcbb047e0  output/src/bitcoin-9d65a3b5a9a1.tar.gz

Gitian builds:

Linux

 0Generating report
 1b549df366d96bd73abbc01a683362b74d3ba27ee670bbfb604fa517694751c12  bitcoin-9d65a3b5a9a1-aarch64-linux-gnu-debug.tar.gz
 24e562c0be1221457dba6c18b5b9ce80da0bcca7d860569a5d0b14f24e4409783  bitcoin-9d65a3b5a9a1-aarch64-linux-gnu.tar.gz
 3b9eb7f06e97535622deefd2ba2c4516a48eae70536f26094088b22728d0a951e  bitcoin-9d65a3b5a9a1-arm-linux-gnueabihf-debug.tar.gz
 451a69ea11319aad30c3b81399d9e3eb201b3f7173679fe9e182610aed3af16e2  bitcoin-9d65a3b5a9a1-arm-linux-gnueabihf.tar.gz
 54c30717d9e6a25202c6c40636febf6c2da2ac271d9f2209a225ec61216bd2964  bitcoin-9d65a3b5a9a1-powerpc64-linux-gnu-debug.tar.gz
 60778e7de5d14a2506088f4fb11a85aa3bfc0d7bbfea526ce94bfe9fe4b89c010  bitcoin-9d65a3b5a9a1-powerpc64-linux-gnu.tar.gz
 78aedb704c5dad05705e90a57912ca9379cea7785bc4c56457e83fbe6a11d2c49  bitcoin-9d65a3b5a9a1-powerpc64le-linux-gnu-debug.tar.gz
 8cd126c010227b743327b27aaf2fc649c849ca982fb0462fd18e1ade81553e23c  bitcoin-9d65a3b5a9a1-powerpc64le-linux-gnu.tar.gz
 9ea16e3de791427275573f5ee6746eafb1a25b3b90a2b2e94ced439fa9dbd0b50  bitcoin-9d65a3b5a9a1-riscv64-linux-gnu-debug.tar.gz
10c1019627656c37866861b0fb3caa769732d51f8c84c443883442185d5816b83f  bitcoin-9d65a3b5a9a1-riscv64-linux-gnu.tar.gz
1103182ce45d38ebbf315f7281982e2d88ce9812790d861e30deccea4872ba0597  bitcoin-9d65a3b5a9a1-x86_64-linux-gnu-debug.tar.gz
12b07d854b297436ceb108d856d664ffaea61db3314e54b8605dcd63c136e47d54  bitcoin-9d65a3b5a9a1-x86_64-linux-gnu.tar.gz
137693757063a6f76d223e6a3aa5e57baa08ba340f12a734dba2e9e7efcbb047e0  src/bitcoin-9d65a3b5a9a1.tar.gz
145ccb335d55e1c2b46254418e9e91011022f04850303275a305aa2778556013d7  bitcoin-core-linux-22-res.yml
15Done.

Windows

0Generating report
194f655b25485715dbbc532f86a0442b3f44eb106059207e35a2db2cb5b1e7a84  bitcoin-9d65a3b5a9a1-win-unsigned.tar.gz
27e64758ce29e8df1436e66aee0da5ff9a1540ea4f8a35dd2e404e6b044345164  bitcoin-9d65a3b5a9a1-win64-debug.zip
37cd351abd2175fb1ea6ef13a982ac48d0f3b7dde7cf062e10eb966bab116f855  bitcoin-9d65a3b5a9a1-win64-setup-unsigned.exe
4bd4ebfb03d5704eab832aaf20841d03fec3a16370a84459049020903e98119b0  bitcoin-9d65a3b5a9a1-win64.zip
57693757063a6f76d223e6a3aa5e57baa08ba340f12a734dba2e9e7efcbb047e0  src/bitcoin-9d65a3b5a9a1.tar.gz
645db33e1d761335370081b4dffc1d4ed80a3239366ffb71d76a185c0bc6cc2ee  bitcoin-core-win-22-res.yml
7Done.

macOS

0Generating report
1e1103cc5b4237e7d9fbf45c9c0dc3b85c7decc2fb145065cef6a1bb702318aea  bitcoin-9d65a3b5a9a1-osx-unsigned.dmg
24f26998c523612f011d1540364a65bf25f9e0d957d342174334cc2ed2aabe777  bitcoin-9d65a3b5a9a1-osx-unsigned.tar.gz
3f033c5fcc46af86b25ed607512e978d9367e543c04a3bc63cb0c2a864dff0edf  bitcoin-9d65a3b5a9a1-osx64.tar.gz
47693757063a6f76d223e6a3aa5e57baa08ba340f12a734dba2e9e7efcbb047e0  src/bitcoin-9d65a3b5a9a1.tar.gz
538c18029c5a270e29e64abc16453fe20b827208fd11577c74519044971c97885  bitcoin-core-osx-22-res.yml
6Done.

hebasto added the label Build system on Apr 4, 2021

hebasto added the label macOS on Apr 4, 2021

DrahtBot commented at 6:34 am on April 4, 2021: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#22186 (build, qt: Fix compiling qt package in depends with GCC 11 by hebasto)
#22142 ([WIP] build: split depends Qt into native and target builds by fanquake)
#21420 (build, qt: No longer need to patch translation.pro by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

hebasto force-pushed on Apr 4, 2021

hebasto marked this as ready for review on Apr 4, 2021

jarolrod commented at 11:24 pm on April 4, 2021: member

ACK 9d65a3b5a9a1e5801b6242733e024b91d31c4b52

This does seem to fix the cross-compilation issue (tested on macOS 11.2.3):

Master

0Configure summary:
1
2Building on: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
3Building for: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
4Target compiler: clang (Apple) 12.0.0
5Configuration: cross_compile sse2 aesni sse3 ssse3 sse4_1 sse4_2 avx avx2 avx512f avx512bw avx512cd avx512dq avx512er avx512ifma avx512pf avx512vbmi avx512vl f16c largefile precompile_header rdrnd shani silent x86SimdAlways release c++11 c++14 c++1z reduce_exports static stl

PR

0Configure summary:
1
2Build type: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
3Compiler: clang (Apple) 12.0.0
4Configuration: sse2 aesni sse3 ssse3 sse4_1 sse4_2 avx avx2 avx512f avx512bw avx512cd avx512dq avx512er avx512ifma avx512pf avx512vbmi avx512vl f16c largefile precompile_header rdrnd shani silent x86SimdAlways release c++11 c++14 c++1z reduce_exports static stl

One observation is that macOS dark mode is still broken and does not work after building from depends with this PR.

Screen Shot 2021-04-04 at 7 12 58 PM

DrahtBot added the label Needs rebase on Apr 5, 2021

hebasto force-pushed on Apr 6, 2021

hebasto commented at 0:08 am on April 6, 2021: member

Rebased 9d65a3b5a9a1e5801b6242733e024b91d31c4b52 -> d6957db418def16a727f88652f96fce359ed9b14 (pr21591.10 -> pr21591.11) due to the conflict with #21375.

DrahtBot removed the label Needs rebase on Apr 6, 2021

jarolrod commented at 4:33 am on April 12, 2021: member

tACK d6957db418def16a727f88652f96fce359ed9b14

Tested after rebase. Confirmed clean rebase.

0Configure summary:
1
2Build type: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
3Compiler: clang (Apple) 12.0.0
4Configuration: sse2 aesni sse3 ssse3 sse4_1 sse4_2 avx avx2 avx512f avx512bw avx512cd avx512dq avx512er avx512ifma avx512pf avx512vbmi avx512vl f16c largefile precompile_header rdrnd shani silent x86SimdAlways release c++11 c++14 c++1z reduce_exports static stl

GUIX hashes for d6957db418def16a727f88652f96fce359ed9b14

 0find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1
 23bb8d6c802d9496de444ff7bdc4406b77a32e21e583f72491eab2ff46c48ec38  guix-build-d6957db418de/output/aarch64-linux-gnu/bitcoin-d6957db418de-aarch64-linux-gnu-debug.tar.gz
 3a5c1fd6511ea70aaafc7c4165e7e3ec75680cc3677051af2f0522eaabe6379bd  guix-build-d6957db418de/output/aarch64-linux-gnu/bitcoin-d6957db418de-aarch64-linux-gnu.tar.gz
 41b4577f79cb2fef406f8e55b3e9bc6038a6e9cb1bf6af29755a56d5140c33aa5  guix-build-d6957db418de/output/arm-linux-gnueabihf/bitcoin-d6957db418de-arm-linux-gnueabihf-debug.tar.gz
 59628ea5cfc7c6fc9638d1392d3dcb5d08ddd1be7cba0a2210878ae8423b371e9  guix-build-d6957db418de/output/arm-linux-gnueabihf/bitcoin-d6957db418de-arm-linux-gnueabihf.tar.gz
 6b0940099af567af12efc8fb5d7efe819acb348c5cbf9bf3ac0b335580d92e305  guix-build-d6957db418de/output/dist-archive/bitcoin-d6957db418de.tar.gz
 730873201e28454c761b555d02c2779e24c6d52cf9cdde1ffc6960523459022a4  guix-build-d6957db418de/output/powerpc64-linux-gnu/bitcoin-d6957db418de-powerpc64-linux-gnu-debug.tar.gz
 863f296cd22162f8ebefb2ece23478e893d6619b8bec19b0a903b20be93abc8d2  guix-build-d6957db418de/output/powerpc64-linux-gnu/bitcoin-d6957db418de-powerpc64-linux-gnu.tar.gz
 9ec35c1caab51c20b5727474b354ec15f703b6d8137e135ce1056b6774702db03  guix-build-d6957db418de/output/powerpc64le-linux-gnu/bitcoin-d6957db418de-powerpc64le-linux-gnu-debug.tar.gz
103bc72a60d241927acb01a8735cf84862080c570bd95d4cb1feb67341db74ed5d  guix-build-d6957db418de/output/powerpc64le-linux-gnu/bitcoin-d6957db418de-powerpc64le-linux-gnu.tar.gz
11e326d08c9df3a2254c9640b515fec1ae07de9e2b7c3ec033b05f8f8ca49cabb4  guix-build-d6957db418de/output/riscv64-linux-gnu/bitcoin-d6957db418de-riscv64-linux-gnu-debug.tar.gz
12aa35c4c05ca44b37e717b2f396a21c6e4815d0664732a3219a8d878f073b67d7  guix-build-d6957db418de/output/riscv64-linux-gnu/bitcoin-d6957db418de-riscv64-linux-gnu.tar.gz
13508ad49a29cb93d16005cbb23d8a635875f4f2e12ab47b22859408f07fc9d0fd  guix-build-d6957db418de/output/x86_64-apple-darwin18/bitcoin-d6957db418de-osx-unsigned.dmg
14beca3c3402a35c71339ddd11b11b62c3f48d27bd4093f6446cac3c9df9c61a63  guix-build-d6957db418de/output/x86_64-apple-darwin18/bitcoin-d6957db418de-osx-unsigned.tar.gz
15ab866b269ab6cfcbfac9eb529357263b073acbe6bcbcf2872c6959b2d9a4027b  guix-build-d6957db418de/output/x86_64-apple-darwin18/bitcoin-d6957db418de-osx64.tar.gz
1606aef097b2116a124a6a69c2df930fc41d522e2307cf85112670e6ed752d29ac  guix-build-d6957db418de/output/x86_64-linux-gnu/bitcoin-d6957db418de-x86_64-linux-gnu-debug.tar.gz
177408d67fcf04efd7790f717a44a3cc75893247f5f34271afa812ec677be00fab  guix-build-d6957db418de/output/x86_64-linux-gnu/bitcoin-d6957db418de-x86_64-linux-gnu.tar.gz
180a85354d2d19f1cb0b2835cf1a8b6f0e6f37188b99d66cb9cdab10a33924b897  guix-build-d6957db418de/output/x86_64-w64-mingw32/bitcoin-d6957db418de-win-unsigned.tar.gz
193a964a6d827267157476448f55c3c1f9c7851fcbfcac27bcf02da36e1c043684  guix-build-d6957db418de/output/x86_64-w64-mingw32/bitcoin-d6957db418de-win64-debug.zip
20a94537a016a1b83d1be233c8bcabb883461f55152b66ccf6e99f95842b27c200  guix-build-d6957db418de/output/x86_64-w64-mingw32/bitcoin-d6957db418de-win64-setup-unsigned.exe
21cb93d125452a39f68cb9b64d099c088627435343ca4d0568bab91184bc132006  guix-build-d6957db418de/output/x86_64-w64-mingw32/bitcoin-d6957db418de-win64.zip

hebasto closed this on Apr 12, 2021

hebasto reopened this on Apr 12, 2021

hebasto commented at 10:07 am on April 12, 2021: member

Guix builds:

 0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 13bb8d6c802d9496de444ff7bdc4406b77a32e21e583f72491eab2ff46c48ec38  guix-build-d6957db418de/output/aarch64-linux-gnu/bitcoin-d6957db418de-aarch64-linux-gnu-debug.tar.gz
 2a5c1fd6511ea70aaafc7c4165e7e3ec75680cc3677051af2f0522eaabe6379bd  guix-build-d6957db418de/output/aarch64-linux-gnu/bitcoin-d6957db418de-aarch64-linux-gnu.tar.gz
 31b4577f79cb2fef406f8e55b3e9bc6038a6e9cb1bf6af29755a56d5140c33aa5  guix-build-d6957db418de/output/arm-linux-gnueabihf/bitcoin-d6957db418de-arm-linux-gnueabihf-debug.tar.gz
 49628ea5cfc7c6fc9638d1392d3dcb5d08ddd1be7cba0a2210878ae8423b371e9  guix-build-d6957db418de/output/arm-linux-gnueabihf/bitcoin-d6957db418de-arm-linux-gnueabihf.tar.gz
 5b0940099af567af12efc8fb5d7efe819acb348c5cbf9bf3ac0b335580d92e305  guix-build-d6957db418de/output/dist-archive/bitcoin-d6957db418de.tar.gz
 630873201e28454c761b555d02c2779e24c6d52cf9cdde1ffc6960523459022a4  guix-build-d6957db418de/output/powerpc64-linux-gnu/bitcoin-d6957db418de-powerpc64-linux-gnu-debug.tar.gz
 763f296cd22162f8ebefb2ece23478e893d6619b8bec19b0a903b20be93abc8d2  guix-build-d6957db418de/output/powerpc64-linux-gnu/bitcoin-d6957db418de-powerpc64-linux-gnu.tar.gz
 8ec35c1caab51c20b5727474b354ec15f703b6d8137e135ce1056b6774702db03  guix-build-d6957db418de/output/powerpc64le-linux-gnu/bitcoin-d6957db418de-powerpc64le-linux-gnu-debug.tar.gz
 93bc72a60d241927acb01a8735cf84862080c570bd95d4cb1feb67341db74ed5d  guix-build-d6957db418de/output/powerpc64le-linux-gnu/bitcoin-d6957db418de-powerpc64le-linux-gnu.tar.gz
10e326d08c9df3a2254c9640b515fec1ae07de9e2b7c3ec033b05f8f8ca49cabb4  guix-build-d6957db418de/output/riscv64-linux-gnu/bitcoin-d6957db418de-riscv64-linux-gnu-debug.tar.gz
11aa35c4c05ca44b37e717b2f396a21c6e4815d0664732a3219a8d878f073b67d7  guix-build-d6957db418de/output/riscv64-linux-gnu/bitcoin-d6957db418de-riscv64-linux-gnu.tar.gz
12508ad49a29cb93d16005cbb23d8a635875f4f2e12ab47b22859408f07fc9d0fd  guix-build-d6957db418de/output/x86_64-apple-darwin18/bitcoin-d6957db418de-osx-unsigned.dmg
13beca3c3402a35c71339ddd11b11b62c3f48d27bd4093f6446cac3c9df9c61a63  guix-build-d6957db418de/output/x86_64-apple-darwin18/bitcoin-d6957db418de-osx-unsigned.tar.gz
14ab866b269ab6cfcbfac9eb529357263b073acbe6bcbcf2872c6959b2d9a4027b  guix-build-d6957db418de/output/x86_64-apple-darwin18/bitcoin-d6957db418de-osx64.tar.gz
1506aef097b2116a124a6a69c2df930fc41d522e2307cf85112670e6ed752d29ac  guix-build-d6957db418de/output/x86_64-linux-gnu/bitcoin-d6957db418de-x86_64-linux-gnu-debug.tar.gz
167408d67fcf04efd7790f717a44a3cc75893247f5f34271afa812ec677be00fab  guix-build-d6957db418de/output/x86_64-linux-gnu/bitcoin-d6957db418de-x86_64-linux-gnu.tar.gz
170a85354d2d19f1cb0b2835cf1a8b6f0e6f37188b99d66cb9cdab10a33924b897  guix-build-d6957db418de/output/x86_64-w64-mingw32/bitcoin-d6957db418de-win-unsigned.tar.gz
183a964a6d827267157476448f55c3c1f9c7851fcbfcac27bcf02da36e1c043684  guix-build-d6957db418de/output/x86_64-w64-mingw32/bitcoin-d6957db418de-win64-debug.zip
19a94537a016a1b83d1be233c8bcabb883461f55152b66ccf6e99f95842b27c200  guix-build-d6957db418de/output/x86_64-w64-mingw32/bitcoin-d6957db418de-win64-setup-unsigned.exe
20cb93d125452a39f68cb9b64d099c088627435343ca4d0568bab91184bc132006  guix-build-d6957db418de/output/x86_64-w64-mingw32/bitcoin-d6957db418de-win64.zip

hebasto commented at 12:20 pm on April 12, 2021: member

Guix builds:

Linux

 0Generating report
 15b062be5609ee59d02ac7c412feefab767661ef6c00f62686fed85b44f91ab5d  bitcoin-d6957db418de-aarch64-linux-gnu-debug.tar.gz
 2b3cca7bd26c42a749264c928f1af525c774ffdd1065bc23ec84cf283691d4f91  bitcoin-d6957db418de-aarch64-linux-gnu.tar.gz
 3fb590ddda68e928ec093037fd8b91bf3eb2da186776e2b46611bfcee49fcdd96  bitcoin-d6957db418de-arm-linux-gnueabihf-debug.tar.gz
 402f57a36f06e54d1a9cef7293944304ad332ae1f5d925ed856a6b999459a5d08  bitcoin-d6957db418de-arm-linux-gnueabihf.tar.gz
 5628df2ac3a37218b6795d6261ebf41a4bb8f2d57e9097be06ee97c5b1819ca51  bitcoin-d6957db418de-powerpc64-linux-gnu-debug.tar.gz
 6bf06501a5c38b064bfed7215d4bbf54941690caeda0a55c4cac44701dcd84bbd  bitcoin-d6957db418de-powerpc64-linux-gnu.tar.gz
 7fecf05339a87720c01f229457c7f55317f7bd69f9a4033d5ad01cd060b8d72ed  bitcoin-d6957db418de-powerpc64le-linux-gnu-debug.tar.gz
 82cb3e4bf714ad4a9313ff01a1706e88c391d8512560c4bea462c944659958934  bitcoin-d6957db418de-powerpc64le-linux-gnu.tar.gz
 95d36b983ca778a648d1e95af98c9e7d9619c3c9dae2b1fca1e8e459e2a5b3832  bitcoin-d6957db418de-riscv64-linux-gnu-debug.tar.gz
1029cbeab8ac8b3aabb231c7a8c56a50e7bbfaade19e2f3f4756e3b958ad1719c6  bitcoin-d6957db418de-riscv64-linux-gnu.tar.gz
118d96ae08e4188278fa0c4dce47189e1750242eed4e98b082b6a4f6239fb22ca0  bitcoin-d6957db418de-x86_64-linux-gnu-debug.tar.gz
12b2f48529a43868f44c8c489689d813e5844aa8950c8d66835f2cc8cc7f5accbe  bitcoin-d6957db418de-x86_64-linux-gnu.tar.gz
13b0940099af567af12efc8fb5d7efe819acb348c5cbf9bf3ac0b335580d92e305  src/bitcoin-d6957db418de.tar.gz
142b64eb25aee26d86ecf3567500aaf281893ec111195aed8d5db04ffe00a0ed68  bitcoin-core-linux-22-res.yml
15Done.

Windows

0Generating report
14ad5722e72de68d2da4d2315a3acc2537d89080a4c5bf2426385c49b42694081  bitcoin-d6957db418de-win-unsigned.tar.gz
204f2f3160490f40d943833ba84bc041dd8d1423f9746fc5e3a6fa248997a5d95  bitcoin-d6957db418de-win64-debug.zip
300a468ff506a0593fb1e7e638e6282a8ee0a316bc527d9590d616330cebf25e3  bitcoin-d6957db418de-win64-setup-unsigned.exe
49ac6c476a44d8f68f8bb8fcc15073b5b7b35e4ec4ceaa3108f3009d96b91f481  bitcoin-d6957db418de-win64.zip
5b0940099af567af12efc8fb5d7efe819acb348c5cbf9bf3ac0b335580d92e305  src/bitcoin-d6957db418de.tar.gz
6bcae718fca8276a76af705f53909ddd0808a7990ec94d934e09703a1e391c42e  bitcoin-core-win-22-res.yml
7Done.

macOS

0Generating report
1ebedef1a339cd171f64522112930c90a2dc8375f692dbabf481068e07463c370  bitcoin-d6957db418de-osx-unsigned.dmg
2280252f1ccd0f673596b4cba94fc0f3f53ef4094946d6f3426a084c3fa35dad9  bitcoin-d6957db418de-osx-unsigned.tar.gz
3f0b37a14dbe4988bc1d2f79ff19666bd0b48e6a193d8f4d3b81ebcb35889c908  bitcoin-d6957db418de-osx64.tar.gz
4b0940099af567af12efc8fb5d7efe819acb348c5cbf9bf3ac0b335580d92e305  src/bitcoin-d6957db418de.tar.gz
5abf4b700d2311b2a73e4db739f392ac867700885adeb9598961185fe22ce3448  bitcoin-core-osx-22-res.yml
6Done.

hebasto commented at 6:25 pm on April 23, 2021: member

@jarolrod

One observation is that macOS dark mode is still broken and does not work after building from depends with this PR.

Another observation. Building with depends on macOS Mojave 10.14.6 (18G8022). The dark mode does work. Both on master and with this PR.

hebasto commented at 12:03 pm on May 1, 2021: member

One observation is that macOS dark mode is still broken and does not work after building from depends with this PR.

Fixed in #21793.

DrahtBot added the label Needs rebase on Jun 2, 2021

build, qt: Do not require xml module for native builds in depends

This change makes Qt tools always bootstrapped.

e14d89aa36

build, qt: Fix wrong cross-compiling detection on macOS 4a9b4e9676

hebasto force-pushed on Jun 2, 2021

hebasto commented at 8:23 am on June 2, 2021: member

Rebased d6957db418def16a727f88652f96fce359ed9b14 -> 4a9b4e96765cf9e9e43e6d0aa14fb52d1af895e0 (pr21591.11 -> pr21591.12) due to the conflict with #22054.

DrahtBot removed the label Needs rebase on Jun 2, 2021

hebasto commented at 2:26 pm on June 2, 2021: member

Guix builds:

 0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 13f418196aea1d87d6b1b0aa975a292d08e902d0a7127cf44fb5033376dcd2d22  guix-build-4a9b4e96765c/output/aarch64-linux-gnu/bitcoin-4a9b4e96765c-aarch64-linux-gnu-debug.tar.gz
 2d405d79a148c0a6a8c4931da1cc188d8d610b6644fe88d96ec1e47c96d2b0412  guix-build-4a9b4e96765c/output/aarch64-linux-gnu/bitcoin-4a9b4e96765c-aarch64-linux-gnu.tar.gz
 3379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/aarch64-linux-gnu/inputs.SHA256SUMS
 4360d8c1c1b1b442933553c5a6561f85427f3c58033b1ca3c5522fb843f6e7f30  guix-build-4a9b4e96765c/output/arm-linux-gnueabihf/bitcoin-4a9b4e96765c-arm-linux-gnueabihf-debug.tar.gz
 51218f04bb34b0bb6b9998c15b8db966a30c08bc0ea4c13bd381a971eea069e3f  guix-build-4a9b4e96765c/output/arm-linux-gnueabihf/bitcoin-4a9b4e96765c-arm-linux-gnueabihf.tar.gz
 6379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/arm-linux-gnueabihf/inputs.SHA256SUMS
 7e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855  guix-build-4a9b4e96765c/output/dist-archive/SKIPATTEST.TAG
 8dadbf6a94c7236ec8d7aebd0eb5567f822ca39602e188a11972beb87a0699b37  guix-build-4a9b4e96765c/output/dist-archive/bitcoin-4a9b4e96765c.tar.gz
 96d793af6024df5a4b1442907d00c254d78774339312fdf4bc24a45c88b9445b1  guix-build-4a9b4e96765c/output/powerpc64-linux-gnu/bitcoin-4a9b4e96765c-powerpc64-linux-gnu-debug.tar.gz
101c00fdadfdedc151dc0b647cf67e0b6665e1246ed4d3579d2833ce36d7b3c9be  guix-build-4a9b4e96765c/output/powerpc64-linux-gnu/bitcoin-4a9b4e96765c-powerpc64-linux-gnu.tar.gz
11379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/powerpc64-linux-gnu/inputs.SHA256SUMS
12ffa9d203e9aa97a375eda98e0cccec53ad999e8110f6a033f79d464a8039fc13  guix-build-4a9b4e96765c/output/powerpc64le-linux-gnu/bitcoin-4a9b4e96765c-powerpc64le-linux-gnu-debug.tar.gz
138685bcee5899db8891fc2f1ac2d6a7e0039304783ff5282a4168ece1e5f9bd24  guix-build-4a9b4e96765c/output/powerpc64le-linux-gnu/bitcoin-4a9b4e96765c-powerpc64le-linux-gnu.tar.gz
14379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/powerpc64le-linux-gnu/inputs.SHA256SUMS
159ac1e9a3ff77510af52fb2715e103edfdf08bace4ed36f5b2fca520c0664c736  guix-build-4a9b4e96765c/output/riscv64-linux-gnu/bitcoin-4a9b4e96765c-riscv64-linux-gnu-debug.tar.gz
16a42666f8a6a3fc6d18a90a4d1db1c7df2e91b68bfb17a4e63ee2159f3ce0ea33  guix-build-4a9b4e96765c/output/riscv64-linux-gnu/bitcoin-4a9b4e96765c-riscv64-linux-gnu.tar.gz
17379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/riscv64-linux-gnu/inputs.SHA256SUMS
18db1128403aaee16f0421d848b77c37def9a9a4bf352be967b0c44957a2c02e2d  guix-build-4a9b4e96765c/output/x86_64-apple-darwin18/bitcoin-4a9b4e96765c-osx-unsigned.dmg
1959d3bb4f3c808a75f1440be5d391664147f3dd1e5caddb638fb274601f932341  guix-build-4a9b4e96765c/output/x86_64-apple-darwin18/bitcoin-4a9b4e96765c-osx-unsigned.tar.gz
20db2b4ff5de15d8d1006d5c3649ff7a7154c0a1886e8b5673197e10b51d5c24ff  guix-build-4a9b4e96765c/output/x86_64-apple-darwin18/bitcoin-4a9b4e96765c-osx64.tar.gz
21379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/x86_64-apple-darwin18/inputs.SHA256SUMS
22b9a8f42807030f8c8d4d96e62adf27e97fdb591b07359a87376701a9918f7a96  guix-build-4a9b4e96765c/output/x86_64-linux-gnu/bitcoin-4a9b4e96765c-x86_64-linux-gnu-debug.tar.gz
2332428117208a95f4c5675ae75453716de73b0720dc6ec2ff4be40abecdc9a57b  guix-build-4a9b4e96765c/output/x86_64-linux-gnu/bitcoin-4a9b4e96765c-x86_64-linux-gnu.tar.gz
24379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/x86_64-linux-gnu/inputs.SHA256SUMS
25d0895a083e51e1ec2c2a3c6a81759da9158c417c5813af8429af2b767adb9b8c  guix-build-4a9b4e96765c/output/x86_64-w64-mingw32/bitcoin-4a9b4e96765c-win-unsigned.tar.gz
263989e8b4b36ec102256068735ebe4c8674092fa9de2b5fcb6789cdd818ce35c7  guix-build-4a9b4e96765c/output/x86_64-w64-mingw32/bitcoin-4a9b4e96765c-win64-debug.zip
2799871fbe0354b4756011cd651623a9071fe755bccc881dbacde1d55bf7b73edd  guix-build-4a9b4e96765c/output/x86_64-w64-mingw32/bitcoin-4a9b4e96765c-win64-setup-unsigned.exe
280ce79d93ef47ab2e1ab4de26c67eb7dd05d848c6588bc66d24e8bfeb19eb18e5  guix-build-4a9b4e96765c/output/x86_64-w64-mingw32/bitcoin-4a9b4e96765c-win64.zip
29379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/x86_64-w64-mingw32/inputs.SHA256SUMS

hebasto commented at 5:44 pm on June 2, 2021: member

Could the “22.0” milestone be assigned to this PR?

MarcoFalke added this to the milestone 22.0 on Jun 3, 2021

jarolrod commented at 3:11 am on June 6, 2021: member

Concept ACK, there is a mismatch in guix hashes

Tested on macOS 11.3

Master:

0Building on: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
1Building for: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
2Target compiler: clang (Apple) 12.0.5
3Configuration: cross_compile sse2 aesni sse3 ssse3 sse4_1 sse4_2 avx avx2 avx512f avx512bw avx512cd avx512dq avx512er avx512ifma avx512pf avx512vbmi avx512vl f16c largefile precompile_header rdrnd shani silent x86SimdAlways release c++11 c++14 c++1z reduce_exports static stl

PR:

0Build type: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
1Compiler: clang (Apple) 12.0.5
2Configuration: sse2 aesni sse3 ssse3 sse4_1 sse4_2 avx avx2 avx512f avx512bw avx512cd avx512dq avx512er avx512ifma avx512pf avx512vbmi avx512vl f16c largefile precompile_header rdrnd shani silent x86SimdAlways release c++11 c++14 c++1z reduce_exports static stl

GUIX Hashes: We have a mismatch with the powerpc hashes, will run another GUIX build to double-check

 0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1
 23f418196aea1d87d6b1b0aa975a292d08e902d0a7127cf44fb5033376dcd2d22  guix-build-4a9b4e96765c/output/aarch64-linux-gnu/bitcoin-4a9b4e96765c-aarch64-linux-gnu-debug.tar.gz
 3d405d79a148c0a6a8c4931da1cc188d8d610b6644fe88d96ec1e47c96d2b0412  guix-build-4a9b4e96765c/output/aarch64-linux-gnu/bitcoin-4a9b4e96765c-aarch64-linux-gnu.tar.gz
 4379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/aarch64-linux-gnu/inputs.SHA256SUMS
 5360d8c1c1b1b442933553c5a6561f85427f3c58033b1ca3c5522fb843f6e7f30  guix-build-4a9b4e96765c/output/arm-linux-gnueabihf/bitcoin-4a9b4e96765c-arm-linux-gnueabihf-debug.tar.gz
 61218f04bb34b0bb6b9998c15b8db966a30c08bc0ea4c13bd381a971eea069e3f  guix-build-4a9b4e96765c/output/arm-linux-gnueabihf/bitcoin-4a9b4e96765c-arm-linux-gnueabihf.tar.gz
 7379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/arm-linux-gnueabihf/inputs.SHA256SUMS
 8e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855  guix-build-4a9b4e96765c/output/dist-archive/SKIPATTEST.TAG
 9dadbf6a94c7236ec8d7aebd0eb5567f822ca39602e188a11972beb87a0699b37  guix-build-4a9b4e96765c/output/dist-archive/bitcoin-4a9b4e96765c.tar.gz
1019830fc74c5853a901e49989587285cd90074ff60e06c3c317a86765c8e1cfc8  guix-build-4a9b4e96765c/output/powerpc64-linux-gnu/bitcoin-4a9b4e96765c-powerpc64-linux-gnu-debug.tar.gz
11351149de638d965f843ff954729f38fc425ee88ffd4fa747093493c4e0cdc64c  guix-build-4a9b4e96765c/output/powerpc64-linux-gnu/bitcoin-4a9b4e96765c-powerpc64-linux-gnu.tar.gz
12379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/powerpc64-linux-gnu/inputs.SHA256SUMS
13ffa9d203e9aa97a375eda98e0cccec53ad999e8110f6a033f79d464a8039fc13  guix-build-4a9b4e96765c/output/powerpc64le-linux-gnu/bitcoin-4a9b4e96765c-powerpc64le-linux-gnu-debug.tar.gz
148685bcee5899db8891fc2f1ac2d6a7e0039304783ff5282a4168ece1e5f9bd24  guix-build-4a9b4e96765c/output/powerpc64le-linux-gnu/bitcoin-4a9b4e96765c-powerpc64le-linux-gnu.tar.gz
15379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/powerpc64le-linux-gnu/inputs.SHA256SUMS
169ac1e9a3ff77510af52fb2715e103edfdf08bace4ed36f5b2fca520c0664c736  guix-build-4a9b4e96765c/output/riscv64-linux-gnu/bitcoin-4a9b4e96765c-riscv64-linux-gnu-debug.tar.gz
17a42666f8a6a3fc6d18a90a4d1db1c7df2e91b68bfb17a4e63ee2159f3ce0ea33  guix-build-4a9b4e96765c/output/riscv64-linux-gnu/bitcoin-4a9b4e96765c-riscv64-linux-gnu.tar.gz
18379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/riscv64-linux-gnu/inputs.SHA256SUMS
19db1128403aaee16f0421d848b77c37def9a9a4bf352be967b0c44957a2c02e2d  guix-build-4a9b4e96765c/output/x86_64-apple-darwin18/bitcoin-4a9b4e96765c-osx-unsigned.dmg
2059d3bb4f3c808a75f1440be5d391664147f3dd1e5caddb638fb274601f932341  guix-build-4a9b4e96765c/output/x86_64-apple-darwin18/bitcoin-4a9b4e96765c-osx-unsigned.tar.gz
21db2b4ff5de15d8d1006d5c3649ff7a7154c0a1886e8b5673197e10b51d5c24ff  guix-build-4a9b4e96765c/output/x86_64-apple-darwin18/bitcoin-4a9b4e96765c-osx64.tar.gz
22379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/x86_64-apple-darwin18/inputs.SHA256SUMS
23b9a8f42807030f8c8d4d96e62adf27e97fdb591b07359a87376701a9918f7a96  guix-build-4a9b4e96765c/output/x86_64-linux-gnu/bitcoin-4a9b4e96765c-x86_64-linux-gnu-debug.tar.gz
2432428117208a95f4c5675ae75453716de73b0720dc6ec2ff4be40abecdc9a57b  guix-build-4a9b4e96765c/output/x86_64-linux-gnu/bitcoin-4a9b4e96765c-x86_64-linux-gnu.tar.gz
25379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/x86_64-linux-gnu/inputs.SHA256SUMS
26d0895a083e51e1ec2c2a3c6a81759da9158c417c5813af8429af2b767adb9b8c  guix-build-4a9b4e96765c/output/x86_64-w64-mingw32/bitcoin-4a9b4e96765c-win-unsigned.tar.gz
273989e8b4b36ec102256068735ebe4c8674092fa9de2b5fcb6789cdd818ce35c7  guix-build-4a9b4e96765c/output/x86_64-w64-mingw32/bitcoin-4a9b4e96765c-win64-debug.zip
2899871fbe0354b4756011cd651623a9071fe755bccc881dbacde1d55bf7b73edd  guix-build-4a9b4e96765c/output/x86_64-w64-mingw32/bitcoin-4a9b4e96765c-win64-setup-unsigned.exe
290ce79d93ef47ab2e1ab4de26c67eb7dd05d848c6588bc66d24e8bfeb19eb18e5  guix-build-4a9b4e96765c/output/x86_64-w64-mingw32/bitcoin-4a9b4e96765c-win64.zip
30379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/x86_64-w64-mingw32/inputs.SHA256SUMS

fanquake commented at 8:53 am on June 9, 2021: member

For now, I’m going to close this PR, as it’s included as part of #22142. If, for some reason, we can’t get that change done fairly shortly, I’ll reopen this PR.

fanquake closed this on Jun 9, 2021

fanquake referenced this in commit 4315dc02a1 on Jul 18, 2021

sidhujag referenced this in commit 4a59fda74b on Jul 23, 2021

hebasto deleted the branch on Nov 27, 2021

DrahtBot locked this on Nov 27, 2022

build, qt: Fix wrong cross-compiling detection on macOS #21591

Guix builds:

Gitian builds:

Conflicts

Guix builds:

Guix builds:

Guix builds: