refactor: add [[noreturn]] attribute where applicable #21633

1. 
   fanquake commented at 1:36 pm on April 7, 2021: member

   Similar to #10843. We could build with -Wmissing-noreturn, however that would also mean modifying something like --suppress-external-warnings to suppress warnings for leveldb, which I don’t think we want to do. In any case, the functions where this is applicable are only added/removed very rarely.
2. fanquake added the label Refactoring on Apr 7, 2021
3. 
   practicalswift commented at 8:49 pm on April 7, 2021: contributor

   Concept ACK
4. fanquake force-pushed on Apr 8, 2021
5. vasild approved
6. 
   vasild commented at 4:16 pm on April 9, 2021: member

   ACK d1544784e972918a3a7d803bae55e5a4743fbf27

   nit: s/attributes/attribute/ in the commit message, it is just one addition :)

   I think extending --suppress-external-warnings to cover leveldb is ok - that code is not in our control, low quality there should not drag Bitcoin Core quality down. And --suppress-external-warnings is optional.

7. refactor: add [[noreturn]] attribute where applicable 003929c0d5
8. fanquake force-pushed on Apr 13, 2021
9. 
   fanquake commented at 1:01 am on April 13, 2021: member

   nit: s/attributes/attribute/ in the commit message, it is just one addition :)

   Fixed.

   I think extending –suppress-external-warnings to cover leveldb is ok

   I’ll look at doing this. We are probably also overdue for a leveldb subtree update.

10. vasild approved
11. 
    vasild commented at 8:19 am on April 13, 2021: member

    ACK 003929c0d55532038d5bf6fc0ff4a20628710fae
12. fanquake merged this on Apr 13, 2021
13. fanquake closed this on Apr 13, 2021

    ---

14. fanquake deleted the branch on Apr 13, 2021
15. sidhujag referenced this in commit 83f9e04d38 on Apr 13, 2021
16. PastaPastaPasta referenced this in commit 045abe2b67 on Jun 27, 2021
17. PastaPastaPasta referenced this in commit 3c9b783b9d on Jun 28, 2021
18. PastaPastaPasta referenced this in commit deeb2c6369 on Jun 29, 2021
19. PastaPastaPasta referenced this in commit 53b425915e on Jul 1, 2021
20. PastaPastaPasta referenced this in commit f1508881f9 on Jul 1, 2021
21. PastaPastaPasta referenced this in commit eb145dc79b on Jul 15, 2021
22. PastaPastaPasta referenced this in commit f94e5391ae on Jul 15, 2021
23. PastaPastaPasta referenced this in commit 499fb6c18b on Jul 16, 2021
24. DrahtBot locked this on Aug 18, 2022

Contributors
fanquake practicalswift vasild

Labels
Refactoring