Speedy trial activation parameters for Taproot #21686

pull achow101 wants to merge 1 commits into bitcoin:master from achow101:taproot-mtp-st-params changing 1 files +5 −5

achow101 commented at 2:37 am on April 15, 2021: member

Adds the activation parameters for taproot as specified in https://github.com/bitcoin/bips/pull/1104
luke-jr changes_requested
luke-jr commented at 2:39 am on April 15, 2021: member

Concept NACK. Devs have no authority to make consensus changes against community consensus.
JeremyRubin commented at 2:41 am on April 15, 2021: contributor

ACK 7e69b2f these match the BIP
ajtowns commented at 2:49 am on April 15, 2021: member

Maybe include the (expected) dates as comments? That’s been done in the past, see #8937. ACK otherwise.
achow101 force-pushed on Apr 15, 2021
achow101 commented at 2:53 am on April 15, 2021: member

Maybe include the (expected) dates as comments? That’s been done in the past, see #8937. ACK otherwise.

Done.
Add mainnet and testnet taproot activation params f979b3237f
achow101 force-pushed on Apr 15, 2021
JeremyRubin commented at 2:59 am on April 15, 2021: contributor

reack f979b3237f1cfc28f9c4ccb07beab558d5357a55
gmaxwell commented at 3:33 am on April 15, 2021: contributor

utACK f979b3237f1cfc28f9c4ccb07beab558d5357a55

As per: #21377 (comment)
ajtowns commented at 3:56 am on April 15, 2021: member

ACK f979b3237f1cfc28f9c4ccb07beab558d5357a55
DrahtBot added the label Validation on Apr 15, 2021
fanquake added the label Consensus on Apr 15, 2021
ajtowns commented at 5:14 am on April 15, 2021: member

Concept NACK. Devs have no authority to make consensus changes against community consensus.

Note that luke-jr is on the record as committing to NACK lot=false proposals in general, in accordance with his list post on the topic:

11:08 < luke-jr> personally I plan to NACK any LOT=False; but I doubt I would need to at this point (devs pushing against LOT=True seem to be off shed-painting other bad ideas now) 12:42 < hashcash> make a PR for core with LOT=false 12:42 < luke-jr> hashcash: I will NACK it
instagibbs commented at 5:20 am on April 15, 2021: member

“needs backport” (obviously)
fanquake added the label Needs backport (0.21) on Apr 15, 2021
instagibbs commented at 5:30 am on April 15, 2021: member

ACK f979b32 in it matches the BIP draft
clarkmoody commented at 6:13 am on April 15, 2021: none

ACK f979b32
Sjors commented at 7:53 am on April 15, 2021: member

ACK f979b3237f1cfc28f9c4ccb07beab558d5357a55

ACK f979b3237f1cfc28f9c4ccb07beab558d5357a55 —–BEGIN PGP SIGNATURE—–

iQIzBAEBCAAdFiEE7ZvfetalXiMuhFJCV/+b28wwEAkFAmB37eMACgkQV/+b28ww EAn+cw/+KXnEpGiRXlWJlUSGxyASQn9mF5iJR46E50yqOJdRaEfGDOnViRfXluZY xzgehN5rd9/HcXABD3lvRPQUEnI0NLtVdue8EcWLeRfyaNV5Tu/hYXHSw1DtO1tw ne9WR62+t71fVsVU1jHWL8fEr4wcwBnvfVBAw8hN8WrF6MICuTdIYTge5F3DLtAj L5Bj8fDbwLxmEtuJBFTXMq2yHzObzvOh47cI9pKO+ylQYZjVF03iybPFl2woBxV3 +cWZQ4SkBzMW0hCWAeHLbWpkrnrwuO+Bb8hWcVeD2MdMvUDpJtn9cOiRajb+LviW mrcxzOZU4/asEXgUa6XZZrrFeRfWq4XisEm7w+PgUNJC0z6xCBu+PLJyqNcC4xIR 2BGr/VYxidrMDNMbh/YNX6HfRecXfaOxzgVpnb0hwZDr6bQrNgYU4wLBnTYcUTiE iMtnvd6uBu/KjGsDBkRPKvxBvKQmHSxoleEQmmPX3bYfy7e++YKMApe++u4dWirk aadHx2Us9PVpIdCH/TKDhxKuYFcgI0EmaVUkALRa/ClHp9WBpdlCzqivB8TSR14F kKKd88xMhhNnynJSW4NYhflDQ7FV5ljMQR9xEnQ5UWN2mxFYPu3bw56IHTgGcT8c 6kRYQSo/FVceGI4Sg1mukZZMVaMlkvo+MFejDjuAxn2+Ig07C0Q= =pEwh —–END PGP SIGNATURE—–
jonatack approved

jonatack commented at 8:12 am on April 15, 2021: member

utACK f979b3237f1cfc28f9c4ccb07beab558d5357a55 verified with the BIP draft

0>> Time.at(1619222400).to_time.utc
1=> 2021-04-24 00:00:00 UTC
2>> Time.at(1628640000).to_time.utc
3=> 2021-08-11 00:00:00 UTC

MarcoFalke merged this on Apr 15, 2021
MarcoFalke closed this on Apr 15, 2021
jnewbery commented at 9:08 am on April 15, 2021: member

ACK f979b3237f1cfc28f9c4ccb07beab558d5357a55
achow101 referenced this in commit 37c255cdeb on Apr 15, 2021
benthecarman commented at 4:18 pm on April 15, 2021: contributor

ACK f979b3237f1cfc28f9c4ccb07beab558d5357a55
achow101 referenced this in commit 724e494800 on Apr 15, 2021
leishman commented at 7:26 pm on April 15, 2021: contributor

ACK f979b3237f1cfc28f9c4ccb07beab558d5357a55
fanquake removed the label Needs backport (0.21) on Apr 16, 2021
fanquake commented at 0:29 am on April 16, 2021: member

Being backported in #21701.
achow101 referenced this in commit cbd64c3a28 on Apr 16, 2021
MarcoFalke referenced this in commit e3b76b6c13 on Apr 16, 2021
fanquake deleted a comment on Nov 17, 2021
MarcoFalke locked this on Nov 17, 2021

Contributors
achow101 luke-jr JeremyRubin ajtowns gmaxwell instagibbs clarkmoody Sjors jonatack jnewbery benthecarman leishman fanquake

Labels
Validation Consensus