refactor: Move more stuff to blockstorage #21727

1. 
   MarcoFalke commented at 6:13 am on April 19, 2021: member

   See #21575
2. fanquake added the label Refactoring on Apr 19, 2021
3. MarcoFalke force-pushed on Apr 19, 2021
4. 
   DrahtBot commented at 12:11 pm on April 19, 2021: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #21538 (fuzz: Add fuzzing syscall sandbox: detect use of unexpected syscalls when fuzzing (“syscall sanitizer”) by practicalswift)
   • #20487 (Add syscall sandboxing using seccomp-bpf (Linux secure computing mode) by practicalswift)
   • #20452 (util: Replace use of locale dependent atoi(…) with locale-independent std::from_chars(…) (C++17) by practicalswift)
   • #20331 (allow -loadblock blocks to be unsorted by LarryRuane)
   • #19438 (Introduce deploymentstatus by ajtowns)
   • #18130 (Replace uses of boost::trim* with locale-independent alternatives by Empact)
   • #15936 (Unify bitcoin-qt and bitcoind persistent settings by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. 
   promag commented at 10:51 pm on April 19, 2021: member

   Code review ACK fa8cf6fae74f5738c2cb7a72400cd9af76d016e3. Always nice to see a nice chunk of code moved from validation.cpp. I agree this block storage related code doesn’t belong there.

   Verified commit by commit, with the given instructions, easy to review and to reason about. Only detail is that AbortNode is moved early since it is needed in an upcoming commit.

6. DrahtBot added the label Needs rebase on Apr 20, 2021
7. MarcoFalke force-pushed on Apr 20, 2021
8. 
   MarcoFalke commented at 6:40 am on April 20, 2021: member

   Rebased.

   0git range-diff bitcoin-core/master fa8cf6fae7 fab20c8f73 --word-diff-regex=.
   

9. DrahtBot removed the label Needs rebase on Apr 20, 2021
10. 
    practicalswift commented at 10:19 am on April 20, 2021: contributor

    Concept ACK

    I don’t know if that would belong in this PR or in a follow-up PR, but perhaps we want to introduce namespace blockstorage similar to how namespace init is introduced in #21732?

11. 
    MarcoFalke commented at 10:56 am on April 20, 2021: member

    I think a namespace is not the right solution here. Blockstorage is inherently stateful, so a class makes more sense. I expect that BlockManager can be recycled to be this class (after it is moved here), but this will happen in later pull requests. The changes here are focussed on move-only to simply collect the code that is blockstorage related.
12. refactor: Move pruning/reindex/importing globals to blockstorage

    Can be reviewed with --color-moved=dimmed-zebra

    fa81c30c6f
13. refactor: Move block storage globals to blockstorage

    However, keep a declaration in validation to make it possible to move
    smaller chunks to blockstorage without breaking compilation.
    
    Also, expose AbortNode in the header.
    
    Can be reviewed with --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space

    fa247a327f
14. move-only: Move constants to blockstorage fa7e64d586
15. move-only: Move functions to blockstorage fadafab833
16. style: Add { } to multi-line if

    Can be reviewed with --word-diff-regex=. --ignore-all-space

    fa09a9eac8
17. MarcoFalke force-pushed on Apr 27, 2021
18. 
    Sjors commented at 9:08 am on April 27, 2021: member

    ACK fa09a9eac8d8ab65ce4064c35a9f21349a644982
19. MarcoFalke requested review from promag on Apr 27, 2021
20. 
    kiminuo commented at 11:40 am on April 27, 2021: contributor

    ACK fa09a9e

    • Checked diff via dimmed-zebra.
    • Compiled each individual commit - success.
    • (Noticed only that IsBlockPruned is no longer an inline function.)
21. 
    promag commented at 1:45 pm on April 27, 2021: member

    Code review ACK fa09a9eac8d8ab65ce4064c35a9f21349a644982. Since last review

    git range-diff c6d6bc8abb721be68a3d2cdba11ceb5e9814c9b1 fa8cf6fae74f5738c2cb7a72400cd9af76d016e3 fa09a9eac8d8ab65ce4064c35a9f21349a644982 –word-diff-regex=.`

22. 
    DrahtBot commented at 9:31 am on May 3, 2021: member

    🕵️ @sipa has been requested to review this pull request as specified in the REVIEWERS file.

23. 
    laanwj commented at 1:59 pm on May 5, 2021: member

    Code review ACK fa09a9eac8d8ab65ce4064c35a9f21349a644982
24. laanwj merged this on May 5, 2021
25. laanwj closed this on May 5, 2021

    ---

26. MarcoFalke deleted the branch on May 5, 2021
27. sidhujag referenced this in commit 0590f58fb9 on May 5, 2021
28. ryanofsky referenced this in commit 76e3dda368 on Dec 30, 2021
29. ryanofsky referenced this in commit 84e96f649a on Jan 4, 2022
30. ryanofsky referenced this in commit 4ee68619fa on Jan 4, 2022
31. gwillen referenced this in commit 87c10268ee on Jun 1, 2022
32. DrahtBot locked this on Aug 16, 2022

Contributors
MarcoFalke DrahtBot promag practicalswift Sjors kiminuo laanwj

Labels
Refactoring