Replace uses of boost::trim* with locale-independent alternatives #18130

TrimString is an existing alternative. ~I patterned TrimRight after it.~

Note TrimString ~and TrimRight~ uses " \f\n\r\t\v" as the pattern, which is consistent with the default behavior of std::isspace. https://en.cppreference.com/w/cpp/string/byte/isspace

~Oops, should have checked outstanding PRs - #17760 covers this.~ See also #17760 (now closed)

Concept ACK

Thanks a lot for getting rid of the use of locale dependent functions! That is appreciated. Please don't hesitate to take on some of the remaining KNOWN_VIOLATIONS in subsequent pull requests. I would be happy to review :)

ACK 7cf3e02096d7991fc144ef05f5f6b7fecd475b8c modulo that the existing TrimString should be used in both places - that way TrimRight doesn't need to be introduced and maintained :)

Ok, took another look and it's straightforward to see that the value goes only to DecodeHexTx which fails on non-hex digits, so I've switched that to TrimString as well.

ACK fbc8195427cf98bf96eb76bafda39a4f38de3cd2

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--174a7506f384e20aa4161008e828411d-->

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #21727 (refactor: Move more stuff to blockstorage by MarcoFalke)
• #20452 (util: Replace use of locale dependent atoi(…) with locale-independent std::from_chars(…) (C++17) by practicalswift)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Small fixup - used clang-format-diff.py to identify a whitespace inconsistency in the last commit:

diff --git a/src/test/util_tests.cpp b/src/test/util_tests.cpp
index c3e08106e..15b8d3215 100644
--- a/src/test/util_tests.cpp
+++ b/src/test/util_tests.cpp
@@ -155,7 +155,7 @@ BOOST_AUTO_TEST_CASE(util_TrimString)
     BOOST_CHECK_EQUAL(TrimString("\t \n foo \n\tbar\t \n ", "fobar"), "\t \n foo \n\tbar\t \n ");
     BOOST_CHECK_EQUAL(TrimString("foo bar"), "foo bar");
     BOOST_CHECK_EQUAL(TrimString("foo bar", "fobar"), " ");
-    BOOST_CHECK_EQUAL(TrimString(std::string( "\0 foo \0 ", 8)), std::string("\0 foo \0", 7));
+    BOOST_CHECK_EQUAL(TrimString(std::string("\0 foo \0 ", 8)), std::string("\0 foo \0", 7));
     BOOST_CHECK_EQUAL(TrimString(std::string(" foo ", 5)), std::string("foo", 3));
     BOOST_CHECK_EQUAL(TrimString(std::string("\t\t\0\0\n\n", 6)), std::string("\0\0", 2));
     BOOST_CHECK_EQUAL(TrimString(std::string("\x05\x04\x03\x02\x01\x00", 6)), std::string("\x05\x04\x03\x02\x01\x00", 6));

ACK 44f18a552e51cdb103845b592b87dbab571f8308

Anyone willing to review @Empact's excellent PR? Would be really nice to move forward with this one and plug another source of locale dependency.

ACK 44f18a5 - nice! Next boost::split 🙄

re-ACK 4c1abe60467c1adfe0230f4bee56202150c0b134

re-ACK 12c054695201db175800e50946a85bbaa8185b9b

Nice to see the list of places where we rely on locale dependent functions shrink :)

<!--cf906140f33d8803c4a75a2196329ecb-->

🐙 This pull request conflicts with the target branch and needs rebase.

_{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}

@Empact Any chance you'd like to rebase this? Otherwise I can pick it up.

I've rebased this in #22859.