test: Bump shellcheck version #21749

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:210422-shell changing 4 files +5 −5

hebasto commented at 9:14 AM on April 22, 2021: member

The changelog for v0.7.2 is available here.

Only SC2268 requires to update our code.
test: Bump shellcheck version 08f3dbb1b0
fanquake added the label Tests on Apr 22, 2021

in depends/config.site.in:65 in 08f3dbb1b0

  61 | @@ -62,7 +62,7 @@ if test -z "$enable_zmq" && test -n "@no_zmq@"; then
  62 |    enable_zmq=no
  63 |  fi
  64 |  
  65 | -if test "x@host_os@" = xdarwin; then
  66 | +if test "@host_os@" = darwin; then

fanquake commented at 9:16 AM on April 22, 2021:

How is this related to this change

hebasto commented at 9:18 AM on April 22, 2021:

New SC2268 added.

hebasto marked this as ready for review on Apr 22, 2021
DrahtBot commented at 2:01 PM on April 22, 2021: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #21002 (script: improve scripted-diff check by 4D617278)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
practicalswift commented at 6:38 PM on April 22, 2021: contributor

Concept ACK

Nice to see unnecessary ancient x-prefix cruft ("x$1" = "x") go.
kiminuo commented at 10:09 AM on April 24, 2021: contributor

Concept ACK

The changelog shows minor useful changes.
jarolrod commented at 5:35 AM on May 10, 2021: member

ACK 08f3dbb1b0cd5ca01d87e488a2fa905adf7df057

Patch looks correct and CI is green.

grabbed 0.7.2 and ran linter locally with no problem on linux.
laanwj merged this on May 10, 2021
laanwj closed this on May 10, 2021
hebasto deleted the branch on May 10, 2021
sidhujag referenced this in commit 1aabbd39a4 on May 10, 2021
gwillen referenced this in commit c7b124ac91 on Jun 1, 2022
DrahtBot locked this on Aug 18, 2022

Contributors

Labels

test: Bump shellcheck version #21749

Conflicts