Enable -D_GLIBCXX_DEBUG via the depends DEBUG flag. Also --enable-debug to get debug symbols in traces.
ci: Enable D_GLIBCXX_DEBUG for multiprocess task #21812
pull MarcoFalke wants to merge 3 commits into bitcoin:master from MarcoFalke:2104-ciDEBUG changing 2 files +5 −5-
MarcoFalke commented at 6:34 AM on April 30, 2021: member
-
ci: Enable D_GLIBCXX_DEBUG for multiprocess task faeabef4f3
- fanquake added the label Tests on Apr 30, 2021
-
hebasto commented at 11:11 AM on April 30, 2021: member
-
fanquake commented at 7:12 AM on May 1, 2021: member
Note that
DEBUG=1is also set for depends in the previous releases job. Could addDEBUGto that description as part of this PR. -
MarcoFalke commented at 9:13 AM on May 1, 2021: member
Thanks, will do
- MarcoFalke closed this on May 1, 2021
- MarcoFalke deleted the branch on May 1, 2021
-
MarcoFalke commented at 9:14 AM on May 1, 2021: member
Closing because I wasn't aware this is already tested by another task
- MarcoFalke restored the branch on May 1, 2021
-
MarcoFalke commented at 9:16 AM on May 1, 2021: member
Reopening because the other one is using gcc and this one is using clang
- MarcoFalke reopened this on May 1, 2021
-
ci: Use clang in multiprocess task to avoid OOM fad0f21c3c
-
ci: Clarify that previous_releases task is using DEBUG fa44f5119a
- MarcoFalke force-pushed on May 1, 2021
-
MarcoFalke commented at 9:18 AM on May 1, 2021: member
Ok, addressed all feedback
-
DrahtBot commented at 2:39 PM on May 1, 2021: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #21664 (contrib: use LIEF for macOS and Windows symbol & security checks by fanquake)
- #20980 (guix: Test security-check sanity before performing them by dongcarl)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
practicalswift commented at 6:04 AM on May 2, 2021: contributor
Concept ACK
- hebasto approved
-
hebasto commented at 4:09 PM on May 3, 2021: member
ACK fa44f5119a0b412f0d46cad02f638727d140b451, I have reviewed the code and it looks OK, I agree it can be merged, and CI is green.
- iadeelzafar approved
- MarcoFalke assigned fanquake on May 3, 2021
- fanquake merged this on May 4, 2021
- fanquake closed this on May 4, 2021
- MarcoFalke deleted the branch on May 4, 2021
- sidhujag referenced this in commit d281104fc1 on May 5, 2021
- gwillen referenced this in commit 488cc1141f on Jun 1, 2022
- DrahtBot locked this on Aug 18, 2022