fuzz: Add `-fsanitize=integer` suppression needed for RPC fuzzer (`generateblock`) #21846

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:fsanitize-integer-suppression-miner changing 1 files +1 −0

practicalswift commented at 7:43 PM on May 3, 2021: contributor

Add -fsanitize=integer suppression needed for RPC fuzzer (generateblock).

Context: https://github.com/bitcoin-core/qa-assets/pull/59/checks?check_run_id=2494624259

miner.cpp:130:21: runtime error: implicit conversion from type 'int64_t' (aka 'long') of value 244763573890 (64-bit, signed) to type 'uint32_t' (aka 'unsigned int') changed the value to 4245405314 (32-bit, unsigned)
    [#0](/bitcoin-bitcoin/0/) 0x56143974eaf3 in BlockAssembler::CreateNewBlock(CScript const&) miner.cpp:130:21
    [#1](/bitcoin-bitcoin/1/) 0x56143993690d in generateblock()::$_4::operator()(RPCHelpMan const&, JSONRPCRequest const&) const rpc/mining.cpp:370:127

fuzz: Add -fsanitize=integer suppression needed for RPC fuzzer 575792e6ff
MarcoFalke commented at 7:48 PM on May 3, 2021: member

#21810 (review)
MarcoFalke commented at 7:51 PM on May 3, 2021: member

review ACK ~~withdrawn~~, but this function shouldn't be called by the rpc fuzzer, at least not without sanitizing num_blocks
practicalswift commented at 8:09 PM on May 3, 2021: contributor

@MarcoFalke

#21810 (comment) … review ACK 575792e, but this function shouldn't be called by the rpc fuzzer, at least not without sanitizing num_blocks

generateblock doesn't take num_blocks AFAICT and generate is just a no-op :)
MarcoFalke commented at 8:16 PM on May 3, 2021: member

review ACK 575792e6ffe23c8236a1f8431f6be445e448809b
MarcoFalke merged this on May 3, 2021
MarcoFalke closed this on May 3, 2021
sidhujag referenced this in commit 0fad6ad31c on May 4, 2021
gwillen referenced this in commit e64f03b7d4 on Jun 1, 2022
DrahtBot locked this on Aug 18, 2022

Contributors

practicalswift

MarcoFalke

Linked (view graph)

#1 JSON-RPC support for mobile devices ("ultra-lightweight" clients)