depends: Add missing -D_LIBCPP_DEBUG=1 to debug flags #21869

1. 
   MarcoFalke commented at 5:51 am on May 6, 2021: member

   Commands that can be used for testing:

   0$ cat 1.cpp 
   1#include <vector>
   2
   3int main() {
   4  std::vector<int> foo;
   5  foo.begin() + 7;
   6}
   

   0clang++ -stdlib=libc++ -D_GLIBCXX_DEBUG -D_GLIBCXX_DEBUG_PEDANTIC -D_LIBCPP_DEBUG=1 -Wall 1.cpp -o exe && ./exe  
   1g++                    -D_GLIBCXX_DEBUG -D_GLIBCXX_DEBUG_PEDANTIC -D_LIBCPP_DEBUG=1 -Wall 1.cpp -o exe && ./exe 
   

2. depends: Add missing -D_LIBCPP_DEBUG=1 to debug flags fa9249aacc
3. fanquake added the label Build system on May 6, 2021
4. 
   MarcoFalke commented at 5:52 am on May 6, 2021: member

   Suggested by @guidovranken in https://github.com/google/oss-fuzz/issues/5713#issuecomment-833034501. Thanks!
5. 
   fanquake commented at 5:53 am on May 6, 2021: member

   Concept ACK. https://libcxx.llvm.org/docs/DesignDocs/DebugMode.html.
6. 
   practicalswift commented at 6:49 am on May 7, 2021: contributor

   cr ACK fa9249aaccc3ef7a0a91a822e1cb666c4c9716ec: patch looks correct
7. fanquake approved
8. 
   fanquake commented at 4:05 am on May 9, 2021: member

   ACK fa9249aaccc3ef7a0a91a822e1cb666c4c9716ec - was going to suggest adding this to the macOS CPP flags as well, however it seems doing that is less straight forward. Could be looked at by someone in a followup.
9. fanquake merged this on May 9, 2021
10. fanquake closed this on May 9, 2021

    ---

11. MarcoFalke deleted the branch on May 9, 2021
12. sidhujag referenced this in commit 117dfa6006 on May 9, 2021
13. fanquake referenced this in commit 2e7c3461c0 on May 26, 2021
14. sidhujag referenced this in commit 1735ab3353 on May 27, 2021
15. PastaPastaPasta referenced this in commit 8e6ee17984 on Jun 27, 2021
16. PastaPastaPasta referenced this in commit 420f271d17 on Jun 28, 2021
17. PastaPastaPasta referenced this in commit 63a921f3ff on Jun 29, 2021
18. PastaPastaPasta referenced this in commit e591c595db on Jul 1, 2021
19. PastaPastaPasta referenced this in commit 83688c05f5 on Jul 1, 2021
20. PastaPastaPasta referenced this in commit 5d11b57e5c on Jul 15, 2021
21. gwillen referenced this in commit adc947f6ca on Jun 1, 2022
22. DrahtBot locked this on Aug 16, 2022

Contributors
MarcoFalke fanquake practicalswift

Labels
Build system