build: add configure~ to .gitignore #21911

1. 
   Sjors commented at 8:55 am on May 11, 2021: member

   The file configure~ recently started appearing for me on macOS (11.3.1) whenever configure is (re)run.
2. 
   fanquake commented at 8:57 am on May 11, 2021: member

   You should add this to your local, global, .gitignore.
3. 
   Sjors commented at 8:58 am on May 11, 2021: member

   I can do that, but what makes it different from all the other artefacts?
4. 
   laanwj commented at 9:15 am on May 11, 2021: member

   I can do that, but what makes it different from all the other artefacts?

   If it is produced by our build system it should go into .gitignore. If it is produced by your editor or IDE it should go into your local gitignore. See also #21894.

   I don’t think autotools generates a file like that, did you manually edit the configure output?

5. 
   laanwj commented at 9:18 am on May 11, 2021: member

   Curiously we have a line in .gitignore to ignore files with a ~ in them, however it doesn’t trigger because configure doesn’t have . too:

   0*.*~*
   

   I suppose something is to be said for making that more general?

6. laanwj added the label Scripts and tools on May 11, 2021
7. 
   Sjors commented at 9:34 am on May 11, 2021: member

   It’s not generated by my editor. It appears every time I run make (when it triggers a new configure, e.g. switching branches). But this only happens since recently, so there could be another problem.

   E.g. it happens when I switch between master and https://github.com/bitcoin-core/gui/pull/4 (which has trivial configure.ac change). It happens in either direction. But it does not happen when I git clean -dfx and run ./autogen and ./configure ... on either of these branches.

8. 
   hebasto commented at 1:29 pm on May 11, 2021: member

   The file configure~ recently started appearing for me on macOS (11.3.1) whenever configure is (re)run.

   This is due to the new 2.7.1 version of the autoconf Homebrew package.

9. 
   laanwj commented at 12:17 pm on May 12, 2021: member

   OK well in that case I’m fine with adding this. Though extending the existing ~ rule to be more general might still make sense.
10. 
    hebasto commented at 2:26 pm on May 12, 2021: member

    OK well in that case I’m fine with adding this. Though extending the existing ~ rule to be more general might still make sense.

    I think the following patch should work for all cases:

     0--- a/.gitignore
     1+++ b/.gitignore
     2@@ -61,7 +61,7 @@ src/qt/bitcoin-qt.includes
     3 .dirstamp
     4 .libs
     5 .*.swp
     6-*.*~*
     7+*~
     8 *.bak
     9 *.rej
    10 *.orig
    

11. build: add *~ to .gitignore

    Homebrew autoconf version 2.7.1 introduces configure~ as a build artifact.
    
    Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

    bc4538806e
12. Sjors force-pushed on May 12, 2021
13. 
    Sjors commented at 4:13 pm on May 12, 2021: member

    I switched to *~
14. 
    luke-jr commented at 4:22 pm on May 12, 2021: member

    Concept ACK to adding *~

    If it is produced by our build system it should go into .gitignore. If it is produced by your editor or IDE it should go into your local gitignore.

    Glancing at the current gitignore, we have many exceptions to this.

15. hebasto approved
16. 
    hebasto commented at 4:26 pm on May 12, 2021: member

    ACK bc4538806e3c53e7821e01d5db896f65dd3358ad, tested on Linux Mint 20.1 with different build scenarios including cross-compiling for Windows and macOS.
17. laanwj merged this on May 12, 2021
18. laanwj closed this on May 12, 2021

    ---

19. Sjors deleted the branch on May 12, 2021
20. sidhujag referenced this in commit 0136257b84 on May 13, 2021
21. PastaPastaPasta referenced this in commit da18220ba7 on Jun 27, 2021
22. PastaPastaPasta referenced this in commit d9229dde9b on Jun 28, 2021
23. PastaPastaPasta referenced this in commit 7b19ecf639 on Jun 29, 2021
24. PastaPastaPasta referenced this in commit ffac9b7c3d on Jul 1, 2021
25. PastaPastaPasta referenced this in commit f847c29b16 on Jul 1, 2021
26. PastaPastaPasta referenced this in commit aaf105c8b5 on Jul 15, 2021
27. gwillen referenced this in commit 8a9235f184 on Jun 1, 2022
28. DrahtBot locked this on Aug 16, 2022

Contributors
Sjors fanquake laanwj hebasto luke-jr

Labels
Scripts and tools