scripted-diff: rename GetSystemTimeInSeconds to GetTimeSeconds #22107

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:get_system_time_seconds_to_get_time_secomds changing 6 files +10 −10

fanquake commented at 7:22 AM on May 31, 2021: member

This PR simply renames GetSystemTimeInSeconds to GetTimeSeconds, for uniformity amongst our time handling functions (GetTimeMillis, GetTimeMicros). I have a branch that does a chunk of GetTime() -> GetSystemTimeInSeconds (GetTimeSeconds) / GetTime<T> migration, so we can eventually remove the (2 year) deprecated GetTime().

However, splitting this off and doing the renaming first while the number of GetSystemTimeInSeconds instances is small seems worthwhile.

scripted-diff: rename GetSystemTimeInSeconds to GetTimeSeconds

-BEGIN VERIFY SCRIPT-
sed -i -e 's/GetSystemTimeInSeconds/GetTimeSeconds/g' $(git grep -l GetSystemTimeInSeconds src)
-END VERIFY SCRIPT-

feb72e5432

fanquake added the label Refactoring on May 31, 2021
fanquake added the label Utils/log/libs on May 31, 2021
practicalswift commented at 8:00 AM on May 31, 2021: contributor

Concept ACK
kiminuo commented at 8:48 AM on May 31, 2021: contributor

Concept ACK
theStack commented at 9:30 AM on May 31, 2021: member

Concept ACK
DrahtBot commented at 6:19 PM on May 31, 2021: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #21878 (Make all networking code mockable by vasild)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
promag commented at 7:46 PM on May 31, 2021: member

Code review ACK feb72e5432e7a44b7f48cdab8da2c95edcec11c2.
practicalswift commented at 7:58 PM on May 31, 2021: contributor

cr ACK feb72e5432e7a44b7f48cdab8da2c95edcec11c2: patch looks correct
fanquake merged this on Jun 1, 2021
fanquake closed this on Jun 1, 2021
fanquake deleted the branch on Jun 1, 2021
sidhujag referenced this in commit f981a4f522 on Jun 1, 2021
fanquake locked this on Jun 6, 2021

Contributors

Labels