Move CBlockTreeDB to node/blockstorage #22242

1. 
   maflcko commented at 6:03 pm on June 14, 2021: member

   The block index (CBlockTreeDB) is required to write and read blocks, so move it to blockstorage
2. maflcko added the label Refactoring on Jun 14, 2021
3. maflcko added the label Block storage on Jun 14, 2021
4. 
   practicalswift commented at 8:41 pm on June 14, 2021: contributor

   Concept ACK
5. 
   DrahtBot commented at 8:53 pm on June 14, 2021: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #23581 (Move BlockManager to node/blockstorage by MarcoFalke)
   • #23517 (scripted-diff: Move miner to src/node by MarcoFalke)
   • #22932 (Guard CBlockIndex::nStatus by cs_main, require GetBlockPos/GetUndoPos to hold cs_main by jonatack)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. bitcoin deleted a comment on Jun 16, 2021
7. 
   theStack commented at 2:32 pm on June 18, 2021: contributor

   Concept ACK
8. DrahtBot added the label Needs rebase on Jun 23, 2021
9. maflcko force-pushed on Jun 29, 2021
10. DrahtBot removed the label Needs rebase on Jun 29, 2021
11. maflcko marked this as a draft on Jun 29, 2021
12. maflcko force-pushed on Jul 20, 2021
13. 
    fanquake commented at 3:02 am on November 16, 2021: member

    Concept ACK - want to rebase/fixup this?
14. maflcko force-pushed on Nov 23, 2021
15. Move ~BlockManager impl to cpp file

    This avoids compile errors in future commits.

    fa27a459bb
16. move-only: Move CBlockTreeDB to node/blockstorage

    Can be reviewed with --color-moved=dimmed-zebra

    fad86b74b5
17. fixup style of moved code

    Can be reviewed with --ignore-all-space  --word-diff-regex=.

    faea2f78d8
18. refactor: Remove dbwrapper header from blockstorage header

    There is no need to expose the internals in the header when
    only the blockstorage implementation (and txindex for
    historical reasons) care about them.

    fad4d81625
19. maflcko force-pushed on Nov 23, 2021
20. maflcko marked this as ready for review on Nov 23, 2021
21. DrahtBot added the label Needs rebase on Nov 26, 2021
22. 
    DrahtBot commented at 9:14 am on November 26, 2021: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

23. 
    DrahtBot commented at 1:06 pm on March 21, 2022: contributor

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
24. maflcko closed this on Jul 22, 2022

    ---

25. maflcko deleted the branch on Jul 22, 2022
26. bitcoin locked this on Jul 22, 2023
27. bitcoin unlocked this on Aug 1, 2023
28. maflcko removed the label Needs rebase on Aug 1, 2023
29. fanquake referenced this in commit ecab855838 on Sep 5, 2023
30. bitcoin locked this on Jul 31, 2024

Contributors
maflcko practicalswift DrahtBot theStack fanquake

Labels
Refactoring Block storage